From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Kandur via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: [PATCH] comment unused args in resize_cb() in src/widget.c Date: Tue, 7 Sep 2021 19:26:50 +0200 (CEST) Message-ID: Reply-To: Adam Kandur Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_289407_814951834.1631035610224" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12549"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 07 19:32:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNexh-000359-OU for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 19:32:45 +0200 Original-Received: from localhost ([::1]:58994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNexf-0005gv-Ob for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 13:32:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNes4-00017G-4p for emacs-devel@gnu.org; Tue, 07 Sep 2021 13:26:56 -0400 Original-Received: from w4.tutanota.de ([81.3.6.165]:53052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNes2-000876-Hx for emacs-devel@gnu.org; Tue, 07 Sep 2021 13:26:55 -0400 Original-Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 3B5571060154 for ; Tue, 7 Sep 2021 17:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631035610; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=l84ySaoH7lYCtryvKVuRAf7t3T6kiALSkP5RsjRoNZk=; b=ACRFsYLmhcEAu2/z26el5eOAVYl1pyK4gpQNCcXGrkVqxRAC4SB110IUplTQxsI4 rrtWI2Q7zhAhkKZ9cAhEAZimhqUVqNoHYhhKbUwXx6IBdPhnLSMywdrZrNj2WaxcudS ZFML9TMkozbXzN8VYHyqcMzpfltujFTkhq22wwtOda87I62b5TqnatWoUwMTK9PnmZi QPoEGsrb1oR7pf8VKKalr7Pz0KP9UG/ETmbj4uY6Xcvd9P6QCj6YzvYXcZzVGsFGp06 0inRVU15zvIC6d9SQMzg8WOW2sbr5zHpYICZ94romChzFyEoznocVlrMJgIbI3b6rpq gmi8JCty8w== Received-SPF: pass client-ip=81.3.6.165; envelope-from=rndd@tuta.io; helo=w4.tutanota.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 07 Sep 2021 13:32:07 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274272 Archived-At: ------=_Part_289407_814951834.1631035610224 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi emacs! I've been playing with emacs sources and noticed resize_cb () in src/widget.c accept 4 arguments but use only one inside. I'm new in programming (and C), but i decided to comment other args and build it. Maybe it would be usefull.Adam. ------=_Part_289407_814951834.1631035610224 Content-Type: text/x-patch; charset=us-ascii; name=0001-comment-unused-args-in-resize_cb-in-src-widget.c.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-comment-unused-args-in-resize_cb-in-src-widget.c.patch >From 8d7edc5bc1fa6078af0e8588fc37bad6e5602a1e Mon Sep 17 00:00:00 2001 From: Adam Kandur Date: Tue, 7 Sep 2021 20:20:00 +0300 Subject: [PATCH] comment unused args in resize_cb() in src/widget.c --- src/widget.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/widget.c b/src/widget.c index dd43fd1c46..6ee0a5c135 100644 --- a/src/widget.c +++ b/src/widget.c @@ -354,10 +354,10 @@ EmacsFrameInitialize (Widget request, Widget new, ArgList dum1, Cardinal *dum2) } static void -resize_cb (Widget widget, - XtPointer closure, - XEvent *event, - Boolean *continue_to_dispatch) +resize_cb (Widget widget) + /* XtPointer closure, */ + /* XEvent *event, */ + /* Boolean *continue_to_dispatch) */ { EmacsFrameResize (widget); } -- 2.32.0 ------=_Part_289407_814951834.1631035610224--