From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Wed, 02 Nov 2022 02:04:12 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58940@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 03:05:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq383-0002Cg-SI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 03:05:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oq37t-0006wS-NL; Tue, 01 Nov 2022 22:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq37m-0006tl-HJ for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 22:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oq37m-0004At-77 for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 22:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oq37l-0002sZ-Td for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 22:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 02:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.166735466711023 (code B ref 58940); Wed, 02 Nov 2022 02:05:01 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 2 Nov 2022 02:04:27 +0000 Original-Received: from localhost ([127.0.0.1]:44528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq37D-0002ri-0t for submit@debbugs.gnu.org; Tue, 01 Nov 2022 22:04:27 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:55601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq379-0002rT-NT for 58940@debbugs.gnu.org; Tue, 01 Nov 2022 22:04:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667354655; x=1667613855; bh=UcO/zHeDAgzORDA951t88Vp+amd/xhwdy1nuq0QBisI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=X25FTW7dciaE48rQ0aWLls+/xkc9+etT9oXnJYugTFM9Ln0/YGRoxNkgn6RM/D0bS Gdw+PL2tCFiezhM6dkdo43dnoof7yA6ZzxsJ5fhGl973BWLwrwwFM/opm2yITgmytH QXNve1qD+kP5Q+w8LeA63BrAFjHaW9ciduyoQ9xt8Lkd95hDOa7RuQF9PSu+YABqBj WQhLBhYGkE7UKFTnQvMyLJQkXiT8CZaq3taGSmQC/y3SWFTcEAwOtbeK5QWLYMO+Cw o5+ojWKLZclIUACoup2kEkMIh4oX/4ePIyWAzE+Hhfnq5lqdEzCXW0wOPxyQFBvDbx P6Sg8Fee2EagQ== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246828 Archived-At: This is a multi-part message in MIME format. --b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, October 31st, 2022 at 22:14, Yuan Fu wrote: > Looks good! I would add a bit more explanation/example for font-lock-prop= erty-face and font-lock-punctuation-face. Eg, it=E2=80=99s not immediately = clear to me what does preperty represent (property of an object as in obj.p= rop?). And it would be nice to say that punctuation-face are for commas and= parenthesises. I added explanations (and an example for property) to the documentation. I'm wondering if we want to separate out the punctuation as follows: - font-lock-punctuation-delimiter-face - font-lock-punctuation-bracket-face - font-lock-punctuation-special-face for any punctuation that doesn't fit in the aforementioned categories. These would all inherit from font-lock-punctuation-face. I think it would be more useful than just having font-lock-punctuation-face, since I think most people would style a particular type of punctuation, as opposed to all of it. And in the definition of the highlight queries, they will usually be grouped like above anyway. --b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I Content-Type: text/x-patch; name=0001-Add-more-font-lock-faces.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-more-font-lock-faces.patch RnJvbSA4YWI4NTQ1YWYwZGMxM2Q2ZTkwZDYyMDYzNzc3ZjkwYzUzYmVhOTExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBGcmks IDI4IE9jdCAyMDIyIDIyOjM5OjUwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG1vcmUgZm9u dC1sb2NrIGZhY2VzCgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2stZXNjYXBlLWZhY2Us IGZvbnQtbG9jay1udW1iZXItZmFjZSwKZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UsIGZvbnQtbG9j ay1wcm9wZXJ0eS1mYWNlLApmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZSk6IERlZmluZSBuZXcg ZmFjZXMuCiogbGlzcC9jdXMtdGhlbWUuZWwgKGN1c3RvbS10aGVtZS0tbGlzdGVkLWZhY2VzKTog QWRkIHRoZW0gdG8gdGhlIGxpc3QuCiogZG9jL2xpc3ByZWYvbW9kZXMudGV4aSAoRmFjZXMgZm9y IEZvbnQgTG9jayk6IERvY3VtZW50IHRoZW0uCiogZXRjL05FV1M6IE1lbnRpb24gdGhlbS4KLS0t CiBkb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogZXRjL05FV1MgICAgICAgICAgICAgICB8ICA1ICsrKysrCiBsaXNwL2N1cy10 aGVtZS5lbCAgICAgIHwgIDcgKysrKystLQogbGlzcC9mb250LWxvY2suZWwgICAgICB8IDQ1ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2Vk LCA5NSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNw cmVmL21vZGVzLnRleGkgYi9kb2MvbGlzcHJlZi9tb2Rlcy50ZXhpCmluZGV4IGQ3Nzg2MzZkNmQu LmQ5OTY0NDYxODkgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVmL21vZGVzLnRleGkKKysrIGIvZG9j L2xpc3ByZWYvbW9kZXMudGV4aQpAQCAtMzY1Myw2ICszNjUzLDQ2IEBAIEZhY2VzIGZvciBGb250 IExvY2sKIEBpdGVtIGZvbnQtbG9jay1uZWdhdGlvbi1jaGFyLWZhY2UKIEB2aW5kZXggZm9udC1s b2NrLW5lZ2F0aW9uLWNoYXItZmFjZQogZm9yIGVhc2lseS1vdmVybG9va2VkIG5lZ2F0aW9uIGNo YXJhY3RlcnMuCisKK0BpdGVtIGZvbnQtbG9jay1lc2NhcGUtZmFjZQorQHZpbmRleCBmb250LWxv Y2stZXNjYXBlLWZhY2UKK2ZvciBlc2NhcGUgc2VxdWVuY2VzIGluIHN0cmluZ3MuCisKK0BpdGVt IGZvbnQtbG9jay1udW1iZXItZmFjZQorQHZpbmRleCBmb250LWxvY2stbnVtYmVyLWZhY2UKK2Zv ciBudW1iZXJzLgorCitAaXRlbSBmb250LWxvY2stb3BlcmF0b3ItZmFjZQorQHZpbmRleCBmb250 LWxvY2stb3BlcmF0b3ItZmFjZQorZm9yIG9wZXJhdG9ycy4KKworQGl0ZW0gZm9udC1sb2NrLXBy b3BlcnR5LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKK2ZvciBwcm9wZXJ0 aWVzIG9mIGFuIG9iamVjdCwgc3VjaCBhcyB0aGUgZGVjbGFyYXRpb24gYW5kIHVzZSBvZiBmaWVs ZHMKK2luIGEgc3RydWN0LgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBj b2Rle2ZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2V9LgorCitGb3IgZXhhbXBsZSwKKworQHNt YWxsZXhhbXBsZQordHlwZWRlZiBzdHJ1Y3QKK0B7CisgIGludCBwcm9wOworLy8gICAgXiBwcm9w ZXJ0eQorQH0gb2JqOworCitpbnQgbWFpbigpCitAeworICBvYmogbzsKKyAgby5wcm9wID0gMzsK Ky8vICBeIHByb3BlcnR5CitAfQorQGVuZCBzbWFsbGV4YW1wbGUKKworQGl0ZW0gZm9udC1sb2Nr LXB1bmN0dWF0aW9uLWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKK2Zv ciBwdW5jdHVhdGlvbiBzdWNoIGFzIGRlbGltaXRlcnMgKGUuZy4gQGNvZGV7O30sIEBjb2Rlezp9 LCBAY29kZXssfSkKK2FuZCBicmFja2V0cyAoZS5nLiBAY29kZXsoKX0sIEBjb2Rle1tdfSwgQGNv ZGV7QHtAfX0pLgogQGVuZCB0YWJsZQogCiBAbm9kZSBTeW50YWN0aWMgRm9udCBMb2NrCmRpZmYg LS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGM1YTE0MmI1MDAuLmIxZTM0MmVmZjYg MTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC03MzIsNiArNzMyLDExIEBA IElmIHRoZSBjdXJyZW50IGJ1ZmZlciBpcyB2aXNpdGluZyBhIGZpbGUgdGhhdCBpcyBleGVjdXRh YmxlLCB0aGUKIFRoaXMgZGV0ZXJtaW5lcyBob3cgbG9uZyB0byBwYXVzZSBFbWFjcyBhZnRlciBh IHByb2Nlc3MKIGZpbHRlci9zZW50aW5lbCBlcnJvciBoYXMgYmVlbiBoYW5kbGVkLgogCisrKysK KyoqIE5ldyBmYWNlcyBmb3IgZm9udC1sb2NrLgorJ2ZvbnQtbG9jay1lc2NhcGUtZmFjZScsICdm b250LWxvY2stbnVtYmVyLWZhY2UnLCAnZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UnLAorJ2ZvbnQt bG9jay1wcm9wZXJ0eS1mYWNlJywgJ2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlJy4KKwogKysr CiAqKiBOZXcgZmFjZSAndmFyaWFibGUtcGl0Y2gtdGV4dCcuCiBUaGlzIGZhY2UgaXMgbGlrZSAn dmFyaWFibGUtcGl0Y2gnIChmcm9tIHdoaWNoIGl0IGluaGVyaXRzKSwgYnV0IGlzCmRpZmYgLS1n aXQgYS9saXNwL2N1cy10aGVtZS5lbCBiL2xpc3AvY3VzLXRoZW1lLmVsCmluZGV4IDkwNjgwZmY2 OGYuLmE5NzdkNjgzNGMgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLXRoZW1lLmVsCisrKyBiL2xpc3Av Y3VzLXRoZW1lLmVsCkBAIC02OCw5ICs2OCwxMiBAQCBjdXN0b20tdGhlbWUtLWxpc3RlZC1mYWNl cwogICBzaGFkb3cgc2Vjb25kYXJ5LXNlbGVjdGlvbiB0cmFpbGluZy13aGl0ZXNwYWNlCiAgIGZv bnQtbG9jay1idWlsdGluLWZhY2UgZm9udC1sb2NrLWNvbW1lbnQtZGVsaW1pdGVyLWZhY2UKICAg Zm9udC1sb2NrLWNvbW1lbnQtZmFjZSBmb250LWxvY2stY29uc3RhbnQtZmFjZQotICBmb250LWxv Y2stZG9jLWZhY2UgZm9udC1sb2NrLWRvYy1tYXJrdXAtZmFjZSBmb250LWxvY2stZnVuY3Rpb24t bmFtZS1mYWNlCisgIGZvbnQtbG9jay1kb2MtZmFjZSBmb250LWxvY2stZG9jLW1hcmt1cC1mYWNl CisgIGZvbnQtbG9jay1lc2NhcGUtZmFjZSBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlCiAg IGZvbnQtbG9jay1rZXl3b3JkLWZhY2UgZm9udC1sb2NrLW5lZ2F0aW9uLWNoYXItZmFjZQotICBm b250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNr c2xhc2gKKyAgZm9udC1sb2NrLW51bWJlci1mYWNlIGZvbnQtbG9jay1vcGVyYXRvci1mYWNlCisg IGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZSBmb250LWxvY2stcHJvcGVydHktZmFjZQorICBm b250LWxvY2stcHVuY3R1YXRpb24tZmFjZSBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tz bGFzaAogICBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWNvbnN0cnVjdCBmb250LWxvY2stc3Ry aW5nLWZhY2UKICAgZm9udC1sb2NrLXR5cGUtZmFjZSBmb250LWxvY2stdmFyaWFibGUtbmFtZS1m YWNlCiAgIGZvbnQtbG9jay13YXJuaW5nLWZhY2UgYnV0dG9uIGxpbmsgbGluay12aXNpdGVkIGZy aW5nZQpkaWZmIC0tZ2l0IGEvbGlzcC9mb250LWxvY2suZWwgYi9saXNwL2ZvbnQtbG9jay5lbApp bmRleCBlODhkYzFkM2I3Li4zODcwYTUxMmJjIDEwMDY0NAotLS0gYS9saXNwL2ZvbnQtbG9jay5l bAorKysgYi9saXNwL2ZvbnQtbG9jay5lbApAQCAtMzU5LDYgKzM1OSwyMSBAQCBmb250LWxvY2st bmVnYXRpb24tY2hhci1mYWNlCiAoZGVmdmFyIGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZQkn Zm9udC1sb2NrLXByZXByb2Nlc3Nvci1mYWNlCiAgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBwcmVw cm9jZXNzb3IgZGlyZWN0aXZlcy4iKQogCisoZGVmdmFyIGZvbnQtbG9jay1lc2NhcGUtZmFjZQkJ J2ZvbnQtbG9jay1lc2NhcGUtZmFjZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3IgZXNjYXBlIHNl cXVlbmNlcyBpbiBzdHJpbmdzLiIpCisKKyhkZWZ2YXIgZm9udC1sb2NrLW51bWJlci1mYWNlCQkn Zm9udC1sb2NrLW51bWJlci1mYWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBudW1iZXJzLiIp CisKKyhkZWZ2YXIgZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UJJ2ZvbnQtbG9jay1vcGVyYXRvci1m YWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBvcGVyYXRvcnMuIikKKworKGRlZnZhciBmb250 LWxvY2stcHJvcGVydHktZmFjZQknZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKKyAgIkZhY2UgbmFt ZSB0byB1c2UgZm9yIHByb3BlcnRpZXMuIikKKworKGRlZnZhciBmb250LWxvY2stcHVuY3R1YXRp b24tZmFjZQknZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2Ug Zm9yIHB1bmN0dWF0aW9uLiIpCisKIDs7IEZvbnRpZmljYXRpb24gdmFyaWFibGVzOgogCiAoZGVm dmFyIGZvbnQtbG9jay1rZXl3b3JkcyBuaWwKQEAgLTIwODUsNiArMjEwMCwzNiBAQCBmb250LWxv Y2stcHJlcHJvY2Vzc29yLWZhY2UKICAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdo bGlnaHQgcHJlcHJvY2Vzc29yIGRpcmVjdGl2ZXMuIgogICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNl cykKIAorKGRlZmZhY2UgZm9udC1sb2NrLWVzY2FwZS1mYWNlCisgICcoKHQgbmlsKSkKKyAgIkZv bnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgZXNjYXBlIHNlcXVlbmNlcyBpbiBz dHJpbmdzLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQor CisoZGVmZmFjZSBmb250LWxvY2stbnVtYmVyLWZhY2UKKyAgJygodCBuaWwpKQorICAiRm9udCBM b2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBudW1iZXJzLiIKKyAgOmdyb3VwICdmb250 LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2stb3Bl cmF0b3ItZmFjZQorICAnKCh0IG5pbCkpCisgICJGb250IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8g aGlnaGxpZ2h0IG9wZXJhdG9ycy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJz aW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKKyAgJygodCA6 aW5oZXJpdCBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkKKyAgIkZvbnQgTG9jayBtb2Rl IGZhY2UgdXNlZCB0byBoaWdobGlnaHQgcHJvcGVydGllcy4iCisgIDpncm91cCAnZm9udC1sb2Nr LWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLXB1bmN0dWF0 aW9uLWZhY2UKKyAgJygodCBuaWwpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhp Z2hsaWdodCBwdW5jdHVhdGlvbi4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJz aW9uICIyOS4xIikKKwogKGRlZmZhY2UgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNrc2xh c2gKICAgJygodCA6aW5oZXJpdCBib2xkKSkKICAgIkZvbnQgTG9jayBtb2RlIGZhY2UgZm9yIGJh Y2tzbGFzaGVzIGluIExpc3AgcmVnZXhwIGdyb3VwaW5nIGNvbnN0cnVjdHMuIgotLSAKMi4zOC4x Cgo= --b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I--