On Monday, October 31st, 2022 at 22:14, Yuan Fu wrote: > Looks good! I would add a bit more explanation/example for font-lock-property-face and font-lock-punctuation-face. Eg, it’s not immediately clear to me what does preperty represent (property of an object as in obj.prop?). And it would be nice to say that punctuation-face are for commas and parenthesises. I added explanations (and an example for property) to the documentation. I'm wondering if we want to separate out the punctuation as follows: - font-lock-punctuation-delimiter-face - font-lock-punctuation-bracket-face - font-lock-punctuation-special-face for any punctuation that doesn't fit in the aforementioned categories. These would all inherit from font-lock-punctuation-face. I think it would be more useful than just having font-lock-punctuation-face, since I think most people would style a particular type of punctuation, as opposed to all of it. And in the definition of the highlight queries, they will usually be grouped like above anyway.