From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Sun, 06 Nov 2022 16:43:42 +0000 Message-ID: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28798"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , casouri@gmail.com, 58940@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 06 17:45:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orimF-0007Jw-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Nov 2022 17:45:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orilh-00034Q-MO; Sun, 06 Nov 2022 11:45:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orilb-00033S-P7 for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 11:45:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orila-0001o4-57 for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 11:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orilZ-0001Kw-WC for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 11:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2022 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.16677530465033 (code B ref 58940); Sun, 06 Nov 2022 16:45:01 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 16:44:06 +0000 Original-Received: from localhost ([127.0.0.1]:60500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orikf-0001J7-UV for submit@debbugs.gnu.org; Sun, 06 Nov 2022 11:44:06 -0500 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:62067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orikc-0001IT-UT for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 11:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667753036; x=1668012236; bh=m3SPTPV45u/Equp1OcGUxKvyn1UKx1e8Jan3maGIq+g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=hK9Ifrito2IMUIGjG/O20PUFqgXsdm7e09Xa9diEcL/aQ1YxbXNdLbRorAQZP3REK pNGnleOvWRkmJ5Dz1mSLPNdhwZKGDbzDobvPw4X+0+CvNKhd5+qSvzuIHFJfDDR9YL HTYPwHm+aOo2Mp5gEPCp3xvcZuPSM++hpAIjiIJP32N/c9dD9MzeSDYut9nAvC98Q9 Xy85vlteSuR0iEcBpPwfbTpTiyN2hfvJc0RcBVc1yp4+rK3eKnn/xPcycgnE9I4920 gM93iYOrlxdSUE9sofpDAoseSp09wh1laZehqyEn13jDXXZO4iSG6qne8Wf3zfR8kq YjZhmC0kO/RYw== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247224 Archived-At: On Sunday, November 6th, 2022 at 09:05, Stefan Monnier wrote: >=20 > >> BTW I see that font-lock-regexp-grouping-{backslash,construct} >=20 > > > do not have related variables like the rest of the faces. Why is that= ? > >=20 > > No idea. I didn't even know we had those faces until I've read your > > patch. > >=20 > > Stefan, any idea why those faces don't have variables? >=20 >=20 > Not really, no. But AFAIK the "variable associated with a face" is an > old idiosyncrasy of `font-lock.el` that's never been explained > nor justified. It was used at some point for customization purposes (to > tweak the face buffer-locally) but we introduced the face-remapping > facility as a better replacement for that hack, so faces should not need > accompanying vars since Emacs-23. >=20 > I suspect that's part of the reason. Ideally, we'd phase out those old > `font-lock-*-face` variables rather than introduce new ones. > I think the only thing they bring nowadays is confusion. > Thanks, I'll remove them in the next patch. I was following 1bfbb2b706db6a7ca9420b27d22a737deccdd5b0 for inspiration, h= ence why I included them.