all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Young Arto <jifengsi@hotmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "68441@debbugs.gnu.org" <68441@debbugs.gnu.org>
Subject: bug#68441: 回复: bug#68441: Fix the unaligned tab in whitespace mode
Date: Sun, 28 Jan 2024 10:43:16 +0000	[thread overview]
Message-ID: <MEYP282MB1766C761E3608C605C0A25F3907F2@MEYP282MB1766.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <837ckcfchd.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]

So this patch changes long-standing behavior in non-trivial ways, and
I'm not sure what it can break, after so many years.  I understand
that it makes certain customizations in whitespace-mode look better on
display in some cases, but display-tables are used in Emacs not just
in whitespace-mode.
Yes, You are right. In fact, I'm not sure what it can break either. So I have
used this patch locally for about one year with self-compiled emacs29.
Fortunately, it didn't bring any side effects for me.  However, of course,
I cannot cover every function and every package for emacs.

It is really fundamental code. On the other hand, it is also annoying to
use whitespace-mode with unaligned tabs-mark. Would you be happy
if I add an option for this behavior like 'display-vector-limit-tab' which
defaults to nil? Finally, it won't change default behavior for all emacsers
and anybody like me who has trouble with this issue can turn it on in
their configuration file so they can test if it has side effects for them or
they can share this fix.

________________________________
发件人: Eli Zaretskii <eliz@gnu.org>
发送时间: 2024年1月14日 10:14
收件人: Young Arto <jifengsi@hotmail.com>
抄送: 68441@debbugs.gnu.org <68441@debbugs.gnu.org>
主题: Re: bug#68441: Fix the unaligned tab in whitespace mode

> From: Young Arto <jifengsi@hotmail.com>
> Date: Sat, 13 Jan 2024 12:23:27 +0000
> msip_labels:
>
> There is a bug in whitespace mode which used the display table to
> replace a tab with a tab-mark vector.
>
> If we has a line like this:
> ------
> 123\t5678
> ------
>
> If tab-width is 4 and tab-mark is [?> ?\t],
> The line will be displayed as following:
> (we use '^' to represent tab extra spaces)
> ------
> 123>^^^^5678
> ------
>
> However, it should be displayed as:
> ------
> 123>5678
> ------

I'm not sure I agree.  We never display a TAB as nothing, no matter if
it comes from a display vector or from a buffer or from any other
source.

So this patch changes long-standing behavior in non-trivial ways, and
I'm not sure what it can break, after so many years.  I understand
that it makes certain customizations in whitespace-mode look better on
display in some cases, but display-tables are used in Emacs not just
in whitespace-mode.

Thanks.

[-- Attachment #2: Type: text/html, Size: 8025 bytes --]

  reply	other threads:[~2024-01-28 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-13 12:23 bug#68441: Fix the unaligned tab in whitespace mode Young Arto
2024-01-14 10:14 ` Eli Zaretskii
2024-01-28 10:43   ` Young Arto [this message]
2024-01-28 11:09     ` bug#68441: 回复: " Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MEYP282MB1766C761E3608C605C0A25F3907F2@MEYP282MB1766.AUSP282.PROD.OUTLOOK.COM \
    --to=jifengsi@hotmail.com \
    --cc=68441@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.