From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: set-text-properties, remove-set-properties, add-text-properties: 1) doc string 2) return value Date: Wed, 28 Dec 2005 13:59:36 -0800 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1135807385 28379 80.91.229.2 (28 Dec 2005 22:03:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Dec 2005 22:03:05 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 28 23:02:59 2005 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ErjKw-0000TC-MO for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2005 23:00:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ErjMG-0008Vo-Jk for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2005 17:01:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ErjM7-0008Vi-Ks for emacs-devel@gnu.org; Wed, 28 Dec 2005 17:01:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ErjM4-0008V7-5d for emacs-devel@gnu.org; Wed, 28 Dec 2005 17:01:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ErjM4-0008V4-0V for emacs-devel@gnu.org; Wed, 28 Dec 2005 17:01:08 -0500 Original-Received: from [148.87.122.30] (helo=rgminet01.oracle.com) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1ErjMI-0004Nl-Lu for emacs-devel@gnu.org; Wed, 28 Dec 2005 17:01:22 -0500 Original-Received: from rgmsgw301.us.oracle.com (rgmsgw301.us.oracle.com [138.1.186.50]) by rgminet01.oracle.com (Switch-3.1.6/Switch-3.1.6) with ESMTP id jBSLxhqs012329 for ; Wed, 28 Dec 2005 14:59:43 -0700 Original-Received: from rgmsgw301.us.oracle.com (localhost [127.0.0.1]) by rgmsgw301.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id jBSLxgoe024101 for ; Wed, 28 Dec 2005 14:59:42 -0700 Original-Received: from dradamslap (dradams-lap.us.oracle.com [130.35.177.126]) by rgmsgw301.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with SMTP id jBSLxgob024093 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Wed, 28 Dec 2005 14:59:42 -0700 Original-To: "Emacs-Devel" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1506 Importance: Normal X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48460 Archived-At: 1. The set-text-properties doc string should say what the function returns. 2. Wouldn't it be more useful for set-text-properties, remove-set-properties, and add-text-properties to return the modified OBJECT (or nil if no modification occurred)? In case OBJECT is a buffer (or nil), the modified buffer substring could be returned. Perhaps it's too late to make the change in #2, if existing code depends on the current value - but maybe not: - In the case of set-text-properties, that value is not even documented. - In the case of remove-set-properties and add-text-properties, perhaps existing code only tests whether the returned value is null (instead of testing equality with t).