From: Hanwen Guo <g.hanwen@outlook.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "68042@debbugs.gnu.org" <68042@debbugs.gnu.org>
Subject: bug#68042: 30.0.50; `face-font' returns nil after adding remap relative for fontset
Date: Wed, 27 Dec 2023 06:43:46 +0000 [thread overview]
Message-ID: <ME3P282MB1505F51FA3B5FB8CC016F612949FA@ME3P282MB1505.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <83zfxw97my.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2623 bytes --]
> If you replace all instances of :fontset above with :font, fac-font
will not return nil.
Actually, if you pass the fontset through the `:font' attribute, only the ASCII font from the fontset is used. This applies to both `set-face-attribute' and `face-remap-add-relative'. AFAIU, I think when it comes to the face attributes, the fontset feature is more like a way to set different font for diferent character sets, making it able to "display the whole range of characters that Emacs supports" for a given face, since setting the `:family' attribute or assigning a single font to `:font' would suffice for setting font only for ASCII characters. So the case is, either the `:font' attribute needs to consider the full fontset, or the whole fontset feature is, as you said, "obsolete".
________________________________
From: Eli Zaretskii <eliz@gnu.org>
Sent: Wednesday, December 27, 2023 1:49
To: Hanwen Guo <g.hanwen@outlook.com>
Cc: 68042@debbugs.gnu.org <68042@debbugs.gnu.org>
Subject: Re: bug#68042: 30.0.50; `face-font' returns nil after adding remap relative for fontset
tags 68042 notabug
thanks
> From: Hanwen Guo <g.hanwen@outlook.com>
> Date: Tue, 26 Dec 2023 11:47:22 +0000
> msip_labels:
>
> Providing the `:fontset' or `:font' face attribute in the `SPEC'
> argument of `face-remap-add-relative' with `FACE' argument being
> `'default' will make the `face-font' function return nil.
>
> The following Emacs Lisp code can reproduce this behavior under 'emacs
> -Q'.
>
> (create-fontset-from-fontset-spec
> (font-xlfd-name
> (font-spec :family "Source Serif"
> :registry "fontset-variable pitch regular")))
>
> (set-face-attribute 'variable-pitch nil
> :family "Source Serif"
> :fontset "fontset-variable pitch regular")
>
> (let ((var-pitch (face-attribute 'variable-pitch :family))
> (var-fontset (face-attribute 'variable-pitch :fontset)))
> (setq mixed-pitch-variable-cookie
> (face-remap-add-relative 'default :family var-pitch :fontset var-fontset)))
>
> (face-font 'default) ;; nil
>
> (face-remap-remove-relative mixed-pitch-variable-cookie)
>
> (face-font 'default) ;; non-nil
Don't use :fontset as a face attribute; use :font instead. The value
of :font can be a fontset, so you don't need to use the (obsolete and
not really supported) :fontset attribute. The doc string of
set-face-attribute documents :font, not :fontset, and that is not an
accident.
If you replace all instances of :fontset above with :font, fac-font
will not return nil.
This is not a bug.
[-- Attachment #2: Type: text/html, Size: 4772 bytes --]
next prev parent reply other threads:[~2023-12-27 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 11:47 bug#68042: 30.0.50; `face-font' returns nil after adding remap relative for fontset Hanwen Guo
2023-12-26 17:49 ` Eli Zaretskii
2023-12-27 6:43 ` Hanwen Guo [this message]
2023-12-27 13:30 ` Eli Zaretskii
2024-06-09 20:56 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ME3P282MB1505F51FA3B5FB8CC016F612949FA@ME3P282MB1505.AUSP282.PROD.OUTLOOK.COM \
--to=g.hanwen@outlook.com \
--cc=68042@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.