From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Daniel Ortmann" Newsgroups: gmane.emacs.devel Subject: RE: [jim@meyering.net: Re: Reported bad code in Emacs configure file] Date: Fri, 3 May 2002 13:43:06 -0500 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200205031826.g43IQ5i00789@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1020452154 6395 127.0.0.1 (3 May 2002 18:55:54 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 3 May 2002 18:55:54 +0000 (UTC) Cc: Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 173iDi-0001ev-00 for ; Fri, 03 May 2002 20:55:54 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 173iJX-0000f0-00 for ; Fri, 03 May 2002 21:01:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 173i3F-0005cf-00; Fri, 03 May 2002 14:45:05 -0400 Original-Received: from mail2.lsil.com ([147.145.40.22]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 173i1X-0004w5-00; Fri, 03 May 2002 14:43:19 -0400 Original-Received: from mhbs.lsil.com (mhbs [147.145.31.100]) by mail2.lsil.com (8.9.3+Sun/8.9.1) with ESMTP id LAA17334; Fri, 3 May 2002 11:43:11 -0700 (PDT) Original-Received: from [147.145.140.52] by mhbs.lsil.com; Fri, 3 May 2002 11:43:09 -0700 Original-To: , "Alexandre Oliva" , "Akim Demaille" , "Tom Tromey" , "Paul Eggert" , "Pavel Roskin" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 In-Reply-To: <200205031826.g43IQ5i00789@aztec.santafe.edu> Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:3547 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3547 The only difference was "--without-gcc". (I am not setting the emacs_cvs_speed_t variable; neither is anything in the system, according to env | grep speed.) Note the configure script location marked with @@@ below. The "if" part does set the speed variable; the "else" part does not. And, since I am not setting it myself, I believe this is why the variable is not being set. In other words, I believe that, when using the "--without-gcc" option, the "if" part is not being run and therefore the variable is not being set. echo $ac_n "checking for speed_t""... $ac_c" 1>&6 echo "configure:3020: checking for speed_t" >&5 if eval "test \"`echo '$''{'emacs_cv_speed_t'+set}'`\" = set"; then echo $ac_n "(cached) $ac_c" 1>&6 else cat > conftest.$ac_ext < int main() { speed_t x = 1; ; return 0; } EOF if { (eval echo configure:3032: \"$ac_compile\") 1>&5; (eval $ac_compile) 2>&5; }; then rm -rf conftest* @@@ emacs_cv_speed_t=yes else echo "configure: failed program was:" >&5 cat conftest.$ac_ext >&5 fi rm -f conftest* fi echo "$ac_t""$emacs_cv_speed_t" 1>&6 if test "$emacs_cv_speed_t" = yes; then cat >> confdefs.h <<\EOF #define HAVE_SPEED_T 1 EOF fi Is there anything else I might be able to check? -----Original Message----- From: Richard Stallman [mailto:rms@gnu.org] Sent: Friday, May 03, 2002 1:26 PM To: dortmann@lsil.com Subject: [jim@meyering.net: Re: Reported bad code in Emacs configure file] Can you talk with them and together figure out what's really going on? ------- Start of forwarded message ------- To: rms@gnu.org Cc: emacs-devel@gnu.org, Alexandre Oliva , Akim Demaille , Tom Tromey , Paul Eggert , Pavel Roskin Subject: Re: Reported bad code in Emacs configure file In-Reply-To: <200205010714.g417Epo07431@aztec.santafe.edu> (Richard Stallman's message of "Wed, 1 May 2002 01:14:51 -0600 (MDT)") From: Jim Meyering Date: Wed, 01 May 2002 09:26:18 +0200 That code comes from configure.in: dnl Check for speed_t typedef. AC_CACHE_CHECK(for speed_t, emacs_cv_speed_t, AC_TRY_COMPILE([#include ], [speed_t x = 1;], emacs_cv_speed_t=yes, emacs_cv_speed_t=no)) if test $emacs_cv_speed_t = yes; then AC_DEFINE(HAVE_SPEED_T, 1, [Define to 1 if `speed_t' is declared by .]) fi Since that variable is defined either to no or to yes just above (in the absence of a cached value), I don't see a need for double quotes, unless he's doing something strange: -- he is using a corrupted cache file, or -- he has set emacs_cv_speed_t to the empty string in his environment ... > *** configure.~1~ Fri Mar 15 06:46:09 2002 > --- configure Tue Apr 30 13:26:28 2002 > *************** > *** 3039,3045 **** > fi > > echo "$ac_t""$emacs_cv_speed_t" 1>&6 > ! if test $emacs_cv_speed_t = yes; then > cat >> confdefs.h <<\EOF > #define HAVE_SPEED_T 1 > EOF > --- 3039,3045 ---- > fi > > echo "$ac_t""$emacs_cv_speed_t" 1>&6 > ! if test "$emacs_cv_speed_t" = yes; then > cat >> confdefs.h <<\EOF > #define HAVE_SPEED_T 1 > EOF ------- End of forwarded message -------