js-mode default binding for js-find-symbol

js-mode default binding for js-find-symbol

[Matthias Meulien]

Would it be ok to remove the default binding of `js-find-symbol` in 
js.el?

Current binding (M-.) hides the default binding for 
`xref-find-definition`.

Since packages like eglot or lsp-mode provide the necessary backend for 
xref to do the right job, I found it confusing to have to reenable the 
default global keybinding for buffers visiting files in js-mode...
-- 
Matthias

Re: js-mode default binding for js-find-symbol

[Dmitry Gutov]

On 10.05.2020 00:53, Matthias Meulien wrote:
> Would it be ok to remove the default binding of `js-find-symbol` in js.el?
> 
> Current binding (M-.) hides the default binding for `xref-find-definition`.

You're right, it's a problem.

> Since packages like eglot or lsp-mode provide the necessary backend for 
> xref to do the right job, I found it confusing to have to reenable the 
> default global keybinding for buffers visiting files in js-mode...

I wouldn't outright remove it, though (unless we found it never works; I 
just tried it, and it kind of does, in certain cases).

We should turn it into an xref backend instead.

Re: js-mode default binding for js-find-symbol

[Matthias Meulien]

> We should turn it into an xref backend instead.


Good idea. I'll try to do that.

-- 
Matthias

Re: js-mode default binding for js-find-symbol

[Dmitry Gutov]

On 10/05/2020 18:15, Matthias Meulien wrote:
> 
> 
>> We should turn it into an xref backend instead.
> 
> 
> Good idea. I'll try to do that.

I've been meaning to give it a try myself, but as that hasn't happened 
yet even by now in 2023, I've just removed the binding.

Sorry it waited this long.