From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Cummings Newsgroups: gmane.emacs.bugs Subject: bug#51253: 28.0.60; Meta keys broken when viper is active Date: Tue, 19 Oct 2021 23:32:09 +0000 Message-ID: References: <29G5yqRp1kUTv4CVh4sUgsUrbkl3D-i2cVAuswXYDFmmmrUhf6_Q8m10xW2NmL7RC6NY-wUcEo2_ZHzFDO9I07VdUiPCBpNfT6Iunw1vuw8=@rootabega.net> Reply-To: John Cummings Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18261"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 51253@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 01:33:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcybf-0004bl-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 01:33:20 +0200 Original-Received: from localhost ([::1]:56898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcybe-00080y-IR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 19:33:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcybO-00080n-Kv for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 19:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcybO-0002Hq-5m for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 19:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcybO-0001rc-2E for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 19:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Cummings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 23:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51253 X-GNU-PR-Package: emacs Original-Received: via spool by 51253-submit@debbugs.gnu.org id=B51253.16346863446576 (code B ref 51253); Tue, 19 Oct 2021 23:33:02 +0000 Original-Received: (at 51253) by debbugs.gnu.org; 19 Oct 2021 23:32:24 +0000 Original-Received: from localhost ([127.0.0.1]:52264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcyam-0001ho-Bk for submit@debbugs.gnu.org; Tue, 19 Oct 2021 19:32:24 -0400 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:38688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcyai-0001ZI-Jf for 51253@debbugs.gnu.org; Tue, 19 Oct 2021 19:32:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rootabega.net; s=protonmail; t=1634686332; bh=SXuXRm+o2ybpntROfMsZE0MPOuw1SevHSHF7ngtPna0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=TM/b1/41rLBs3F5dChQprEida4S4RP2rfOwIi6Xx7+treYrlWZInB0U7l7948d2Oj NuaBvRu8RU1j1AQ5/1A8zAG8XBDNTyFFWcRV/vlB5uHLnfAY9/TT6qPXEFLlRTHRAY mrbYSFJ3b0ZicUb+zQhznoAw4qOPiarwD+FPGDImGLK2PSl8CQYJPUjAbGj9Fvivr7 usyt8AymZ6PUcqlAseE0MGAq/eC1oSqtZI4+4BJfKUQp26ZSFS+30GkECe/WFBFcsO bxyzyxIzG1tAf5ElBm4CN/wDZp4f5t7rvWZuKUbBH1yX3NoFFANlxiv2cZ4rcXelwh rMQZC+IcJebJg== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217618 Archived-At: Stefan Kangas wrote: > John Cummings john@rootabega.net writes: > > > Keys like M-x, M-:, etc., are broken in viper > > vi/insert state since bug > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18182 was fixed in > > 5d522b430bd5ecfb8f082906cd634883dbb68f3e. This changed viper-ESC-key > > from to ESC, which resulted in a direct key binding of (27 > > . 'viper-intercept-ESC-key) while in the viper vi/insert states. > > Maybe that commit should just be reverted? I've looked into this some more, and I think reverting it is the way that the entirety of the viper ESC-handling stack was designed to function. At least on terminals. i.e., viper--tty-escape-filter is meant to translate a solitary ESC into [escape], which viper-intercept-ESC-key is meant to handle. And on graphical terminals, we have the prefix vs. direct binding conflict that seems to (in my limited but growing understanding) completely rule out binding any commands to ESC. But if this does get reverted, and it turns out that allowing ESC to exit vi insert is still important, it doesn't seem like it would be too difficult to ignore direct ESC command bindings when looking up meta prefix bindings here: https://git.savannah.gnu.org/cgit/emacs.git/tree/src/keymap.c?id=3Df3aa6480= 93a70c8ed15e764863a16fdf7126cdc4#n343 I've been playing with it to help me get more familiar with it; maybe I'll have a proof of concept one day.