From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kjartan =?utf-8?Q?=C3=93li_=C3=81gustsson?= Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: calibre.el Date: Tue, 18 Apr 2023 08:19:59 +0000 Message-ID: References: <87v8ht3etv.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.2; emacs 30.0.50 Cc: emacs-devel To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 18 10:37:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pogpt-0009x7-Fo for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Apr 2023 10:37:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pogp3-0006NA-6M; Tue, 18 Apr 2023 04:36:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pogp1-0006N1-Qc for emacs-devel@gnu.org; Tue, 18 Apr 2023 04:36:19 -0400 Original-Received: from mail-dbaeur03olkn2050.outbound.protection.outlook.com ([40.92.58.50] helo=EUR03-DBA-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pogp0-0000TR-7t for emacs-devel@gnu.org; Tue, 18 Apr 2023 04:36:19 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEcFjcCuzqGVx7Ek7yBQIKTuudRtiwb+2ppIVpuAJwgq5T8qoAfR4J+NhHv3LLPrO54mPxi2cGAfm0z29+05fLMtULQR2v03eGOmWFQ+KS8efq2VOpfiAwrIQZJw/VpDEO/7Yf0sp2saw57PJjTTLFDi7FQMoTLeCxn9MnfLGHYRgoUMpyztHXQwnTD45fKM7ib1C28UFKC6nvGJ3Yur99IAjGupfOQ9VyOd2uXM9IFlIEguy5h0VBg/sHpzBWUH1C1DDuhh5QqbXY3ij8sPSzSgb+WhQ4mGOx6XRVbDHA/xyoTCDeXrh4K86jvu/C0msmpmkGGORHQN9Xo8CsnR/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8hc+464U9WCvYUqacZ5quGdlScZ7d7za6g6Xt+4wJWk=; b=hGhy8zN6NOiMFo0uddD/MjGWS822SMZFQEFymP8viiEwmCSASN23JKylf4VH7sY4WIEbm2A/Y7gw3VC/4RMDZIhcBWNcmIq0XjsPnX/Ic+42xNPq16NnBWlH6lbvM8UgBOtjC0nBRXL+baSk9kIP1cuYlF5IJwLU9Gxij17f2xoWeeD/xsiabLzIy54tDjfSLqZvIdvo1X2GHmOOy5tGYrdJ6UlrOT4GLPAx3b+xURpkqMLQmy5iXcH5St/mSYUc5pgkJyV1pWNuhCtwuF3VE0mkIQD9UjSZmtpKtqrw6b7lms2yKkbSzB3y09rPmUPhRagwZ1uL2q1X82lvzE3alw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8hc+464U9WCvYUqacZ5quGdlScZ7d7za6g6Xt+4wJWk=; b=JvH6PlkHt7YdaXeqvRnhBYOAW96tUGeIPiu6DNe957Aj1n09p6yPJy1ojAaqUgSYnak4axoRU0dNDbvdlFgZevkRsuCrH08O558YDeX8M/DEwXHCzCoBZ2XyTQfLLBwyjQhapPgPJ/qnvoqVd/sPnNaUZtyLKrPESzqO4i5ebHKDQUq8xJdrGqGGmslblAPqyDvW0zf4tNcFyLN0GaSPmvqxqCDKcFE49V5SvUvzikwG5/YaEKSKkBYrKOemFO2ak8ih8ActgkZRBVGbAlE4bAK7ABK9Qop7hFeuDjgrKPFZZaNf9vajXzHxpFifEbz4Qq8ImWTCoRyzzB9gZojseg== Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) by DB8P193MB0661.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:15d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 08:36:15 +0000 Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::27af:327b:5614:4a79]) by GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::27af:327b:5614:4a79%2]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 08:36:15 +0000 In-reply-to: <87v8ht3etv.fsf@posteo.net> X-TMN: [9i338OqA7C575NhwE1L4/u3d+RW4IvTd] X-ClientProxiedBy: LO6P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::14) To GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) X-Microsoft-Original-Message-ID: <87pm81egec.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P193MB2310:EE_|DB8P193MB0661:EE_ X-MS-Office365-Filtering-Correlation-Id: 203eb64f-700c-45b3-e30e-08db3fe7f8c7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M2gsN5lVkDIf7RGNKTenfDnTvKoiZzUKVTU/1fSqgQkxVtl3YVW4zVckOJPFqU6FHximHn1MA7sPOJOQQdAc/yVlq4pnskPGOL0vS9FnR6jRHz07FKcC8a0j+QYPzh/jHwpyfzIMHl5jn5EUkuKx284HR2gYPsil0DlIMLJQ33VpEvFCVy00rsOsnVcjueB0cRU7HPQng1x6iGYuzTLAm23FZ7WBT8kKVSARu1f/KD57pbo/dvpW8C7UpB/ArPYuaM7WTkcKEBaDPzZyf5O3OS1K5dhDnJyrLLE7eoq9H5EYYt1/peKKuWRlGeVC6TlS3ci15oWJwozN8fKmN1Jfa926mOgLTQ1gBi7+rVBx1BEolqj7STU8KQ1ZgYZoyxlsvZ8XmrbjfkCujZkc9N+nTiQjrYIr2dBAsLKs1Og8wkzhqQ9brn9OpDCx1+N7tJTmNbMdOl4SiMN07uZSZr1Dn2aoS/B5pjiJ4UEO2Q2Da+vfB0z2+7o2t+sW/8if/0jqZk204UGw22AfBkpbXaMU/AWvgL5rNvdt/NSE2HgFfHVo3Exc61/2Xorx5DZavSJr1HKk2Z9m46/NoTs23g+pihpqk9pyk007lOW1IId2QowYDVL1smdILkGbVcykZ3nM X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+/2FzSFRKMt5vDO0ejInNFDdLII0CGoDU0tztJbSrLpp0ML1+2+NXsYqKsTu?= =?us-ascii?Q?qb/Oc7JuSPa8KReAZ7YeIWgsgWUF2gPZH/kFbW7ktTAkhBI+ovA3LPP9jOOp?= =?us-ascii?Q?BzcTXKKhSU6Afm4c2giiw4HfHnHzBSSIZslnVLq1vM8ne4ePYPpBCGlBcyVN?= =?us-ascii?Q?w6ZgEPqPfnTQjVvRXh8vQFcOoZO3tXj7osWstKKRHDNtc5PkRrLt+6RQSOBu?= =?us-ascii?Q?bxl2DyD2BPMVQIY6fiS3/9qWN9dhY6d2ontzSnROKpET1JUDJJ62zuzKQyzv?= =?us-ascii?Q?lHakP2odxzhwk7KU6TmaDDL56A4fTDdYOUuxnGypmJeOt1tAuzhYfUTqP0WF?= =?us-ascii?Q?uxvWjooTbk8taBDA/+iCTLvyWT24+sQPcBnvv5an38aqXBkoO+WWhEB2y5BN?= =?us-ascii?Q?h47A9JnS2Gr9AJ3FPt7QW5oCL0+CCWKW45c07wPL9asPTR71mDUk8SguErOk?= =?us-ascii?Q?IwGsDhuxGGgugib5bFqX5zkcySb/DYsZa6fDVhG6NAy+lyFhG2TdMi4il/Br?= =?us-ascii?Q?odiad+a4VfhWtqFPoWy/uRR5cq2saqT95T0yWFs37OURQUysW7w3YCCIahlR?= =?us-ascii?Q?+GGURq7uL03b9+V1vjNzQlYrSW6UDMPCQ8OdDY4QCB+SQeA/pBNGLQcMZgqX?= =?us-ascii?Q?7+ X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 203eb64f-700c-45b3-e30e-08db3fe7f8c7 X-MS-Exchange-CrossTenant-AuthSource: GV1P193MB2310.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 08:36:15.1499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8P193MB0661 Received-SPF: pass client-ip=40.92.58.50; envelope-from=kjartanoli@outlook.com; helo=EUR03-DBA-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305400 Archived-At: Thank you for taking the time to look at it. >> Would there be any >> interest in adding it to GNU ELPA? And if so, is my copyright assignment >> for Emacs sufficient, or does ELPA require a separate assignment? > > No separate assignment is necessary, as GNU ELPA packages are regarded > to be part of Emacs. Good to know. >> This is my first attempt at writing an Emacs package, so I expect to >> have gotten many things wrong. As such I would welcome reviews from >> people who know more about Elisp packaging. > > The first thing to note is that you don't need a -pkg.el file. ELPA > will generate one for you using the metadata in the main file and > overwrite whatever you have written. Another good to know. I remember reading that somewhere, but then I looked at some other packages that seemed to maintain a -pkg.el file. > This means you should copy the metadata to calibre.el. Especially the > dependency list. (Also, why do you depend on "29.1.0", a version which > is unreleased and has an additional ".0" at the end? I guess you need > Emacs 29 because of SQLite? Have you taken a look at emacsql?) I'll definitely fix the .0 thing. You are correct that the dependency on Emacs 29 is for SQLite. Emacsql would not work, since I am interacting with an existing database maintained by Calibre. If you want to wait until Emacs 29 is released to add it I would definitely agree to that. > From a brief skim of the code, it looks more or less fine. There are > minor things I am not sure about (such as the usage of eieio or why you > declare some functions instead of requiring the file). The functions that are declared instead of required currently cause a recursive require because of how the package is structured. I am hoping to refactor this soon. As for the usage of eieio, is there a reason not to use it? -- Kjartan Oli Agustsson GPG Key fingerprint: 4801 0D71 49C0 1DD6 E5FD 6AC9 D757 2FE3 605E E6B0