From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kjartan Oli Agustsson Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support Date: Mon, 07 Mar 2022 00:17:06 +0000 Message-ID: References: <87mti2env9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26939"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 29.0.50 Cc: Daniel Nicolai , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 07 01:38:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nR1Os-0006no-Ea for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 01:38:58 +0100 Original-Received: from localhost ([::1]:42338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nR1Oq-00055c-Vo for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Mar 2022 19:38:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR1NS-0003o7-My for emacs-devel@gnu.org; Sun, 06 Mar 2022 19:37:30 -0500 Original-Received: from mail-oln040092073035.outbound.protection.outlook.com ([40.92.73.35]:4382 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR1NQ-0002NG-3n for emacs-devel@gnu.org; Sun, 06 Mar 2022 19:37:30 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9pToJo95+3P7vRLWO0jHtTw/qDQsoJ87h7obuiDeMKmrTgmHwbLBt0GWZ+8K78HLKqftU/NEOaYDciev+Atk4RpXgGHz43ODWSXpI+2WBphyMt0+Y53MEppt3jUBZMW4Yy1YkuKrKZXH2icCVlU63Ik+dcDQmE1nm1kQHW79rK2eKcH2sSYlFnt0IXiVIimLmSmoVcak+MaEsr+pIwweNHgp40BY/Ic/m4+KP4dUeCq1B/ujdqnHNCCoWGGeeXWvU9HNC+F/NLJmEBUTbb7QKdK59QnaSNaJdVV+QALIhXhG4PGzF/lj9nKNlUaZ8W5M/Heb5dtAsIrn1qsrKZl0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6OXFGWc0VCRKhNAmb4jnhKHq/lpzeCWIjOm2NSpxLlc=; b=Fmy0o27Lkce1BekWFacTep9a/XSvij7TqAUL3OVj8EV8ibl2pJB+XzU1yEgOGYff0Kx4hexDO9U7CdIUAFQfYhcw0MkCaoE1L5ORFV7VFeEQ6mUS5h9HcV+Im4u/pWJ5Zj1iA5CYKOIx/evrfepdv0amH0z6QFDKDq/YQkUsvwc1AkY38JQqJ/h/KWbJ4WkISMFsnJ9nNrkScmy3IoQxkA+1Z76KprZ1IrHSUWGLmbyIpl8+yOHBP5warse7xRyNCDx/NI+nJC+IxUr4/xv5/0tWUKSDp5mDmGkBPdA1gIHSNDOv6iHJz5f/jc+/1/V2a0Kihp8gdROsGL86IdoAsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6OXFGWc0VCRKhNAmb4jnhKHq/lpzeCWIjOm2NSpxLlc=; b=VcJBTN1bpth96tEpyaR5R4fnCkZiN77CsNVNzycOTTddR+eJKDPzTORiGo8YVPCbNIFQvdyOiCSOFRbsBh5KY8WLs6Pk3mk3euE9XeUkXbx+XhvZP/qRhvRSWoUq8I6CEQ7rP1vIFtvXj4eADsOOEnDgtEL7EaCKLZ4YQpOl5cZhQyzLxyVklmxwxScePJ9BM7Tc1PCwFsI/Hf9+OoH5WcRJ27JMU14goqQUxFsFxUf6bVUvN8G5QcCHz7DJHannI13xAF0eof23xhMZzTkLtuXhG1a1qSekxU+anlClK2oJBh/dHo4SnQ9mSpLxkJJ6AlHHTw6Dp+NGQM8zqIJiZg== Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) by AM9P193MB1489.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:303::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Mon, 7 Mar 2022 00:37:25 +0000 Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::285e:b4b3:5ecf:20e1]) by GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::285e:b4b3:5ecf:20e1%5]) with mapi id 15.20.5038.026; Mon, 7 Mar 2022 00:37:25 +0000 In-reply-to: <87mti2env9.fsf@gnus.org> X-TMN: [GxO6jFfmf6ZXngDAQMCycws00oJe5CIy] X-ClientProxiedBy: AM4PR05CA0004.eurprd05.prod.outlook.com (2603:10a6:205::17) To GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) X-Microsoft-Original-Message-ID: <87k0d67g4u.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8d19853-8421-491b-c5c3-08d9ffd2a639 X-MS-TrafficTypeDiagnostic: AM9P193MB1489:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i4mHmvPTGD8KYKqYLMso2csCKsKv4NsxgOL5LJynaiJ/jco9MJK6dA1qbwo3igKUZpzvsJnp46m6hmX546VaPqA8SwZePO5TDrT8XWBi0q29nbVUnXjUF6WjZ4DcpuE8sS5Fc1Dngc6HWFQkX0KAmM/PSgJlv6PCvfBAvkBIiHE0rLiqJhbvzDJvRdM3c4T4kqQ5TXl1It/ZlkKmQIG6N4+bY2/Nb65bgK7nge+I3MZtzy+A2CDp8Ymu/+Ps0LLpaJxxTdPpUlpx4ZuECAsPbm1C22qFHVKJqU+7UJXOqkeg6Ep2G1I/7UR19ncpnVVH+qvhulZFjx7Y9Z47eYRc9mCJlUrKinKaFYu1ONQVoQa+wQXzeH/fpsU9l1EACkhEVJT8IOtlvIuC3uK7PemYuBBr+oHTYNmgXWcyYdM2Un4PNtjs5gpjcNTSCKQBsA+KHkZCBSohPL+CTRpOy4GnJ0tNDXU9ai5UxOzOAUd5rFm8Wuly5RrVyYnVbShOWdK3kBBvwkp7+zcNkNmZbga1hJ5sfoida1jhRfWzQJL6QX6XVMSlmwm552KkhDR9rnA+y1PPWuX9MYzAXxLtZVKTbA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjRZbjYxais0clpZbTVKRmQzbnpQT0FJMDNxMkN0cUY1TnFkT0dya2EvMWxi?= =?utf-8?B?Y1FqbEZMYlUwTENHaThPWVRKeHpVVXFsSng1aEUwNEIzS0ZhSElFWHZFY1N5?= =?utf-8?B?V1YxUjFqU29jcmFUalhVc3NVVDNsUTI4Q2Q3MU1jVUh5Nk9wajhwZzZXUWZs?= =?utf-8?B?bEtvNy9uQTB5VTJ1eWpxTldQb1FqdFhBOUd0dlBBMDFuNDZ0K3MxNHQyWjVt?= =?utf-8?B?dHNEVGRxcE05SFBTdlphb1EyUGFodmdHczk2WFUwdWE0OVpYS2JTa2ViSlVI?= =?utf-8?B?alJWTnVjRXQvZlR3NVJSUjdzc05VZGpVRS85ZmYvNjZlS1NkcXBRcWlrYkpR?= =?utf-8?B?YW1yZVRMUmNpVm5Jbk5DV2R2QWhwdXlUemxmQ1lPT1U0Tldnc1hxWVRTNE5W?= =?utf-8?B?aXBKVjVpaXdYQXc2STRwZVBMdTBGVENjMXpMOWlNdW1Qei9JdUVQb294ZDVR?= =?utf-8?B?dGlSeXFpd3krUm5TU2dYYlpscmgxcW9jVkJ2SDQwc1R6SUZzdXpGdDlNM1dv?= =?utf-8?B?T2t6RnlBeUkrSS80KzJkT3FoUGt0Y0tsTjg1L09jWXVoeTY1dncwNHk0WnIz?= =?utf-8?B?NU5OdmpzY0Y0V3NkdlZReHpMM0JodHdGMEZGL0FHL0FJb0hjejJINnJzWVYw?= =?utf-8?B?cE9UT3FZSzZvczN0Y1BlNXpJYnFVT1c0OENsUG X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8d19853-8421-491b-c5c3-08d9ffd2a639 X-MS-Exchange-CrossTenant-AuthSource: GV1P193MB2310.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 00:37:25.4934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P193MB1489 Received-SPF: pass client-ip=40.92.73.35; envelope-from=kjartanoli@outlook.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286870 Archived-At: Lars Ingebrigtsen writes: > Kjartan Oli Agustsson writes: > >> @@ -1079,6 +1085,9 @@ doc-view-start-process > > Adding support for CSS makes sense to me. But is this the best place to > add it? It's the general function that's called for all the different > conversions? Probably not, I've looked through doc-view.el again while trying to address your other points, and I'm now fairly certain that a better place would be `doc-view-pdf->png-converter-mupdf', which seems to handle the case for `doc-view-epub-font-size' already. I'll see if I can't handle this there, and submit a new patch once I get that to work. --=20 Kjartan =C3=93li =C3=81g=C3=BAstsson