From: Kjartan Oli Agustsson <kjartanoli@outlook.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Daniel Nicolai <dalanicolai@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support
Date: Mon, 07 Mar 2022 00:17:06 +0000 [thread overview]
Message-ID: <GV1P193MB231053177EAED78773CAF29EDF089@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <87mti2env9.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Kjartan Oli Agustsson <kjartanoli@outlook.com> writes:
>
>> @@ -1079,6 +1085,9 @@ doc-view-start-process
>
> Adding support for CSS makes sense to me. But is this the best place to
> add it? It's the general function that's called for all the different
> conversions?
Probably not, I've looked through doc-view.el again while trying to
address your other points, and I'm now fairly certain that a better
place would be `doc-view-pdf->png-converter-mupdf', which seems to
handle the case for `doc-view-epub-font-size' already.
I'll see if I can't handle this there, and submit a new patch once I get
that to work.
--
Kjartan Óli Ágústsson
next prev parent reply other threads:[~2022-03-07 0:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 17:12 [PATCH] Add user stylesheet support for doc-view EPUB support Kjartan Oli Agustsson
2022-03-06 22:07 ` Lars Ingebrigtsen
2022-03-07 0:17 ` Kjartan Oli Agustsson [this message]
2022-03-07 0:50 ` Kjartan Oli Agustsson
2022-03-07 16:31 ` Lars Ingebrigtsen
2022-03-08 23:06 ` Kjartan Oli Agustsson
2022-03-09 13:59 ` Lars Ingebrigtsen
2022-03-09 22:34 ` Kjartan Oli Agustsson
2022-03-12 16:40 ` Lars Ingebrigtsen
2022-03-14 10:25 ` Kjartan Oli Agustsson
2022-03-14 10:32 ` Lars Ingebrigtsen
2022-03-14 11:17 ` Kjartan Oli Agustsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P193MB231053177EAED78773CAF29EDF089@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM \
--to=kjartanoli@outlook.com \
--cc=dalanicolai@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.