From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kjartan Oli Agustsson Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support Date: Mon, 07 Mar 2022 00:50:18 +0000 Message-ID: References: <87mti2env9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 29.0.50 Cc: Lars Ingebrigtsen , Daniel Nicolai , emacs-devel@gnu.org To: Kjartan Oli Agustsson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 07 01:57:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nR1hC-0007yC-Fo for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 01:57:55 +0100 Original-Received: from localhost ([::1]:50458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nR1hA-00037D-Ud for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Mar 2022 19:57:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR1gK-0002Qt-3h for emacs-devel@gnu.org; Sun, 06 Mar 2022 19:57:00 -0500 Original-Received: from mail-oln040092067099.outbound.protection.outlook.com ([40.92.67.99]:55011 helo=EUR02-AM5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR1gI-0005Lz-0s for emacs-devel@gnu.org; Sun, 06 Mar 2022 19:56:59 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9a82BDayZIEBcoqvEqxCD2mi0PIISLJX29nKIN5LdT7nJHjeiHlPJVC1KvvGAektzwDZxPF0mfV2Ujz5QqY01x1859wVOIOQey1UkL8J2QYDvH/wlkaDFqlziVwPDidYHLcDpniE4rkdIewmaDZq39MuaIVm2eh9ibjRmkfiy8W3S/3ftCDHwZpR1Cbcha1Te3N6KnONfjo+x2ztgnx7avsT0fGP/2bdjGEj2vMn/REPxbZ51yv0b7AQIkOkGggH1UTHsan03IzYwlqOTt9PUXg4x/cKWGkTE9ZAvPKQHWnXpd9AVCbgRYi3twkEKHQS9L+8trkPJ7fuvWHPIZUjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7LUcEfasq7Od3lXB+qTvPORkcDboEVGAawSeVgOHHbQ=; b=E66TKcPxk3jmqT5AUt+0dUsbHUk50gozqri8Tz/RfoWdtmiZRi1KSlL5GG8IOf/vrB8sxMX6Z6B8G/S/+XuO+TEKnJCphww7uGghSElO09Zq7plcEV1SmFwUq/1qlaLTeUun4BNHSXd/BTPvPUYRuN3dUE91+VR/U92flB4hbeitFQf7HMjlNfOqM8o5xJ0BvLfWI5l3GP76iIU21Kyd+G9QC14tKh7wx9O8skin+cOJIMU2WlUj0yCVCzjG848CMhXHMdmBuXMtnxF9EzHO/O26HNLHFcINLHCL/3bNy/vIZEUdfohIdx3yEfPvOxm1AjIxNP2Rx70I9NPb6BcmXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7LUcEfasq7Od3lXB+qTvPORkcDboEVGAawSeVgOHHbQ=; b=JbFDKDqeUIwArXQCjjdquoFc+UxiLUy2l9KYKyCkOtjtW7vHeEQrMOc22aFES1B0KYjwAw3v2xFNXCp1QHNjmVn6ld4B/GalWwOxEVKLFq2jebP9nQFZHlr1IEc6vs/pSfZxLn+9k9LhaLv4X9+/EmX9ZsuvcCOJJMPQBNI19QVG61g1YJi5hgPC9o/XZT6hixr56dbt4uqWZUl7MqBqphfnJdb0ht+wFOA+uo470KbvohrI2f9LpUwTaaXqGapIWS+x4ugtItwXtpz8TekiI5W0QHYdLXeXo6qm6astdqOSQrFDm6lTMH2YiQTYnmjmsWpWuYENyQdnNbXq5LMcUg== Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) by DB6P193MB0038.EURP193.PROD.OUTLOOK.COM (2603:10a6:4:bf::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Mon, 7 Mar 2022 00:56:55 +0000 Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::285e:b4b3:5ecf:20e1]) by GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::285e:b4b3:5ecf:20e1%5]) with mapi id 15.20.5038.026; Mon, 7 Mar 2022 00:56:55 +0000 In-reply-to: X-TMN: [m5Wi+MMQrjeJWdihy74eehwHIVmdxn2k] X-ClientProxiedBy: AM3PR03CA0068.eurprd03.prod.outlook.com (2603:10a6:207:5::26) To GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) X-Microsoft-Original-Message-ID: <87fsnu7f8b.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0635ab6-7d74-40a2-7141-08d9ffd55ff6 X-MS-Exchange-SLBlob-MailProps: 7MJMDUNTCtxKJM15BgE3KgO1A1HYez314Ld54wjONxkAoq5aDACgadHk1hHSZuboCtUFULHZCVYe46/OYlUm9h7KE6zJ4DyzAPV7OTWVZzVBsq7GJHZLlTfHgycfV4HypZ5Tu6J5SA6LNAmOOop8Hc8xXSqE4rWZW7zSHD3VR8sIA9S82izQgPQT3DYeIw1Gfkif8npLH3v7+CA2qye0xdBEQSbyYtLSvqkM4d1nAUz3rPAjNv2WoAPsD331yv4ljModpiz9zy/TrW0xB+x2uOlkfDbx3Q/0AklHw9Za/8hTp7k2Ns4liTg3ooRz1fiP0JeAtVtYTcJVzFL/lujmTk0bksFIqnafEjAqG6+m2jer5c2u/1f44B6lVZqXOgL3JfZd+LK9WV2L9PoYSh2OyJriz/9rV4nWiGVZ8s2nMhma1HBQEZjC0zurCk0rYFgzITOib/PTDIW2trXIvENVaRDxUPA0x3DYcW37yVlmmlQ3+j3kck6KeinLACO87qqsqTNJ+gO8se+yR6vdccalZzufZItPwDV7xatJr+zSrPKxs5kduntc7YcTiFKRwmzGxn5HdrxY/ad5ShUgK7zAGXksSOkFx8ozbEIjAPI8slt8KNQ5HdwBEjI7cg4DnC+FICkJzSONs/23fceaRLybWb19WC24NHL1gKI4rIWo8R7qcVEaWP/LJOZXZFcXg8FfEz6TO7wLdTRat4MN2KNVUIwjHS5rjsW5zBSd2SCidT94VMcBeqJGdQ== X-MS-TrafficTypeDiagnostic: DB6P193MB0038:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J/6lvPVieFkjSSwdmsrDLhdHcg2WFm0dtlJ2+lnt5HLv97Yq/+G04LunTDWobKOIY4thvGnVDwC6QgaWXya6i9TF8xZK02D7M9NhgUnH6UzQP48R4nVOsYxt0hqzcQ6J8g8LBpLaiE8uSFFUM4CIivSX7V+MeSk/DBlbgdCdMJEfgFLj6QBdF0bvv90PiCqUxotoAuZgcGVuPLriD9Bw/LUuozdNOjR8o+ooWkFJNeBN3qOah2jEeP7SqRUiVxBMHNwK3AJxXBT33T8TBRMtvVFSU0Uljne6OAEvZdbJstPOT3JdTbzCJmppWoP6FOQJvNwtt6T1qUuQnrsK+GETyb0ndxcmXn4/+miDA129TgXZzZiAxlBoMY0aNaH+rv88HkzO8dnZ42dZ8n9AiA0+5eVR+2x7Xl89r0qiCWA6RG/uyQZKPVoGmDJ0iEGDVzINO8e1uSKkp7ydwB6Ave12WUAl/9wtgXFcHqV3I3LUjePuJVVTr4kiqCZxUs5yKtKgsO7xptuMrGl55npMGgEXFFLRK9Po6Z0wiSxce2uku5czpSS1EZpAhoH5UFK01nSZO9/dqXBm9A7vez72QC3Osg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6Ld13JJoiCQtkApu0E15qbYFQ5pcVzsQlqTl4E6IHJC6e/5XY9iukvlC59Ks?= =?us-ascii?Q?GBBM4ssS7ite78W3NBLUaVP48bAG1fj8rAH1TBeHuU5ZRafR25U/GTw4CCqg?= =?us-ascii?Q?Zzj8r2JL6nV5/H9bIiH3TUtsJkdETapR00TtcKQtkshyjPQalU/D5433WO2U?= =?us-ascii?Q?PDFmvpZllZ6USET1dQ6FtooThCLc5fSvRcHWjZfanFxc20+3b/W8HOpeNmKc?= =?us-ascii?Q?bdourkj0xa24+F47XYyTowuhOw+3pLshFnaLKactlpPNdjkGwmlCazz+o3iH?= =?us-ascii?Q?dgvccGWRpaULkuWSqBPHH0y0DvpscCmRcfwsZiMP9GEdgPBgiyK+eL4cS97N?= =?us-ascii?Q?HyzP9bEfGKN2HT8fjNsuODNnTep+E1db/8hNfQxMl/m14M1gkHJtKG4BaQV+?= =?us-ascii?Q?BnE0x6f9WB9vzqwjlFSw09g3CwceNamfXl544NaJXJzUH1wtLwnVAgclXLut?= =?us-ascii?Q?Nd5iM98E3Z48Ib9s5lnLdzC1C6RJJXFuKCg4TOc306JsjOAWCfy8mP/FdhsU?= =?us-ascii?Q?Ydv3N8eF2LXy12LtUUH2415spJO7SdJM8RdttPCVxa3LmeN5qfcdd6LgCrl/?= =?us-ascii?Q?TKs3cq+RMftCn9A2FTk6zQG6ICGKezsYl6z4kOz+sDA2hzOOr66WtXGFyB+Q?= =?us-ascii?Q?+S X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0635ab6-7d74-40a2-7141-08d9ffd55ff6 X-MS-Exchange-CrossTenant-AuthSource: GV1P193MB2310.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 00:56:55.5874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P193MB0038 Received-SPF: pass client-ip=40.92.67.99; envelope-from=kjartanoli@outlook.com; helo=EUR02-AM5-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286874 Archived-At: --=-=-= Content-Type: text/plain Kjartan Oli Agustsson writes: > I'll see if I can't handle this there, and submit a new patch once I get > that to work. This should take care of that. But now there's something else I'm wondering about. If I'm understanding `doc-view-custom-set-epub-font-size' correctly, it is used as the setter for `doc-view-epub-font-size' to regenerate epub documents when it is changed. Am I understanding this correctly, and if so would it make sense to do the same for the user stylesheet? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-PATCH-Add-user-stylesheet-option-for-doc-view-EPUB-s.patch Content-Description: Improved patch >From eae132bde6d25a7fa1125bb47c1971c93d4bc300 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kjartan=20=C3=93li=20=C3=81g=C3=BAstsson?= Date: Mon, 7 Mar 2022 00:48:32 +0000 Subject: [PATCH] Add user stylesheet option for doc-view EPUB support * lisp/doc-view.el (doc-view-start-process): Add user stylesheet to process arguments when appropriate. --- lisp/doc-view.el | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 193cf42ea4..1ea3443667 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -226,6 +226,12 @@ doc-view-resolution Higher values result in larger images." :type 'number) +(defcustom doc-view-mutool-user-stylesheet nil + "User stylesheet to use when converting EPUB documents to PDF." + :type '(choice (const nil) + (file :must-match t)) + :version "29.1") + (defvar doc-view-doc-type nil "The type of document in the current buffer. Can be `dvi', `pdf', `ps', `djvu', `odf', 'epub', `cbz', `fb2', @@ -1169,8 +1175,11 @@ doc-view-pdf->png-converter-mupdf (options `(,(concat "-o" png) ,(format "-r%d" (round doc-view-resolution)) ,@(if pdf-passwd `("-p" ,pdf-passwd))))) - (when (and (eq doc-view-doc-type 'epub) doc-view-epub-font-size) - (setq options (append options (list (format "-S%s" doc-view-epub-font-size))))) + (when (eq doc-view-doc-type 'epub) + (when doc-view-epub-font-size + (setq options (append options (list (format "-S%s" doc-view-epub-font-size))))) + (when doc-view-mutool-user-stylesheet + (setq options (append options (list (format "-U%s" (expand-file-name doc-view-mutool-user-stylesheet))))))) (doc-view-start-process "pdf->png" doc-view-pdfdraw-program `(,@(doc-view-pdfdraw-program-subcommand) -- 2.35.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 DQotLSANCktqYXJ0YW4gw5NsaSDDgWfDunN0c3Nvbg0KDQo= --=-=-=--