From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#17222: 24.3; In f90-mode variables declared in continuation lines are not colored. Date: Tue, 17 May 2022 17:20:46 +0200 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9621"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Luca Cartasegna , 17222@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 17 17:28:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqz7m-0002Bb-34 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 May 2022 17:28:38 +0200 Original-Received: from localhost ([::1]:46354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqz7k-0004oZ-UV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 May 2022 11:28:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqz0Q-00031Y-Jd for bug-gnu-emacs@gnu.org; Tue, 17 May 2022 11:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nqz0Q-0000DN-Aa for bug-gnu-emacs@gnu.org; Tue, 17 May 2022 11:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nqz0Q-00080J-5B for bug-gnu-emacs@gnu.org; Tue, 17 May 2022 11:21:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 May 2022 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17222 X-GNU-PR-Package: emacs Original-Received: via spool by 17222-submit@debbugs.gnu.org id=B17222.165280085430728 (code B ref 17222); Tue, 17 May 2022 15:21:02 +0000 Original-Received: (at 17222) by debbugs.gnu.org; 17 May 2022 15:20:54 +0000 Original-Received: from localhost ([127.0.0.1]:57614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqz0I-0007zY-FH for submit@debbugs.gnu.org; Tue, 17 May 2022 11:20:54 -0400 Original-Received: from mail236c50.megamailservers.eu ([91.136.10.246]:34752 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqz0F-0007zO-Ki for 17222@debbugs.gnu.org; Tue, 17 May 2022 11:20:53 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1652800849; bh=pkMSdXyHGOPRx25mo+hEJHW5P1E8FqSGUofyZEZyD2M=; h=From:Subject:Date:Cc:To:From; b=PMTh4lAeZRTJtLUTPZ2QeRS69WbzC7mxN8KHIzEeRuIT/l7Sz6y7o44XWeAgTEm6h FVCAhZaCpTW44sUZhGX2sEqmskxVuVgXCh0xBNMJt7HrOM3X1w5SYNMnSpwirX4gdm J+9pqV3e829U0SSB3pIJPWAJgPYngVEwLUnQ8ots= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24HFKllB001016; Tue, 17 May 2022 15:20:48 +0000 X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F19.6283BD51.002E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232458 Archived-At: > I've now fixed this in Emacs 29:=20 Thank you for doing this. Relint complained about this part: -\\(.*::\\|[ \t]*(.*)\\)?\\([^&!\n]*\\)" - (1 font-lock-type-face t) (4 font-lock-variable-name-face t)) +\\(.*::\\|[ \t]*(.*)\\)?\\(\\(?:[^&!\n]*\\(?:&\n\\)?\\)+\\)" + (1 font-lock-type-face t) (4 font-lock-variable-name-face = append)) More specifically, the \\(?:[^&!\n]*\\(?:&\n\\)?\\)+ part at the end is a potential empty-string repetition that indicates an = ambiguity which we'd like to remove. What is the desired grammar here? Moving to rx for clarity, the above = snippet means (+ (* (not (in "\n!&"))) (? "&\n")) What about rewriting it as (: (* (not (in "\n!&"))) (* "&\n" (* (not (in "\n!&"))))) which should be equivalent but unambiguous? However there may be something more fundamentally wrong with the = original change, because it only seems to work for me after loading a = file, not when writing the code incrementally. More precisely, when I've = typed program main integer :: alpha, && in a new buffer then everything looks correctly coloured, but if I add beta to the next line then it isn't fontified at all. Saving and reloading = the buffer helps. Can you confirm?=