From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Woolley Newsgroups: gmane.emacs.bugs Subject: bug#71646: 29.3; pixel-scroll-precision-mode overrides paging behaviour even when pixel-scroll-precision-interpolate-page is off Date: Sat, 20 Jul 2024 11:10:15 +0100 Message-ID: References: <1EF9E019-2554-402F-8E9F-77AF2D9B4828@bulsara.com> <86iky1icc8.fsf@gnu.org> <86ed8755r4.fsf@gnu.org> <87jzhy3oda.fsf@yahoo.com> <868qxwe6za.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_BD8227A2-138D-47DA-BAF3-7B81D4BE76BF" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27755"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 71646@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 20 12:11:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sV73X-00071U-Aw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jul 2024 12:11:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sV73Q-0000Eh-FI; Sat, 20 Jul 2024 06:11:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV73O-0000EG-Od for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2024 06:11:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sV73O-0006vC-F6 for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2024 06:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sV73O-0003JO-Hn for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2024 06:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Woolley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jul 2024 10:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71646 X-GNU-PR-Package: emacs Original-Received: via spool by 71646-submit@debbugs.gnu.org id=B71646.172147026012717 (code B ref 71646); Sat, 20 Jul 2024 10:11:02 +0000 Original-Received: (at 71646) by debbugs.gnu.org; 20 Jul 2024 10:11:00 +0000 Original-Received: from localhost ([127.0.0.1]:51834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV73L-0003J2-CW for submit@debbugs.gnu.org; Sat, 20 Jul 2024 06:11:00 -0400 Original-Received: from mailout.easymail.ca ([64.68.200.34]:60422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV73I-0003Im-LA for 71646@debbugs.gnu.org; Sat, 20 Jul 2024 06:10:57 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id CF43F61892; Sat, 20 Jul 2024 10:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bulsara.com; s=easymail; t=1721470250; bh=SGIzdp3SvraRiM3h6/O7PDH5x57xF9LRx19JOozXnYI=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=Qt2RHeNprGnfABsMzvf0ViCo4CQUDwCFkRyRbPzp/xvmRc2+cQP3LQbu2wHNrTuRP 3FiAvORVDGUPAjOJ0iyMPe/remTCGjkyx7C88OoE7UlmDqTzDLY5Y/jdRMzUR9dw3J w8XZCfG1vzH8mFZtGiaPEsxw46KvkFPrAU2mh694LIe0blBApwstdq4A3km3p9A3sl gwspJTVqtUfp68CRt/+a9kQD0UZczqMlg0fpgju3aAICz3TLrMFE05EwMERqKnhQSL icjJcduyzjpATy3/vi8sAeZWM5O3znfAivA115fodtmTWi4lXhfis//PFRGabXkovl ILEtn1Jq0hLNw== X-Virus-Scanned: Debian amavisd-new at emo09-pco.easydns.vpn Original-Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo09-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f9apieKvqO1R; Sat, 20 Jul 2024 10:10:50 +0000 (UTC) Original-Received: from smtpclient.apple (soli-07-b2-v4wan-165880-cust2966.vm20.cable.virginm.net [82.33.59.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id D2EBB617D6; Sat, 20 Jul 2024 10:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bulsara.com; s=easymail; t=1721470250; bh=SGIzdp3SvraRiM3h6/O7PDH5x57xF9LRx19JOozXnYI=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=Qt2RHeNprGnfABsMzvf0ViCo4CQUDwCFkRyRbPzp/xvmRc2+cQP3LQbu2wHNrTuRP 3FiAvORVDGUPAjOJ0iyMPe/remTCGjkyx7C88OoE7UlmDqTzDLY5Y/jdRMzUR9dw3J w8XZCfG1vzH8mFZtGiaPEsxw46KvkFPrAU2mh694LIe0blBApwstdq4A3km3p9A3sl gwspJTVqtUfp68CRt/+a9kQD0UZczqMlg0fpgju3aAICz3TLrMFE05EwMERqKnhQSL icjJcduyzjpATy3/vi8sAeZWM5O3znfAivA115fodtmTWi4lXhfis//PFRGabXkovl ILEtn1Jq0hLNw== In-Reply-To: <868qxwe6za.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.600.62) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289033 Archived-At: --Apple-Mail=_BD8227A2-138D-47DA-BAF3-7B81D4BE76BF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Sorry Eli, I had replied, but forgot to CC the list :-) What I was saying was: of course I can remove the bindings from the map = myself (& indeed that=E2=80=99s what I've done), but my point is why = should I have to? Why is a feature that=E2=80=99s turned off still having an effect? I = think this is unnecessary and surprising to users (at least it was to = me)! I was thinking this paging animation feature might be better as it=E2=80=99= s own minor mode, which would do the right thing with keymaps and is how = the other features in the same file are implemented? Thanks, Mike > On 20 Jul 2024, at 10:40, Eli Zaretskii wrote: >=20 > Ping! Mike, can you answer Po Lu's question, please? >=20 >> From: Po Lu >> Cc: mike@bulsara.com, 71646@debbugs.gnu.org >> Date: Sat, 06 Jul 2024 16:40:01 +0800 >>=20 >> Eli Zaretskii writes: >>=20 >>> Ping! >>>=20 >>>> Cc: 71646@debbugs.gnu.org >>>> Date: Sat, 22 Jun 2024 11:57:43 +0300 >>>> From: Eli Zaretskii >>>>=20 >>>>> From: Mike Woolley >>>>> Date: Wed, 19 Jun 2024 11:44:52 +0100 >>>>>=20 >>>>> Playing with `pixel-scroll-precision-mode=E2=80=99 I noticed a = small issue: >>>>>=20 >>>>> Setting `pixel-scroll-precision-interpolate-page=E2=80=99 is = supposed to turn off the paging animation (which it does) >>>>> however even when it=E2=80=99s off, and invoke = `cua-scroll-up=E2=80=99 & `cua-scroll-down=E2=80=99 rather than allowing >>>>> another keymap to handle it. >>>>>=20 >>>>> Unfortunately this means any other mapping for these keys you = might have has now been silently overridden >>>>> (even after you=E2=80=99ve said you don=E2=80=99t want the new = behaviour). >>>>>=20 >>>>> (defun pixel-scroll-interpolate-up () >>>>> "Interpolate a scroll upwards by one page." >>>>> (interactive) >>>>> (if pixel-scroll-precision-interpolate-page >>>>> (pixel-scroll-precision-interpolate (window-text-height nil = t) nil 1) >>>>> (cua-scroll-down))) >>>>>=20 >>>>> I think it would be better if `pixel-scroll-precision-mode=E2=80=99 = did nothing if `pixel-scroll-precision-interpolate-page=E2=80=99 is >>>>> off and allowed another keycap to handle & . >>>>>=20 >>>>> I also noticed that it only maps & and not C-v / = M-v, so in other words behaviour could be >>>>> different depending on exactly which Page Up & Down key sequence = you invoke. >>>>=20 >>>> Po Lu, any comments or suggestions? >>=20 >> Mike, is there any reason in particular you cannot remove the = bindings >> of `prior' and `next' from `pixel-scroll-precision-mode-map'? >>=20 --Apple-Mail=_BD8227A2-138D-47DA-BAF3-7B81D4BE76BF Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Sorry = Eli,

I had replied, but forgot to CC the list = :-)

What I was saying was: of course I can remove the = bindings from the map myself (& indeed that=E2=80=99s what I've = done), but my point is why should I have to?
Why is a feature = that=E2=80=99s turned off still having an effect? I think this is = unnecessary and surprising to users (at least it was to = me)!

I was thinking this paging animation = feature might be better as it=E2=80=99s own minor mode, which would do = the right thing with keymaps and is how the other features in the same = file are implemented?

Thanks,
Mike

On 20 Jul 2024, at 10:40, Eli = Zaretskii <eliz@gnu.org> wrote:

Ping!  Mike, can you = answer Po Lu's question, please?

From: = Po Lu <luangruo@yahoo.com>
Cc: mike@bulsara.com, =  71646@debbugs.gnu.org
Date: Sat, 06 Jul 2024 16:40:01 = +0800

Eli Zaretskii <eliz@gnu.org> = writes:

Ping!

Cc: 71646@debbugs.gnu.org
Date: Sat, 22 Jun 2024 = 11:57:43 +0300
From: Eli Zaretskii = <eliz@gnu.org>

From: Mike Woolley = <mike@bulsara.com>
Date: Wed, 19 Jun 2024 11:44:52 = +0100

Playing with `pixel-scroll-precision-mode=E2=80=99 I = noticed a small issue:

Setting = `pixel-scroll-precision-interpolate-page=E2=80=99 is supposed to turn = off the paging animation (which it does)
however even when it=E2=80=99s= off, <prior> and <next> invoke `cua-scroll-up=E2=80=99 = & `cua-scroll-down=E2=80=99 rather than allowing
another keymap = to handle it.

Unfortunately this means any other mapping for = these keys you might have has now been silently overridden
(even = after you=E2=80=99ve said you don=E2=80=99t want the new = behaviour).

(defun pixel-scroll-interpolate-up ()
=  "Interpolate a scroll upwards by one page."
=  (interactive)
 (if = pixel-scroll-precision-interpolate-page
=      (pixel-scroll-precision-interpolate = (window-text-height nil t) nil 1)
=    (cua-scroll-down)))

I think it would be better = if `pixel-scroll-precision-mode=E2=80=99 did nothing if = `pixel-scroll-precision-interpolate-page=E2=80=99 is
off and allowed = another keycap to handle <prior> & <next>.

I also = noticed that it only maps <prior> & <next> and not C-v / = M-v, so in other words behaviour could be
different depending on = exactly which Page Up & Down key sequence you = invoke.

Po Lu, any comments or = suggestions?

Mike, is there any reason = in particular you cannot remove the bindings
of `prior' and `next' = from = `pixel-scroll-precision-mode-map'?


= --Apple-Mail=_BD8227A2-138D-47DA-BAF3-7B81D4BE76BF--