From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Date: Thu, 28 Dec 2023 00:07:51 -0800 Message-ID: References: <87r0jdddxf.fsf@yandex.ru> <835y0pfkgr.fsf@gnu.org> <1DE32BF7-75D8-4F49-975D-53C782D26016@gmail.com> <08D379EF-1556-4498-8E60-F7972A25752A@gmail.com> <83edfccbwi.fsf@gnu.org> <262157E9-A92C-4063-ADA4-725C156FB227@gmail.com> <83r0j79522.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13450"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Denis Zubarev , 67977@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 28 09:09:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIlSF-0003IU-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Dec 2023 09:09:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIlRx-0004p9-Tt; Thu, 28 Dec 2023 03:09:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIlRv-0004oh-IX for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 03:09:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rIlRv-0002SF-Ad for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 03:09:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rIlRu-0004X2-Cf for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 03:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Dec 2023 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67977 X-GNU-PR-Package: emacs Original-Received: via spool by 67977-submit@debbugs.gnu.org id=B67977.170375089017358 (code B ref 67977); Thu, 28 Dec 2023 08:09:02 +0000 Original-Received: (at 67977) by debbugs.gnu.org; 28 Dec 2023 08:08:10 +0000 Original-Received: from localhost ([127.0.0.1]:38374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIlR4-0004Vt-0K for submit@debbugs.gnu.org; Thu, 28 Dec 2023 03:08:10 -0500 Original-Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:53453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIlR2-0004Ve-AB for 67977@debbugs.gnu.org; Thu, 28 Dec 2023 03:08:08 -0500 Original-Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6d9bf6f24f3so927417b3a.2 for <67977@debbugs.gnu.org>; Thu, 28 Dec 2023 00:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703750883; x=1704355683; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MbgTCYYNBGi4f12t5K9Dv/qNVHGUCl4RHtAZfUXxUME=; b=d7lblThSA1mC3fhVkQqjsVfV4FcJCM3xgDNc3Jkq+b5c7d893l5Cr9D+68lDEBenaY c/AkSNM1ZiBpWwzQSs+WkdHyqNhGf/sHfdlSJdYIc57li580DxXH7dsFU1yt/EzvU6Fw vjM3wVgMzSCXiSFv9GKK/TdcXfVtvwTN4Gs5e/WwVmV7tHa32j9MZ+OAB1QNMy1Jwo5Z sluQnKOEG91nw+sakv71nexhR/b43nppP9kdEYplGdM/hCUz8HfDL8adkGBsyGC2N5fZ 5umVy/Y2g0zL087NN2vIzJd31hn92CCvAHhV5AnmRs9Cr7Q8P2KAOIDzxaTmvkMZebuT y/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703750883; x=1704355683; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MbgTCYYNBGi4f12t5K9Dv/qNVHGUCl4RHtAZfUXxUME=; b=fTSLQeSZYkL2kJBM3F/ZvP5c7JZ75LmOzGJ9niMtZhAIx2pgGEwaY1gwzXcrCdTmbY w2ldh8tneo/fjH4u84DVA5ftPuxI6QjvPGBkmGE3rd6c4GZNfuZJBmID+dufs2yNRUF5 3zOvafMjR0hyHjnDOipn5u0doJBjAUpzojTW2quhieLujWh91KpCeHK4lDHpSckkv0My UPjC+0Bck8FwokZ3DnYO4loLQEGWtTnva8dwmspdsH/uftvw9O2mCmnU2yYxEHUJKDUf LT9GW3v0IQitYtGJatpgCB/pOwHSRIsNs/LnastdBqP4uicQ8WoAh3nnetBkPoFh375E jIfg== X-Gm-Message-State: AOJu0YzUr3ea8x0Pi4LiUF6MQC6mylAHBdUUBFhU3khTYjsEyhYa4vNZ kxJJDGKEGClr5wsQl2rP0gY= X-Google-Smtp-Source: AGHT+IHQqNjjta3vYJnKAn7nzMuajdWQp+oa50tZonoh6HWPdX4KEiX4RTK1d33jymJW/DhpmWJzSA== X-Received: by 2002:a62:8441:0:b0:6d9:3f75:51d5 with SMTP id k62-20020a628441000000b006d93f7551d5mr3999732pfd.46.1703750883238; Thu, 28 Dec 2023 00:08:03 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id v21-20020a056a00149500b006d9cf4b56edsm5249549pfu.175.2023.12.28.00.08.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Dec 2023 00:08:02 -0800 (PST) In-Reply-To: <83r0j79522.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276962 Archived-At: > On Dec 27, 2023, at 4:57 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Tue, 26 Dec 2023 20:15:24 -0800 >> Cc: Denis Zubarev , >> 67977@debbugs.gnu.org >>=20 >>> Btw, I hope that these calls to 'widen' don't require unnecessary >>> reparsing by tree-sitter, do they? >>=20 >> Yes, but only because we called treesit-node-at while the buffer is = narrowed, which triggers a reparse. Font-lock and jit-lock themselves = always access the parser with widened buffer so they don=E2=80=99t = trigger reparse on their own.=20 >>=20 >> So it seems working in a narrowed buffer would trigger a lot of = back-and-fortch reparse. I wonder if it=E2=80=99s worth optimizing for = (eg, use two parsers behind the scenes, one for widened buffer and one = for narrowed buffer). >=20 > Could font-lock-dont-widen help, perhaps? Yes. If font-lock doesn=E2=80=99t widen, then there wouldn=E2=80=99t be = back-and-forth reparses.=20 Yuan=