* info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu
@ 2010-01-10 20:15 Geek4AllSeasons
2010-01-10 21:38 ` Peter Dyballa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geek4AllSeasons @ 2010-01-10 20:15 UTC (permalink / raw
To: Help-gnu-emacs
A problem creating the toplevel dir menu (C-h i) was corrected with changes
below. Comments/suggestions would be appreciated on:
1. appropriate list/forum
2. change correctness
3. issues (regarding 2.)
After upgrading to EmacsW32+Emacs20091103 (patched) the toplevel dir menu
went missing. "Can't find dir or any compressed version of it" appears in
*messages*/*backtrace*.
After some Edebug hacking I found a mismatch in the "filename" parameter
being passed down from:
[info](Info-directory)->
[info](Info-find-node "dir" "top")->
[info+](Info-find-node-2 "dir" "top" )
The Dir menu was created after the following change was made in in
[info+]Info-find-node-2:
--- /cygdrive/d/Download/Emacs/info+.el 2010-01-10 18:09:46.262804400 +0000
+++ /cygdrive/c/Software/Emacs/site-lisp/auto-install/info+.el 2010-01-10
18:20:21.967298700 +0000
@@ -1463,8 +1463,9 @@
buffer-file-name nil)
(erase-buffer)
(cond
- ((eq filename t)
- (Info-insert-dir))
+ ((or (eq filename t)
+ (equal filename "dir"))
+ (Info-insert-dir))
((eq filename 'apropos)
(insert-buffer-substring " *info-apropos*"))
((eq filename 'history)
The fix was made in info+.el to localize side effects and due to limited
knowledge of dependencies/design intent. The underlying problem maybe in the
"virtual" info logic. There may be a shortcircut between filename and
nodename semantics. Info-find-node calls Info-find-file. The first and only
case executed there is:
(Info-virtual-call (Info-virtual-fun 'find-file "dir" nil) "dir" noerror))
The problem is/was caused by 'find-file mapping to Info-directory-find-file,
which just returns the unchanged filename. 'find-node would map to
Info-directory-find-node, which calls Info-insert-dir (see above).
--
View this message in context: http://old.nabble.com/info-info%2B-%2823.1.50-EmacsW32%29---Error-creating-toplevel-dir-menu-tp27101958p27101958.html
Sent from the Emacs - Help mailing list archive at Nabble.com.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu
2010-01-10 20:15 info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu Geek4AllSeasons
@ 2010-01-10 21:38 ` Peter Dyballa
2010-01-10 21:46 ` Lennart Borgman
2010-01-11 0:15 ` Drew Adams
2 siblings, 0 replies; 4+ messages in thread
From: Peter Dyballa @ 2010-01-10 21:38 UTC (permalink / raw
To: Geek4AllSeasons; +Cc: Help-gnu-emacs
Am 10.01.2010 um 21:15 schrieb Geek4AllSeasons:
> 1. appropriate list/forum
Either emacs-pretest-bug@gnu.org as if bug reporting (with adequate
23.1.50 subject) or emacs-devel@gnu.org.
--
Greetings
Pete
I hope to die before I *have* to use Microsoft Word.
- Donald E. Knuth, 2001-10-02 in Tübingen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu
2010-01-10 20:15 info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu Geek4AllSeasons
2010-01-10 21:38 ` Peter Dyballa
@ 2010-01-10 21:46 ` Lennart Borgman
2010-01-11 0:15 ` Drew Adams
2 siblings, 0 replies; 4+ messages in thread
From: Lennart Borgman @ 2010-01-10 21:46 UTC (permalink / raw
To: Geek4AllSeasons; +Cc: Help-gnu-emacs
On Sun, Jan 10, 2010 at 9:15 PM, Geek4AllSeasons
<Geek4AllSeasons@hotmail.com> wrote:
>
> A problem creating the toplevel dir menu (C-h i) was corrected with changes
> below. Comments/suggestions would be appreciated on:
>
> 1. appropriate list/forum
Is the problem perhaps in info+.el? In that case try to contact the
author of that package.
The problem is perhaps not there, but that will be a good starting point.
> 2. change correctness
> 3. issues (regarding 2.)
>
> After upgrading to EmacsW32+Emacs20091103 (patched) the toplevel dir menu
> went missing. "Can't find dir or any compressed version of it" appears in
> *messages*/*backtrace*.
>
> After some Edebug hacking I found a mismatch in the "filename" parameter
> being passed down from:
> [info](Info-directory)->
> [info](Info-find-node "dir" "top")->
> [info+](Info-find-node-2 "dir" "top" )
>
> The Dir menu was created after the following change was made in in
> [info+]Info-find-node-2:
>
> --- /cygdrive/d/Download/Emacs/info+.el 2010-01-10 18:09:46.262804400 +0000
> +++ /cygdrive/c/Software/Emacs/site-lisp/auto-install/info+.el 2010-01-10
> 18:20:21.967298700 +0000
> @@ -1463,8 +1463,9 @@
> buffer-file-name nil)
> (erase-buffer)
> (cond
> - ((eq filename t)
> - (Info-insert-dir))
> + ((or (eq filename t)
> + (equal filename "dir"))
> + (Info-insert-dir))
> ((eq filename 'apropos)
> (insert-buffer-substring " *info-apropos*"))
> ((eq filename 'history)
>
> The fix was made in info+.el to localize side effects and due to limited
> knowledge of dependencies/design intent. The underlying problem maybe in the
> "virtual" info logic. There may be a shortcircut between filename and
> nodename semantics. Info-find-node calls Info-find-file. The first and only
> case executed there is:
>
> (Info-virtual-call (Info-virtual-fun 'find-file "dir" nil) "dir" noerror))
>
> The problem is/was caused by 'find-file mapping to Info-directory-find-file,
> which just returns the unchanged filename. 'find-node would map to
> Info-directory-find-node, which calls Info-insert-dir (see above).
>
> --
> View this message in context: http://old.nabble.com/info-info%2B-%2823.1.50-EmacsW32%29---Error-creating-toplevel-dir-menu-tp27101958p27101958.html
> Sent from the Emacs - Help mailing list archive at Nabble.com.
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu
2010-01-10 20:15 info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu Geek4AllSeasons
2010-01-10 21:38 ` Peter Dyballa
2010-01-10 21:46 ` Lennart Borgman
@ 2010-01-11 0:15 ` Drew Adams
2 siblings, 0 replies; 4+ messages in thread
From: Drew Adams @ 2010-01-11 0:15 UTC (permalink / raw
To: 'Geek4AllSeasons', Help-gnu-emacs
> A problem creating the toplevel dir menu (C-h i)...
> Comments/suggestions would be appreciated on
> appropriate list/forum
This forum is OK, but it is best to send bug reports for info+.el to me directly
(email). info+.el is not part of vanilla Emacs.
If you use `M-x customize-group Info-Plus', you'll see a link named `Send Bug
Report'. Clicking that link will start an email to me for your bug report.
> After upgrading to EmacsW32+Emacs20091103 (patched) the
> toplevel dir menu went missing. "Can't find dir or any
> compressed version of it" appears in *messages*/*backtrace*.
Thanks for your feedback.
You are using a development version of Emacs (EmacsW32+Emacs20091103). info+.el
has supported Emacs 23 since its release (23.1), but it has not supported
development versions (aka "CVS Emacs").
Now that the pretest is out, I've just updated info+.el to accommodate the
development changes since Emacs 23.1. Please try the latest version. It should
correctly support all releases starting with Emacs 20, as well as the current
Emacs 23.2 pretest.
http://www.emacswiki.org/emacs/info%2b.el
Thx - Drew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-11 0:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-10 20:15 info/info+ (23.1.50/EmacsW32) - Error creating toplevel dir menu Geek4AllSeasons
2010-01-10 21:38 ` Peter Dyballa
2010-01-10 21:46 ` Lennart Borgman
2010-01-11 0:15 ` Drew Adams
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.