From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ian Eure Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1904: 23.0.60; [PATCH] sql-sqlite doesn't work Date: Wed, 14 Jan 2009 10:57:49 -0800 Message-ID: Reply-To: Ian Eure , 1904@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=WINDOWS-1252; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1231961038 2846 80.91.229.12 (14 Jan 2009 19:23:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Jan 2009 19:23:58 +0000 (UTC) To: emacs-pretest-bug@gnu.org, alex@gnu.org, mmaug@yahoo.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 14 20:25:09 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LNBMT-0006sO-F3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jan 2009 20:25:09 +0100 Original-Received: from localhost ([127.0.0.1]:34066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNBLC-0000Tj-Md for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jan 2009 14:23:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNBKu-00009g-1b for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 14:23:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNBKs-00007n-Oe for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 14:23:31 -0500 Original-Received: from [199.232.76.173] (port=41750 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNBKs-00007R-Ge for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 14:23:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56948) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNBKr-00044b-Iy for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 14:23:30 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EJNQ2u002887; Wed, 14 Jan 2009 11:23:26 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0EJ54Qb030654; Wed, 14 Jan 2009 11:05:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Ian Eure Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 14 Jan 2009 19:05:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 1904 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123195947928604 (code B ref -1); Wed, 14 Jan 2009 19:05:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jan 2009 18:57:59 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EIvtam028598 for ; Wed, 14 Jan 2009 10:57:56 -0800 Original-Received: from mail.gnu.org ([199.232.76.166]:47116 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LNAun-0005WG-IV; Wed, 14 Jan 2009 13:56:33 -0500 Original-Received: from mail.digg.com ([64.191.203.36]:33600) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNAw6-0005f1-4L; Wed, 14 Jan 2009 13:57:54 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 6002CA8507F; Wed, 14 Jan 2009 10:57:50 -0800 (PST) X-Virus-Scanned: amavisd-new at Original-Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qnInprv-PZO6; Wed, 14 Jan 2009 10:57:49 -0800 (PST) Original-Received: from [10.2.16.90] (diggstage01.digg.com [64.191.203.34]) by mail.digg.com (Postfix) with ESMTP id C3178A84FE4; Wed, 14 Jan 2009 10:57:49 -0800 (PST) X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 14 Jan 2009 14:23:31 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24113 gmane.emacs.pretest.bugs:23693 Archived-At: The (sql-sqlite) function prompts for username, password, and server =20 even though these don=92t apply to SQLite. Further, it adds options for =20= them (--host, --user, --password) to the arguments of sql-sqlite-=20 program. The SQLite CLI doesn=92t understand or support these, and =20 returns this error if they=92re provided: sqlite3: unknown option: -user=3Dieure (The sqlite 2.8.x binary behaves in the same way.) For these reasons, I=92ve taken the following measures: 1. Removed 'user, 'password and 'server from :sqli-login for sqlite =20= in sql-product-alist; this prevents them from being read from the user =20= when (sql-sqlite) is invoked. 2. Removed the addition of the --host, --user, and --password =20 arguments to 'params in (sql-connect-sqlite). Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows. --- sql.el.~1.61.~ 2009-01-14 10:44:58.000000000 -0800 +++ sql.el 2009-01-14 10:50:09.000000000 -0800 @@ -356,7 +356,7 @@ :sqli-prompt-length 0) (sqlite :font-lock sql-mode-sqlite-font-lock-keywords - :sqli-login (user password server database) + :sqli-login (database) :sqli-connect sql-connect-sqlite :sqli-prompt-regexp "^sqlite> " :sqli-prompt-length 8) @@ -2611,12 +2611,6 @@ (let ((params)) (if (not (string=3D "" sql-database)) (setq params (append (list sql-database) params))) - (if (not (string=3D "" sql-server)) - (setq params (append (list (concat "--host=3D" sql-server)) = params))) - (if (not (string=3D "" sql-password)) - (setq params (append (list (concat "--password=3D" = sql-password)) =20 params))) - (if (not (string=3D "" sql-user)) - (setq params (append (list (concat "--user=3D" sql-user)) = params))) (if (not (null sql-sqlite-options)) (setq params (append sql-sqlite-options params))) (set-buffer (apply 'make-comint "SQL" sql-sqlite-program In GNU Emacs 23.0.60.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-01-14 on neutron.local Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Diff Minor modes in effect: diff-auto-refine-mode: t erc-track-mode: t erc-track-minor-mode: t erc-spelling-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-netsplit-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-autojoin-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t which-function-mode: t twit-mode: t yas/minor-mode: t ime-bindings: t shell-dirtrack-mode: t show-paren-mode: t recentf-mode: t iswitchb-mode: t auto-insert-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-x k RET C-x b s h e l M-> c d SPC ~ / P r e m c v s SPC u p SPC - A C-x 1 C-p C-p C-p C-p C-p C-p C-p C-p C-SPC M-b M-b M-b M-b M-b M-b M-w M-> r m SPC C-y c v s SPC u p SPC C-y s v n SPC x c s a SPC a r c v s SPC u p C-p C-x b s q l C-g C-x b s q l . e l C-x k RET C-x b s q l . e l C-x k RET M-> C-p C-p M-- M-z SPC M-> r m SPC C-y c v s SPC u p SPC C-y C-p C-p C-p C-e C-c C-x C-f RET C-x v =3D C-s s q l - c o n n e c t - s q l i t e C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-h v p r o g m C-g C-n C-p C-p C-p C-a C-n M-m C-SPC C-n C-n C-n C-n C-n C-n C-p C-e C-w C-d C-h v w r i e e v f b e f o - w s a M-: M-( s e q SPC t q SPC b e f M-/ - M-/ SPC n i l C-e C-x C-s C-x v =3D M-> M-< C-x C-w C-g C-SPC M-> M-w Recent messages: Making completion list... [2 times] Type C-x 1 to delete the help window, C-M-v to scroll help. Scanning for dabbrevs...100% [2 times] nil Saving file /Users/ieure/Projects/emacs/lisp/progmodes/sql.el... Wrote /Users/ieure/Projects/emacs/lisp/progmodes/sql.el Finding changes in /Users/ieure/Projects/emacs/lisp/progmodes/=20 sql.el...done Mark set [2 times] Quit Mark set=