From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Samuel Bronson Newsgroups: gmane.emacs.devel Subject: gl_MANYWARN_ALL_GCC() leads to many spurious warnings Date: Fri, 6 Jul 2012 17:17:12 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341609448 2271 80.91.229.3 (6 Jul 2012 21:17:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2012 21:17:28 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 06 23:17:28 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SnFu1-0003AP-7X for ged-emacs-devel@m.gmane.org; Fri, 06 Jul 2012 23:17:25 +0200 Original-Received: from localhost ([::1]:56763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnFu0-00027m-7A for ged-emacs-devel@m.gmane.org; Fri, 06 Jul 2012 17:17:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnFtx-00026J-Dz for emacs-devel@gnu.org; Fri, 06 Jul 2012 17:17:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SnFtv-0003pU-Lq for emacs-devel@gnu.org; Fri, 06 Jul 2012 17:17:21 -0400 Original-Received: from mail-qc0-f169.google.com ([209.85.216.169]:38116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnFtv-0003oU-FS for emacs-devel@gnu.org; Fri, 06 Jul 2012 17:17:19 -0400 Original-Received: by qcsd16 with SMTP id d16so6345558qcs.0 for ; Fri, 06 Jul 2012 14:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; bh=LeUt6TTe2vAUtno8YdJ0kCnMCcjE53VP8NscqlDGc+0=; b=mlBEASlxqtc2EAjCQ8C6NvWrEG3iJ6qihL5MNUKUS9/RfoGIB5hWnTAJA5JbH8bx/u XYcWmjrDP6SO2YqG87Rp1rwoSpFWOtt06D5B/qNjmrGnV8jzN7tHQ7vOD8jbueVL/s28 Mf7o8sRc20q07sM3gkAM83K07R0yRUXYdvjItZumoLr+pIW621uPy06zuwlxOQa0eyA3 YJKOBzTqkKv+sFtofP8qn2hk45mufyYWnH5F6aA1rJxR00yDKMYSLVlXlJ1TTPqsnnpw d/mrkq5PE8e3WwsmjuVvPh6g7iUBx95nJXrzCPsW2hT9W8zuPZL7WVUlm44xrbEekDQ5 Vq+w== Original-Received: by 10.229.136.81 with SMTP id q17mr16502236qct.115.1341609437405; Fri, 06 Jul 2012 14:17:17 -0700 (PDT) Original-Received: from [192.168.0.18] (207-172-123-137.c3-0.upd-ubr1.trpr-upd.pa.cable.rcn.com. [207.172.123.137]) by mx.google.com with ESMTPS id gb7sm51695822qab.12.2012.07.06.14.17.15 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Jul 2012 14:17:16 -0700 (PDT) X-Mailer: Apple Mail (2.936) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151470 Archived-At: It seems that gl_MANYWARN_ALL_GCC is intended to enable (virtually) all warnings implemented by GCC, no matter how noisy or badly tested they are in whatever GCC version is in use. The result is that, even after we explicitly disable dozens of them again, we still generally get a lot of spurious warnings when building with --enable-gcc-warnings. Furthermore, since that option also enables -Werror, Emacs generally does not build at all in this configuration (unless you monkey around with WERROR_CFLAGS). Why not simply use "-W -Wall -Wextra" and perhaps a few others, plus a few overrides to turn off the warnings those enable that aren't useful with Emacs? That way, we'd only get warnings that had been reasonably well tested.