From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 29 Apr 2019 21:21:12 +0200 Message-ID: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173594"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Albinus , 35418@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 21:22:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLBqv-000iv8-Nk for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 21:22:14 +0200 Original-Received: from localhost ([127.0.0.1]:34104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLBqu-0007ZY-Od for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 15:22:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLBql-0007ZP-Rv for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 15:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLBqk-00047J-QQ for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 15:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54456) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLBqk-00047B-Jg for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 15:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLBqk-0005bb-Ew for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 15:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656567921497 (code B ref 35418); Mon, 29 Apr 2019 19:22:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 19:21:19 +0000 Original-Received: from localhost ([127.0.0.1]:39767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBq3-0005af-2y for submit@debbugs.gnu.org; Mon, 29 Apr 2019 15:21:19 -0400 Original-Received: from mail235c50.megamailservers.eu ([91.136.10.245]:43286 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBq0-0005aP-4Y for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 15:21:17 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556565674; bh=p3hao59QkbD1MFqABtQz1hBhA0m5psWqZ4TPpK0D1lM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gxMdSzZZ+ykWKUxbD09UIatcI25pbo3RlSneeUlTGzkRN/TMyA3tD8OlohlFtMvM7 JhJK7JNfz/pTdYPODhe4sYP/ZQPFyl2/tRdUW6XSzxQhXhRnPH7bks8ZFDKjEbICkb rhLhCQURS2kCg+Vt6St5ywRYZi/xJWugcesmEEL4= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TJLC0u004051; Mon, 29 Apr 2019 19:21:14 +0000 In-Reply-To: <834l6gu6ee.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0210.5CC74EAA.004E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Bbz2LIl2 c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=3EcVNkd7z6PwEcaOn2kA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158444 Archived-At: 29 apr. 2019 kl. 18.23 skrev Eli Zaretskii : >=20 >> There is a section called Reverting, which starts about = `revert-buffer' but then goes on to talk about the auto-revert, = global-auto-revert and auto-revert-tail modes and details about the = mechanisms behind them: polling, intervals, notification. >>=20 >> Then there is a (sibling) section called Autorevert, which despite = its name only talks about auto-reverting non-file buffers. >=20 > You say "section" but the names you cite are node names, not section > names. The latter are slightly more descriptive. Correct, thank you. (The node names attract the eyes since they are = highlighted as links.) >> This can be reorganised in various ways. We could move all autorevert = text to a sibling node to Reverting, or to one or more child nodes. In = any case, such text shuffling should not be part of this patch. >=20 > I think we should have sibling sections "Reverting" and "Autorevert", > with the latter describing both types of auto-reverting. And > "Reverting" should have a cross-reference to "Autorevert" for > automatic reverting of file-visiting buffers. >=20 > Would you like to submit a patch to that effect? I'll see what I can do, once we are done with this particular patch. >>> Saying this, the user option might need another name. What about >>> `auto-revert-also-poll'? >>=20 >> Naming is always hard. I started with `auto-revert-avoid-polling' but = wanted to avoid a negative name. >> I tried `auto-revert-also-poll' but it somehow didn't feel right; not = all buffers use notification. >> It is nothing I feel strongly about, so if you do prefer that name = I'll change, but I've kept the original name in the patch for now. >=20 > I actually think auto-revert-dont-poll is better, even though it's > negative. Then I'd prefer auto-revert-avoid-polling; 'don't poll' sounds = definitive but we may still have to poll from time to time.