23.0.50; (set-language-environment 'Chinese-GB) error

23.0.50; (set-language-environment 'Chinese-GB) error

[Jie Yu]

[-- Attachment #1.1: Type: text/plain, Size: 2111 bytes --]

 

Please write in English if possible, because the Emacs maintainers

usually do not have translators to read other languages for them.

 

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing
list.

 

Please describe exactly what actions triggered the bug

and the precise symptoms of the bug:

 

 

 

If Emacs crashed, and you have the Emacs process in the gdb debugger,

please include the output from the following gdb commands:

    `bt full' and `xbacktrace'.

If you would like to further debug the crash, please read the file

d:/emacs22/etc/DEBUG for instructions.

 

 

In GNU Emacs 23.0.50.1 (i386-mingw-nt5.1.2600)

 of 2007-10-12 on KEVIN-DESKTOP

Windowing system distributor `Microsoft Corp.', version 5.1.2600

configured using `configure --with-gcc (3.4)'

 

Important settings:

  value of $LC_ALL: nil

  value of $LC_COLLATE: nil

  value of $LC_CTYPE: nil

  value of $LC_MESSAGES: nil

  value of $LC_MONETARY: nil

  value of $LC_NUMERIC: nil

  value of $LC_TIME: nil

  value of $LANG: ENU

  locale-coding-system: cp936

  default-enable-multibyte-characters: t

 

Major mode: Lisp Interaction

 

Minor modes in effect:

  show-paren-mode: t

  tooltip-mode: t

  mouse-wheel-mode: t

  file-name-shadow-mode: t

  global-font-lock-mode: t

  font-lock-mode: t

  blink-cursor-mode: t

  unify-8859-on-encoding-mode: t

  utf-translate-cjk-mode: t

  auto-compression-mode: t

  line-number-mode: t

 

Recent input:

M-x b u g SPC <backspace> SPC <backspace> <backspace> 

e m a SPC SPC b u SPC <backspace> <backspace> <backspace> 

<backspace> <backspace> <backspace> <backspace> <backspace> 

r e p o SPC r SPC SPC SPC <return>

 

Recent messages:

Loading d:/emacs22/site-lisp/color-theme/themes/color-theme-example.el
(source)...done

Loading d:/emacs22/site-lisp/color-theme/themes/color-theme-library.el
(source)...done

For information about GNU Emacs and the GNU system, type C-h C-a.

Making completion list... [3 times]


[-- Attachment #1.2: Type: text/html, Size: 11817 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

23.0.50;(set-language-environment 'Chinese-GB) error

[Jie Yu]

[-- Attachment #1.1: Type: text/plain, Size: 2547 bytes --]

(set-language-environment 'Chinese-GB) will result in
wrong-type-argument error.

 

 

From:  <Kevin@KEVIN-DESKTOP>

To: emacs-pretest-bug@gnu.org

Subject: 23.0.50; 

--text follows this line--

 

Please write in English if possible, because the Emacs maintainers

usually do not have translators to read other languages for them.

 

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing
list.

 

Please describe exactly what actions triggered the bug

and the precise symptoms of the bug:

 

 

 

If Emacs crashed, and you have the Emacs process in the gdb debugger,

please include the output from the following gdb commands:

    `bt full' and `xbacktrace'.

If you would like to further debug the crash, please read the file

d:/emacs22/etc/DEBUG for instructions.

 

 

In GNU Emacs 23.0.50.1 (i386-mingw-nt5.1.2600)

 of 2007-10-15 on KEVIN-DESKTOP

Windowing system distributor `Microsoft Corp.', version 5.1.2600

configured using `configure --with-gcc (3.4)'

 

Important settings:

  value of $LC_ALL: nil

  value of $LC_COLLATE: nil

  value of $LC_CTYPE: nil

  value of $LC_MESSAGES: nil

  value of $LC_MONETARY: nil

  value of $LC_NUMERIC: nil

  value of $LC_TIME: nil

  value of $LANG: ENU

  locale-coding-system: cp936

  default-enable-multibyte-characters: t

 

Major mode: Debugger

 

Minor modes in effect:

  tooltip-mode: t

  tool-bar-mode: t

  mouse-wheel-mode: t

  menu-bar-mode: t

  file-name-shadow-mode: t

  global-font-lock-mode: t

  font-lock-mode: t

  blink-cursor-mode: t

  unify-8859-on-encoding-mode: t

  utf-translate-cjk-mode: t

  auto-compression-mode: t

  line-number-mode: t

 

Recent input:

<down-mouse-1> <mouse-1> C-x C-f ~ / _ e m a <tab> 

<return> <end> C-x C-e <help-echo> <down-mouse-1> <mouse-movement> 

<mouse-movement> <drag-mouse-1> M-w <help-echo> <down-mouse-1> 

<mouse-1> <down-mouse-1> <mouse-movement> <mouse-movement> 

<drag-mouse-1> M-w <help-echo> <down-mouse-1> <mouse-1> 

M-x r e p o r SPC e SPC b u SPC <return>

 

Recent messages:

 

To ensure normal operation, you should investigate and remove the

cause of the error in your initialization file.  Start Emacs with

the `--debug-init' option to view a complete error backtrace.

 

For information about GNU Emacs and the GNU system, type C-h C-a.

mouse-posn-property: Args out of range: 119825, 119825

Entering debugger...


[-- Attachment #1.2: Type: text/html, Size: 14189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Kenichi Handa]

In article <FEF1C9F2C721084190816C98BB6A88910123C41E@ex1.logwinxp.resilience.com>, "Jie Yu" <Jie.Yu@resilience.com> writes:

> (set-language-environment 'Chinese-GB) will result in
> wrong-type-argument error.

I confirmed this problem.  The above error happensq while
loading lisp/language/china-util.elc.  When I byte-compile
it manually, this warning is reported.

china-util.el:425:1:Warning: the following functions might not be defined at runtime:
    big5-to-flat-code, euc-to-flat-code, flat-code-to-big5,
    flat-code-to-euc

But, I can load china-util.el without any problem.  As
china-util.el has not been modified for long, I think the
problem is in byte-compiler.

FYI, when I try "make bootstrap", this error happens:

	Recursive `require' for feature `help-fns'

---
Kenichi Handa
handa@m17n.org

PS. Full output of make bootstrap:

% make bootstrap
(cd src;      make  mostlyclean)
make[1]: Entering directory `/usr/local/work/emacs/src'
rm -f temacs prefix-args core *.core \#* *.o libXMenu11.a liblw.a
rm -f ../etc/DOC
rm -f bootstrap-emacs emacs-23.0.50
rm -f buildobj.lst
make[1]: Leaving directory `/usr/local/work/emacs/src'
(cd oldXMenu; make  clean)
make[1]: Entering directory `/usr/local/work/emacs/oldXMenu'
rm -f libXMenu11.a Activate.o AddPane.o AddSel.o ChgPane.o ChgSel.o Create.o DelPane.o DelSel.o Destroy.o Error.o EvHand.o FindPane.o FindSel.o InsPane.o InsSel.o Internal.o Locate.o Post.o Recomp.o SetAEQ.o SetFrz.o SetPane.o SetSel.o XDelAssoc.o XLookAssoc.o XCrAssoc.o XDestAssoc.o XMakeAssoc.o insque.o
make[1]: Leaving directory `/usr/local/work/emacs/oldXMenu'
(cd lwlib;    make  clean)
make[1]: Entering directory `/usr/local/work/emacs/lwlib'
rm -f *.o core errs ,* *.a .emacs_* make.log MakeOut \#*
make[1]: Leaving directory `/usr/local/work/emacs/lwlib'
(cd lib-src;  make  clean)
make[1]: Entering directory `/usr/local/work/emacs/lib-src'
rm -f core *.o getopt.h getopt.h-t
rm -f etags ctags emacsclient b2m ebrowse profile digest-doc sorted-doc movemail cvtmail fakemail hexl update-game-score test-distrib make-docfile
rm -f fns*.el *.tab.c *.tab.h
make[1]: Leaving directory `/usr/local/work/emacs/lib-src'
(cd doc/emacs &&   make  clean)
make[1]: Entering directory `/usr/local/work/emacs/doc/emacs'
rm -f *.log *.cp *.fn *.ky *.op *.ops *.pg *.vr core *.tp *.core
rm -f *.aux *.cps *.fns *.kys *.pgs *.vrs *.toc
rm -f *.dvi
make[1]: Leaving directory `/usr/local/work/emacs/doc/emacs'
(cd doc/misc &&   make  clean)
make[1]: Entering directory `/usr/local/work/emacs/doc/misc'
rm -f *.log *.cp *.fn *.ky *.op *.ops *.pg *.vr core *.tp \
	*.tps *.core gnustmp.*
rm -f *.aux *.cps *.fns *.kys *.pgs *.vrs *.toc
rm -f *.dvi
make[1]: Leaving directory `/usr/local/work/emacs/doc/misc'
(cd doc/lispref &&   make  clean)
make[1]: Entering directory `/usr/local/work/emacs/doc/lispref'
rm -f *.toc *.aux *.log *.cp *.cps *.fn *.fns *.tp *.tps \
              *.vr *.vrs *.pg *.pgs *.ky *.kys
rm -f make.out core
make[1]: Leaving directory `/usr/local/work/emacs/doc/lispref'
(cd doc/lispintro &&   make  clean)
make[1]: Entering directory `/usr/local/work/emacs/doc/lispintro'
rm -f  *.log *.cp *.fn *.ky *.pg *.vr *.tp
rm -f *.dvi
make[1]: Leaving directory `/usr/local/work/emacs/doc/lispintro'
(cd leim;     make  clean)
make[1]: Entering directory `/usr/local/work/emacs/leim'
rm -f quail/CCDOSPY.elc quail/Punct.elc quail/QJ.elc quail/SW.elc quail/TONEPY.elc quail/4Corner.elc quail/ARRAY30.elc quail/ECDICT.elc quail/ETZY.elc quail/Punct-b5.elc quail/PY-b5.elc quail/QJ-b5.elc quail/ZOZY.elc quail/tsang-b5.elc quail/quick-b5.elc quail/tsang-cns.elc quail/quick-cns.elc quail/PY.elc quail/ZIRANMA.elc quail/CTLau.elc quail/CTLau-b5.elc quail/CCDOSPY.el quail/Punct.el quail/QJ.el quail/SW.el quail/TONEPY.el quail/4Corner.el quail/ARRAY30.el quail/ECDICT.el quail/ETZY.el quail/Punct-b5.el quail/PY-b5.el quail/QJ-b5.el quail/ZOZY.el quail/tsang-b5.el quail/quick-b5.el quail/tsang-cns.el quail/quick-cns.el quail/PY.el quail/ZIRANMA.el quail/CTLau.el quail/CTLau-b5.el \
		leim-list.el changed.tit changed.misc
make[1]: Leaving directory `/usr/local/work/emacs/leim'
(cd lisp;     make  bootstrap-clean)
make[1]: Entering directory `/usr/local/work/emacs/lisp'
cd /usr/local/work/emacs/lisp; rm -f *.elc */*.elc
make[1]: Leaving directory `/usr/local/work/emacs/lisp'
(cd leim;     make  bootstrap-clean)
make[1]: Entering directory `/usr/local/work/emacs/leim'
rm -f quail/CCDOSPY.elc quail/Punct.elc quail/QJ.elc quail/SW.elc quail/TONEPY.elc quail/4Corner.elc quail/ARRAY30.elc quail/ECDICT.elc quail/ETZY.elc quail/Punct-b5.elc quail/PY-b5.elc quail/QJ-b5.elc quail/ZOZY.elc quail/tsang-b5.elc quail/quick-b5.elc quail/tsang-cns.elc quail/quick-cns.elc quail/PY.elc quail/ZIRANMA.elc quail/CTLau.elc quail/CTLau-b5.elc quail/CCDOSPY.el quail/Punct.el quail/QJ.el quail/SW.el quail/TONEPY.el quail/4Corner.el quail/ARRAY30.el quail/ECDICT.el quail/ETZY.el quail/Punct-b5.el quail/PY-b5.el quail/QJ-b5.el quail/ZOZY.el quail/tsang-b5.el quail/quick-b5.el quail/tsang-cns.el quail/quick-cns.el quail/PY.el quail/ZIRANMA.el quail/CTLau.el quail/CTLau-b5.el \
		leim-list.el changed.tit changed.misc
rm -f quail/CCDOSPY.elc quail/Punct.elc quail/QJ.elc quail/SW.elc quail/TONEPY.elc /usr/local/work/emacs/leim/quail/py-punct.elc quail/4Corner.elc quail/ARRAY30.elc quail/ECDICT.elc quail/ETZY.elc quail/Punct-b5.elc quail/PY-b5.elc quail/QJ-b5.elc quail/ZOZY.elc /usr/local/work/emacs/leim/quail/pypunct-b5.elc /usr/local/work/emacs/leim/quail/japanese.elc /usr/local/work/emacs/leim/ja-dic/ja-dic.elc /usr/local/work/emacs/leim/quail/hangul.elc /usr/local/work/emacs/leim/quail/hangul3.elc /usr/local/work/emacs/leim/quail/hanja.elc /usr/local/work/emacs/leim/quail/hanja3.elc /usr/local/work/emacs/leim/quail/hanja-jis.elc /usr/local/work/emacs/leim/quail/symbol-ksc.elc /usr/local/work/emacs/leim/quail/thai.elc /usr/local/work/emacs/leim/quail/viqr.elc /usr/local/work/emacs/leim/quail/vntelex.el
 c /usr/local/work/emacs/leim/quail/lao.elc /usr/local/work/emacs/leim/quail/lrt.elc /usr/local/work/emacs/leim/quail/indian.elc /usr/local/work/emacs/leim/quail/tibetan.elc /usr/local/work/!
 emacs/leim/quail/latin-pre.elc /usr/local/work/emacs/leim/quail/latin-post.elc /usr/local/work/emacs/leim/quail/latin-alt.elc /usr/local/work/emacs/leim/quail/latin-ltx.elc /usr/local/work/emacs/leim/quail/welsh.elc /usr/local/work/emacs/leim/quail/czech.elc /usr/local/work/emacs/leim/quail/croatian.elc /usr/local/work/emacs/leim/quail/slovak.elc /usr/local/work/emacs/leim/quail/greek.elc /usr/local/work/emacs/leim/quail/cyrillic.elc /usr/local/work/emacs/leim/quail/cyril-jis.elc /usr/local/work/emacs/leim/quail/ethiopic.elc /usr/local/work/emacs/leim/quail/ipa.elc /usr/local/work/emacs/leim/quail/hebrew.elc /usr/local/work/emacs/leim/quail/georgian.elc /usr/local/work/emacs/leim/quail/sisheng.elc quail/tsang-b5.elc quail/quick-b5.elc quail/tsang-cns.elc quail/quick-cns.elc quail/PY.elc q
 uail/ZIRANMA.elc quail/CTLau.elc quail/CTLau-b5.elc /usr/local/work/emacs/leim/quail/sgml-input.elc /usr/local/work/emacs/leim/quail/rfc1345.elc /usr/local/work/emacs/leim/quail/uni-input.e!
 lc
make[1]: Leaving directory `/usr/local/work/emacs/leim'
make  info bootstrap-build
make[1]: Entering directory `/usr/local/work/emacs'
(cd doc/emacs; make -w info)
make[2]: Entering directory `/usr/local/work/emacs/doc/emacs'
cd /usr/local/work/emacs/doc/emacs; makeinfo --force emacs.texi
make[2]: Leaving directory `/usr/local/work/emacs/doc/emacs'
(cd doc/misc; make -w info)
make[2]: Entering directory `/usr/local/work/emacs/doc/misc'
cd /usr/local/work/emacs/doc/misc; makeinfo --force cc-mode.texi
cd /usr/local/work/emacs/doc/misc; makeinfo --force flymake.texi
cd /usr/local/work/emacs/doc/misc; makeinfo --force gnus.texi
cd /usr/local/work/emacs/doc/misc; makeinfo --force --no-split info.texi -o ../../info/info
cd /usr/local/work/emacs/doc/misc; makeinfo --force -D emacs tramp.texi
cd /usr/local/work/emacs/doc/misc; makeinfo --force viper.texi
make[2]: Leaving directory `/usr/local/work/emacs/doc/misc'
(cd doc/lispref; make -w info)
make[2]: Entering directory `/usr/local/work/emacs/doc/lispref'
cd /usr/local/work/emacs/doc/lispref; makeinfo --force -I. -I../../info elisp.texi -o ../../info/elisp
make[2]: Leaving directory `/usr/local/work/emacs/doc/lispref'
(cd doc/lispintro; make -w info)
make[2]: Entering directory `/usr/local/work/emacs/doc/lispintro'
make[2]: Nothing to be done for `info'.
make[2]: Leaving directory `/usr/local/work/emacs/doc/lispintro'
(cd lisp; make -w bootstrap-prepare)
make[2]: Entering directory `/usr/local/work/emacs/lisp'
if test -x ../src/emacs; then				\
	  make -w autoloads;				\
	else							\
	  cp /usr/local/work/emacs/lisp/ldefs-boot.el /usr/local/work/emacs/lisp/loaddefs.el;		\
	fi
make[3]: Entering directory `/usr/local/work/emacs/lisp'
wd=/usr/local/work/emacs/lisp; subdirs=`(cd $wd; find . -type d -print)`; for file in $subdirs; do case $file in */Old | */RCS | */CVS | */CVS/* | */.* | */.*/* | */=* | */obsolete | */term ) ;; *) wins="$wins $wd/$file" ;; esac; done; \
	echo Directories: $wins; \
	EMACSLOADPATH=/usr/local/work/emacs/lisp ../src/emacs -batch --no-site-file --multibyte -l autoload --eval '(setq generated-autoload-file "/usr/local/work/emacs/lisp/loaddefs.el")' -f batch-update-autoloads $wins
Directories: /usr/local/work/emacs/lisp/. /usr/local/work/emacs/lisp/./emulation /usr/local/work/emacs/lisp/./mail /usr/local/work/emacs/lisp/./toolbar /usr/local/work/emacs/lisp/./gnus /usr/local/work/emacs/lisp/./url /usr/local/work/emacs/lisp/./international /usr/local/work/emacs/lisp/./erc /usr/local/work/emacs/lisp/./calc /usr/local/work/emacs/lisp/./textmodes /usr/local/work/emacs/lisp/./eshell /usr/local/work/emacs/lisp/./emacs-lisp /usr/local/work/emacs/lisp/./play /usr/local/work/emacs/lisp/./progmodes /usr/local/work/emacs/lisp/./mh-e /usr/local/work/emacs/lisp/./calendar /usr/local/work/emacs/lisp/./net /usr/local/work/emacs/lisp/./language
Recursive `require' for feature `help-fns'
make[3]: *** [autoloads] Error 255
make[3]: Leaving directory `/usr/local/work/emacs/lisp'
make[2]: *** [bootstrap-prepare] Error 2
make[2]: Leaving directory `/usr/local/work/emacs/lisp'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/usr/local/work/emacs'
make: *** [bootstrap] Error 2

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/15/07, Kenichi Handa <handa@m17n.org> wrote:

> FYI, when I try "make bootstrap", this error happens:
>
>         Recursive `require' for feature `help-fns'

That's my fault:

2007-10-15  Juanma Barranquero  <lekktu@gmail.com>

        * help-fns.el: Require advice when compiling.

and I didn't realize that advice.el requires help-fns.el.

I was trying to fix this recent breakage:

emacs -Q -D
M-: (setq debug-on-error t)
M-x load-library [RET] advice [RET]
C-h f getenv [RET]

 =>

Debugger entered--Lisp error: (invalid-function ad-get-advice-info)
  ad-get-advice-info(getenv)
  describe-function-1(getenv)
  describe-function(getenv)
  call-interactively(describe-function)

which is caused by this change:

2007-10-14  Richard Stallman  <rms@gnu.org>

        * help-fns.el (describe-function-1): Find source of advised functions.

because it uses ad-get-advice-info, which is a macro.

             Juanma

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Stefan Monnier]

>> FYI, when I try "make bootstrap", this error happens:
>> Recursive `require' for feature `help-fns'

> That's my fault:

> 2007-10-15  Juanma Barranquero  <lekktu@gmail.com>

>         * help-fns.el: Require advice when compiling.

> and I didn't realize that advice.el requires help-fns.el.

IIRC it only requires it for the purpose of help-function-arglist.
Maybe those functions should simply be placed in the preloaded
help.el instead (they're also used by cl-macs.el IIRC).


        Stefan

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/15/07, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Maybe those functions should simply be placed in the preloaded
> help.el instead (they're also used by cl-macs.el IIRC).

Those functions are used by advice.el, eldoc.el, cl-macs.el and
autoload.el. I've tried moving them to help.el, but it caused other
problems during bootstrapping. I don't think a single use of a
one-line macro is worth the shuffling around... Perhaps it would be
easier to just copy the relevant macro from advice.el to help-fns.el,
or just use its expansion:

(defmacro ad-get-advice-info (function)
  `(get ,function 'ad-advice-info))

Yes, I know, a horrible kludge.

             Juanma

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/15/07, Juanma Barranquero <lekktu@gmail.com> wrote:

> Perhaps it would be
> easier to just copy the relevant macro from advice.el to help-fns.el,
> or just use its expansion:
>
> (defmacro ad-get-advice-info (function)
>   `(get ,function 'ad-advice-info))
>
> Yes, I know, a horrible kludge.

OTOH, help-fns.el is already using 'origname directly...

             Juanma

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Kenichi Handa]

"Juanma Barranquero" <lekktu@gmail.com> writes:

> On 10/15/07, Juanma Barranquero <lekktu@gmail.com> wrote:
> > Perhaps it would be
> > easier to just copy the relevant macro from advice.el to help-fns.el,
> > or just use its expansion:
> >
> > (defmacro ad-get-advice-info (function)
> >   `(get ,function 'ad-advice-info))
> >
> > Yes, I know, a horrible kludge.

> OTOH, help-fns.el is already using 'origname directly...

With the latest update, make bootstrap works fine.  But, the
original problem (china-util.elc can't be loaded) is still
there.

---
Kenichi Handa
handa@m17n.org

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Kenichi Handa]

In article <E1Ii13R-0002Dm-VP@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:

>     With the latest update, make bootstrap works fine.  But, the
>     original problem (china-util.elc can't be loaded) is still
>     there.

> Can you please help debug that?  It's your area.

None of mule related code (including china-util.el) was
changed when this bug appeared.  So, I believe the problem
is not within my area.

I tried to build Emacs from snapshots of one day after one
from Oct.1, and found that some change committed between
Oct.9 and Oct.10 introduced this problem.  I'll attatch the
diffs of lisp/ChangeLog and src/ChangeLog.  I have no idea
which change affects the byte-compiler, byte-code loader, or
byte-code interpreter.

---
Kenichi Handa
handa@m17n.org

Index: lisp/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.11868
retrieving revision 1.11881
diff -r1.11868 -r1.11881
0a1,39
> 2007-10-09  Juanma Barranquero  <lekktu@gmail.com>
> 
> 	* follow.el (follow-mode-hook, follow-mode): Doc fixes.
> 	(follow-mode-off-hook): Mark as obsolete.
> 
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* window.el (mouse-autoselect-window-cancel): Don't cancel for
> 	select-window or select-frame events.
> 	(handle-select-window): When autoselecting window set input
> 	focus.  Restructure.
> 
> 	* frame.el (focus-follows-mouse): Moved to frame.c.
> 	* cus-start.el (all): Add focus-follows-mouse.
> 
> 2007-10-08  Juanma Barranquero  <lekktu@gmail.com>
> 
> 	* bs.el (bs-mode): Make sure global-font-lock-mode doesn't
> 	activate font-locking in the *buffer-selection* buffer.
> 	(bs-show-sorted): Doc fix.
> 
> 	* bs.el (bs--get-marked-string, bs--get-modified-string)
> 	(bs--get-readonly-string, bs--get-size-string, bs--get-name)
> 	(bs--get-mode-name, bs-mode): Fix typos in docstrings.
> 	(bs--format-aux): Doc fix.
> 
> 2007-10-08  Micha^[,Ak^[(Bl Cadilhac  <michael@cadilhac.name>
> 
> 	* progmodes/gud.el (gud-gud-gdb-command-name): Fix typo in docstring.
> 
> 2007-10-08  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* progmodes/gud.el (gud-gud-gdb-command-name): New option.
> 	(gud-gdb): New function for old M-x gdb (text command mode).
> 	(gud-gdb-command-name, gdb): Move to...
> 
> 	* progmodes/gdb-ui.el: ...here and adapt doc string.
> 	(gud-gdba-command-name, gdba): Delete.
> 
2a42,339
> 	* bs.el: Don't defvar `font-lock-verbose'.
> 	(bs-config-clear, bs-kill, bs-string-show-normally, bs-sort-functions)
> 	(bs--get-file-name): Fix typos in docstrings.
> 	(bs--show-header): Use `dolist' instead of `mapcar'.
> 	(bs-mode): Set `show-trailing-whitespace' to nil.
> 	(bs-buffer-sort-function, bs-mouse-select-other-frame)
> 	(bs-visits-non-file, bs-sort-buffer-interns-are-last, bs-show):
> 	Doc fixes.
> 
> 2007-10-08  Adam Hupp  <adam@hupp.org>  (tiny change)
> 
> 	* progmodes/gdb-ui.el (pdb): Specify file for gud-break.
> 
> 2007-10-08  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* progmodes/gud.el (gdb): Make graphical mode the default and
> 	switch to text command mode if appropriate, i.e., reverse previous
> 	arrangement.
> 	(gud-gdb-marker-filter): Adapt for above change.
> 
> 	* progmodes/gdb-ui.el (gdb-init-1): Don't set the values
> 	gud-minor-mode and gud-marker-filter.
> 	(gdb-fullname-regexp): New variable.
> 	(gud-gdba-marker-filter): Use it to switch to text command
> 	mode if appropriate.
> 
> 2007-10-08  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* progmodes/gud.el (gud-display-line): Find source buffer even when
> 	GUD buffer has its own frame.
> 
> 2007-10-08  Jan Dj^[,Ad^[(Brv  <jan.h.d@swipnet.se>
> 
> 	* term/x-win.el (icon-map-list): Set to nil for 22.1 compatibility.
> 
> 2007-10-08  Jan Dj^[,Ad^[(Brv  <jan.h.d@swipnet.se>
> 
> 	* term/x-win.el (x-gtk-stock-map): Version is 22.2.
> 
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* allout.el (allout-before-change-handler): Replace got-char by
> 	goto-char.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* vc-svn.el (vc-svn-resolve-when-done, vc-svn-find-file-hook): New funs.
> 	Used to try and automatically enabled smerge-mode in the presence of
> 	conflicts and to call `svn resolved' when the conflicts are gone.
> 	(vc-svn-parse-status): Remember the svn-specific status.
> 
> 2007-10-08  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* menu-bar.el (menu-bar-search-documentation-menu): Rename from
> 	menu-bar-apropos-menu.  All users changed.
> 	(menu-bar-help-menu): Change menu symbols to better match the text
> 	displayed by the menu.
> 
> 2007-10-08  Dan Nicolaescu  <dann@ics.uci.edu>
> 
> 	* files.el (file-name-sans-versions): Use [:alnum:] and also allow
> 	#, @, : and ^.
> 
> 2007-10-08  Dan Nicolaescu  <dann@ics.uci.edu>
> 
> 	* pcvs-defs.el (cvs-mode-map): Bind TAB and backtab.
> 
> 	* log-view.el (log-view-mode-map): Likewise.
> 
> 	* diff-mode.el (diff-mode-shared-map): Likewise.
> 
> 2007-10-08  Dan Nicolaescu  <dann@ics.uci.edu>
> 
> 	* files.el (file-name-sans-versions): Also allow `A-Z'.
> 
> 	* vc.el: Mention all supported VC backends.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* wid-edit.el (widget-specify-button): Don't merge mouse-face with
> 	neighbouring buttons.
> 
> 2007-10-08  Andreas Schwab  <schwab@suse.de>
> 
> 	* files.el (file-name-sans-versions): Also allow `_'.
> 
> 2007-10-08  Dan Nicolaescu  <dann@ics.uci.edu>
> 
> 	* files.el (file-name-sans-versions): Allow - and a-z in version names.
> 
> 	* log-view.el (log-view-mode-map, log-view-mode-menu):
> 	Bind log-view-annotate-version.
> 	(log-view-beginning-of-defun, log-view-end-of-defun)
> 	(log-view-annotate-version): New functions.
> 	(log-view-mode): Use log-view-beginning-of-defun and
> 	log-view-end-of-defun.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* emacs-lisp/easy-mmode.el (define-minor-mode): Fix staging.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* wid-edit.el (widget-image-insert): Don't merge mouse-face with
> 	neighbouring buttons.
> 
> 	* progmodes/compile.el (compilation-error-regexp-alist-alist):
> 	Recognize gcc's use of "note" for informational messages.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* textmodes/css-mode.el (css-electric-keys): electrick->electric.
> 	(css-mode): Update correspondingly.
> 
> 2007-10-08  Dan Nicolaescu  <dann@ics.uci.edu>
> 
> 	* vc-git.el (vc-git-log-view-mode): Add font-lock patterns for
> 	Signed-off-by, Acked-by and Merge.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* ediff-init.el (ediff-verbose-p): This var is not a constant.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* vc-mtn.el: New file.
> 
> 	* vc-hooks.el (vc-handled-backends): Add Mtn.
> 
> 2007-10-08  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* files.el (find-file, find-file-other-window)
> 	(find-file-other-frame, find-file-existing, find-file-read-only)
> 	(find-file-read-only-other-window)
> 	(find-file-read-only-other-frame)
> 	(find-alternate-file-other-window, find-alternate-file): Doc fixes.
> 
> 2007-10-08  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* progmodes/gud.el (gdb-ready): New variable.
> 	(gdb): Set it to nil.  Set gud-running to nil here...
> 	(gud-common-init): ...instead of here.
> 
> 	* progmodes/gdb-ui.el (gdba, gdb-send, gdb-source-info):
> 	Use gdb-ready.  Discard input until GDB is ready to accept it.
> 
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* dired.el (dired-warning): Inherit from font-lock-warning-face to
> 	make it show up with eight colors.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* diff-mode.el (diff-sanity-check-hunk): Fix up the case when unified
> 	diffs are concatenated with no intervening line.
> 
> 2007-10-08  Dave Love  <fx@gnu.org>
> 
> 	* progmodes/python.el: Merge changes from Dave Love's v2007-Sep-10.
> 	(python-font-lock-keywords): Update to the 2.5 version of the language.
> 	(python-quote-syntax): Let-bind font-lock-syntactic-keywords to nil.
> 	(python-backspace): Only behave funny in code.
> 	(python-compilation-regexp-alist): Add PDB stack trace regexp.
> 	(inferior-python-mode): Add PDB prompt regexp.
> 	(python-fill-paragraph): Refine the fenced-string regexp.
> 	(python-find-imports): Handle imports spanning several lines.
> 	(python-mode): Add `class' to hideshow support.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* pcvs.el (cvs-mode-add-change-log-entry-other-window): Use
> 	add-log-buffer-file-name-function rather than bind buffer-file-name,
> 	so we dont end up calling change-log-mode in *cvs* when `fi' is the
> 	ChangeLog file itself.
> 
> 	* outline.el (outline-flag-region): Use front-advance.
> 
> 2007-10-08  Ilya Zakharevich  <ilyaz@cpan.org>
> 
> 	* progmodes/cperl-mode.el: Merge upstream 5.23.
> 	(cperl-where-am-i): Remove function.
> 	(cperl-backward-to-noncomment): Don't go too far when skipping POD/HEREs
> 	(cperl-sniff-for-indent): De-invert [string] and [comment].
> 	When looking for label, skip s:m:y:tr.
> 	(cperl-indent-line): Likewise.
> 	(cperl-mode): Don't assume `font-lock-multiline' is auto-local.
> 	(cperl-windowed-init): Wrong `ps-print' handling.
> 	Both thanks to Chong Yidong.
> 	(cperl-look-at-leading-count): Could fail with unfinished RExen.
> 	(cperl-find-pods-heres): If the second part of s()[] is missing,
> 	don't try to highlight delimiters...
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* progmodes/compile.el (compilation-get-file-structure): Complete last
> 	change by also using spec-directory in the puthash.
> 
> 2007-10-08  Riccardo Murri  <riccardo.murri@gmail.com>
> 
> 	* vc-bzr.el (vc-bzr-file-name-relative): Use 'when' instead of 'and'.
> 	(vc-bzr-status): Fix shadowing of variable 'status'.
> 	(vc-bzr-workfile-version): Use correct path to 'last-revision' file.
> 	Use `expand-file-name' instead of `concat'.
> 	(vc-bzr-annotate-command): Use option name '--long' instead of '-l'.
> 	Update annotation line regexp.  Fixes launchpad.net [Bug 137435].
> 
> 2007-10-08  Jason Rumney  <jasonr@gnu.org>
> 
> 	* frame.el (focus-follows-mouse): Doc-fix. Change default on w32.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* emacs-lisp/lisp-mode.el (lisp-indent-offset): Make defcustom.
> 	Add `safe-local-variable' property.
> 	(lisp-body-indent): Likewise.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* files.el (hack-local-variables-confirm): Rename arg VARS to ALL-VARS.
> 	Add doc string.
> 
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* files.el (backup-buffer-copy): Try to overwrite old backup first.
> 
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* repeat.el (repeat): Use last-repeatable-command instead of
> 	real-last-command.  Run pre- and post-command hooks for
> 	self-insertion.  Update doc-string.
> 
> 2007-10-08  Alexandre Julliard  <julliard@winehq.org>
> 
> 	* vc-git.el (vc-git-state): Call git-add --refresh to update the
> 	state of the file.
> 	(vc-git-workfile-unchanged-p): Delegate implementation to vc-git-state.
> 	(vc-git-create-repo): Fix invalid command.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* textmodes/flyspell.el (flyspell-mode):
> 	Catch errors in flyspell-mode-on.
> 
> 2007-10-09  Juanma Barranquero  <lekktu@gmail.com>
> 
> 	* term/x-win.el (x-alternatives-map): Remove spurious parenthesis.
> 
> 2007-10-09  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* international/encoded-kb.el (encoded-kbd-setup-display):
> 	Use input-decode-map rather than local-key-translation-map.
> 
> 	* term/rxvt.el (rxvt-alternatives-map): New map.
> 	(terminal-init-rxvt): Use it.
> 	Bind rxvt-function-map in input-decode-map.
> 
> 	* term/xterm.el (xterm-alternatives-map): New map.
> 	(terminal-init-xterm): Use it.
> 	Bind xterm-function-map in input-decode-map.
> 
> 	* term/x-win.el (x-alternatives-map): New var.
> 	(x-setup-function-keys): Use it.
> 
> 	* help-fns.el (describe-variable): Slightly change the layout of
> 	meta-info to separate it better from the docstring.
> 	Standardize insertion of extra empty lines in various circumstances.
> 
> 	* diff-mode.el (diff-hunk-style): New fun.
> 	(diff-end-of-hunk): Use it.
> 	(diff-context->unified): Use the new `apply' undo element,
> 	if applicable, so as to save undo-log space.
> 	(diff-fine-change): New face.
> 	(diff-fine-highlight-preproc): New function.
> 	(diff-fine-highlight): New command.
> 	(diff-mode-map, diff-mode-menu): Add diff-fine-highlight.
> 
> 	* smerge-mode.el (smerge-refine-chopup-region): Add `preproc' argument.
> 	(smerge-refine-highlight-change): Add `props' argument.
> 	(smerge-refine-subst): New function holding most of smerge-refine.
> 	(smerge-refine): Use it.
> 
> 2007-10-08  Eric S. Raymond  <esr@snark.thyrsus.com>
> 
> 	* vc.el (vc-default-wash-log): Remove unused code, the
> 	log washers all live in the backends now.
> 	(vc-default-comment-history): Correct for the fact
> 	that wash-log is argumentless in the new API.
> 
> 2007-10-08  Michael Albinus  <michael.albinus@gmx.de>
> 
> 	* net/tramp.el (tramp-find-foreign-file-name-handler): Check also host.
> 	(tramp-maybe-send-script): Apply `member' but `memq'.
> 	(tramp-advice-file-expand-wildcards): Simplify implementation.
> 
> 2007-10-08  Juanma Barranquero  <lekktu@gmail.com>
> 
> 	* follow.el (follow-mode): Don't run hooks twice.  Use `when'.
> 
44,45c381,382
< 	* net/tramp-fish.el (tramp-fish-handle-process-file): Rewrite
< 	temporary file handling.
---
> 	* net/tramp-fish.el (tramp-fish-handle-process-file):
> 	Rewrite temporary file handling.
53c390
< 	There are changes to existing logic in this patch.
---
> 	There are no changes to existing logic in this patch.

Index: src/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/src/ChangeLog,v
retrieving revision 1.5913
retrieving revision 1.5917
diff -r1.5913 -r1.5917
0a1,113
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* keyboard.c (kbd_buffer_get_event): Break loop waiting for input
> 	when there's an unread command event.
> 
> 	* frame.c (focus_follows_mouse): Moved here from frame.el to allow
> 	window autoselection act appropriately when leaving selected frame.
> 	(syms_of_frame): Initialize focus_follows_mouse.
> 	* frame.h (focus_follows_mouse): Extern it.
> 	* macterm.c (XTread_socket): When focus_follows_mouse is nil
> 	make SELECT_WINDOW_EVENT only if we don't leave the selected
> 	frame.
> 	* msdos.c (dos_rawgetc): Likewise.
> 	* w32term.c (w32_read_socket): Likewise.
> 	* xterm.c (handle_one_xevent): Likewise.
> 	* xdisp.c (syms_of_xdisp): In doc-string of
> 	mouse-autoselect-window mention focus-follows-mouse.
> 
> 2007-10-08  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
> 
> 	* macterm.c (mac_load_query_font): Fix missing return value.
> 	[USE_CG_DRAWING] (mac_define_fringe_bitmap, mac_destroy_fringe_bitmap):
> 	Add BLOCK_INPUT.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* xdisp.c (get_window_cursor_type): Implement documented behavior
> 	for cursor-in-non-selected-windows = t.
> 
> 2007-10-08  Jason Rumney  <jasonr@gnu.org>
> 
> 	* w32.c (w32_get_resource): Always close registry keys.
> 
> 2007-10-08  Jason Rumney  <jasonr@gnu.org>
> 
> 	* makefile.w32-in (LIBS): Add COMCTL32.
> 
> 	* w32fns.c (globals_of_w32fns): Init common controls.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* image.c (our_memory_buffer): Renamed from omfib_buffer.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* buffer.c (Foverlays_at): Doc fix.
> 
> 2007-10-08  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	* fns.c (Fplist_put): Preserve uneven tail data.
> 
> 2007-10-08  Peter O'Gorman  <bug-gnu-emacs@mlists.thewrittenword.com>  (tiny change)
> 
> 	* termhooks.h (enum event_kind): Remove trailing comma.
> 
> 	* frame.h (enum): Remove trailing comma.
> 
> 2007-10-08  Dhuvra Krishnamurthy  <dhuvrakm@gmail.com>  (tiny change)
> 
> 	* w32proc.c (delete_child): Don't terminate threads of zombies.
> 
> 2007-10-08  Martin Rudalics  <rudalics@gmx.at>
> 
> 	* keyboard.h (struct kboard): New elt Vlast_repeatable_command.
> 
> 	* keyboard.c (syms_of_keyboard): Set up new Lisp variable
> 	last-repeatable-command.
> 	(init_kboard): Initialize Vlast_repeatable_command.
> 	(command_loop_1): Set it to real_this_command unless that was
> 	bound to an input event.
> 	(mark_kboards): Mark it.
> 
> 2007-10-08  Richard Stallman  <rms@gnu.org>
> 
> 	* eval.c (condition-case): Doc fix.
> 
> 2007-10-08  Masatake YAMATO  <jet@gyve.org>
> 
> 	* xfaces.c (tty_supports_face_attributes_p): Fix code
> 	for LFACE_INVERSE_INDEX and LFACE_BACKGROUND_INDEX; code
> 	was copied and not edited.
> 
> 2007-10-09  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	Add new `input-decode-map' keymap and use it for temrinal
> 	escape sequences.
> 	* keyboard.h (struct kboard): Add Vinput_decode_map.
> 	Remove Vlocal_key_translation_map.
> 	* keyboard.c (read_key_sequence): Add support for input-decode-map.
> 	(init_kboard): Init input-decode-map.
> 	Replace local-key-translation-map back with key-translation-map.
> 	(syms_of_keyboard): Declare input-decode-map.
> 	Remove local-key-translation-map.  Update docstrings.
> 	(mark_kboards): Mark Vinput_decode_map.
> 	Don't mark Vlocal_key_translation_map.
> 	* keymap.c (Fdescribe_buffer_bindings): Describe input-decode-map.
> 	Replace local-key-translation-map back with key-translation-map.
> 	* term.c (term_get_fkeys_1, CONDITIONAL_REASSIGN):
> 	Bind in input-decode-map rather than function-key-map.
> 
> 	* lisp.h (XSETPSEUDOVECTOR): Don't set the tag anymore.
> 	This was made redundant by the previous introduction of XSETPVECTYPE.
> 
> 2007-10-09  Richard Stallman  <rms@gnu.org>
> 
> 	* image.c (free_bitmap_record): Rename from Free_Bitmap_Record.
> 
> 2007-09-29  Richard Stallman  <rms@gnu.org>
> 
> 	* eval.c (internal_condition_case_2, internal_condition_case_1)
> 	(internal_condition_case): Reenable abort if x_catching_errors ()
> 	to see if that really happens and why.
> 
1593a1707,1710
> 	(Fwindow_full_width_p): New defun.
> 	(syms_of_window): Defsubr it.
> 
> 	* window.h: Add EXFUN for Fwindow_full_width_p.

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Stefan Monnier]

> None of mule related code (including china-util.el) was
> changed when this bug appeared.  So, I believe the problem
> is not within my area.

I believe it is fixed now in the trunk,


        Stefan

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Kenichi Handa]

In article <jwvsl49lthm.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > None of mule related code (including china-util.el) was
> > changed when this bug appeared.  So, I believe the problem
> > is not within my area.

> I believe it is fixed now in the trunk,

Thank you!  I confirmed that china-util.elc can be loaded
without problem now.

---
Kenichi Handa
handa@m17n.org

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Richard Stallman]

    > None of mule related code (including china-util.el) was
    > changed when this bug appeared.  So, I believe the problem
    > is not within my area.

    I believe it is fixed now in the trunk,

Thanks to whoever fixed it.

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Richard Stallman]

    None of mule related code (including china-util.el) was
    changed when this bug appeared.  So, I believe the problem
    is not within my area.

china-util.el is in your area.  You may be right that the bug is
elsewhere, but the only sure way to find it is to debug loading
china-util.el.  You can do that better than anyone else.

    I tried to build Emacs from snapshots of one day after one
    from Oct.1, and found that some change committed between
    Oct.9 and Oct.10 introduced this problem.

Maybe that information will enable someone else to guess the problem
and fix it.  But if it is not fixed a few days from now, would you
please debug why china-util.el gets an error?

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Kenichi Handa]

In article <E1IiFpv-0003Kh-Ki@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:

>     I tried to build Emacs from snapshots of one day after one
>     from Oct.1, and found that some change committed between
>     Oct.9 and Oct.10 introduced this problem.

> Maybe that information will enable someone else to guess the problem
> and fix it.  But if it is not fixed a few days from now, would you
> please debug why china-util.el gets an error?

Stefan has just fixed it... perhaps by this change.

2007-10-17  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lread.c (read1): Set pvectype for char_tables.

---
Kenichi Handa
handa@m17n.org

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Stefan Monnier]

>> I tried to build Emacs from snapshots of one day after one
>> from Oct.1, and found that some change committed between
>> Oct.9 and Oct.10 introduced this problem.

>> Maybe that information will enable someone else to guess the problem
>> and fix it.  But if it is not fixed a few days from now, would you
>> please debug why china-util.el gets an error?

> Stefan has just fixed it... perhaps by this change.

> 2007-10-17  Stefan Monnier  <monnier@iro.umontreal.ca>

> 	* lread.c (read1): Set pvectype for char_tables.

Indeed that was it.  And -DENABLE_CHECKING caught it right away.


        Stefan

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Richard Stallman]

    2007-10-14  Richard Stallman  <rms@gnu.org>

	    * help-fns.el (describe-function-1): Find source of advised functions.

    because it uses ad-get-advice-info, which is a macro.

I made a change in advice.el which ought to fix that.

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/16/07, Richard Stallman <rms@gnu.org> wrote:

> I made a change in advice.el which ought to fix that.

There are two regressions.

 (defun test ()
    "My test docstring."
    t)

 M-: (defadvice test (before doc-bug)) [RET]
 C-h f test [RET]
   =>
 Symbol's function definition is void: ad-Orig-test

 M-: (defadvice test (before doc-bug activate)) [RET]
 C-h f test [RET]
   =>
 test is a Lisp function.
 (test)

 Advice doc string

 [back]

             Juanma

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Richard Stallman]

    There are two regressions.

     (defun test ()
	"My test docstring."
	t)

     M-: (defadvice test (before doc-bug)) [RET]
     C-h f test [RET]
       =>
     Symbol's function definition is void: ad-Orig-test

I fixed that.

     M-: (defadvice test (before doc-bug activate)) [RET]
     C-h f test [RET]
       =>
     test is a Lisp function.
     (test)

     Advice doc string

I can't reproduce that.

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/18/07, Richard Stallman <rms@gnu.org> wrote:

> I fixed that.

Thanks.

> I can't reproduce that.

Uh? Curious. I stil get it, with emacs -Q -D:

 *** Welcome to IELM ***  Type (describe-mode) for help.
 ELISP> (defun test () "Correct docstring." nil)
 test
 ELISP> (defadvice test (before doc-bug activate))
 test
 ELISP> (documentation 'test)
 #("Advice doc string" 0 17
   (ad-advice-info test))

Is anyone else able to see this problem?

             Juanma

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Glenn Morris]

"Juanma Barranquero" wrote:

> Uh? Curious. I stil get it, with emacs -Q -D:
>
>  *** Welcome to IELM ***  Type (describe-mode) for help.
>  ELISP> (defun test () "Correct docstring." nil)
>  test
>  ELISP> (defadvice test (before doc-bug activate))
>  test
>  ELISP> (documentation 'test)
>  #("Advice doc string" 0 17
>    (ad-advice-info test))
>
> Is anyone else able to see this problem?

With a bootstrap-build from yesterday, yes.
With a bootstrap-build from today, no.

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/19/07, Glenn Morris <rgm@gnu.org> wrote:

> With a bootstrap-build from yesterday, yes.
> With a bootstrap-build from today, no.

Surely the fact that RMS just fixed it must be significant :)

2007-10-19  Richard Stallman  <rms@gnu.org>

        * doc.c (Fdocumentation): Check for and handle an advised function.

Thanks for checking.

             Juanma

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Juanma Barranquero]

On 10/19/07, Juanma Barranquero <lekktu@gmail.com> wrote:

> Surely the fact that RMS just fixed it must be significant :)

I spoke too soon :(

I still see the bug with my previous test case.

Richard's fix is inside the "else if (CONSP (fun))" part of the
conditional in Fdocumentation, but in my examples is the "else if
(COMPILEDP (fun))" branch the one taken.

Perhaps the intent was to put the new code outside the conditional, as
in the patch below? That seems to work for me.

             Juanma


Index: src/doc.c
===================================================================
RCS file: /sources/emacs/emacs/src/doc.c,v
retrieving revision 1.126
diff -u -2 -r1.126 doc.c
--- src/doc.c	19 Oct 2007 17:23:31 -0000	1.126
+++ src/doc.c	20 Oct 2007 00:38:27 -0000
@@ -435,16 +435,4 @@
 	  else
 	    return Qnil;
-
-	  /* Check for an advised function.  Its doc string
-	     has an `ad-advice-info' text property.  */
-	  if (STRINGP (doc))
-	    {
-	      Lisp_Object innerfunc;
-	      innerfunc = Fget_text_property (make_number (0),
-					      intern ("ad-advice-info"),
-					      doc);
-	      if (! NILP (innerfunc))
-		doc = call1 (intern ("ad-make-advised-docstring"), innerfunc);
-	    }
 	}
       else if (EQ (funcar, Qmacro))
@@ -459,4 +447,16 @@
     }

+  /* Check for an advised function.  Its doc string
+     has an `ad-advice-info' text property.  */
+  if (STRINGP (doc))
+    {
+      Lisp_Object innerfunc;
+      innerfunc = Fget_text_property (make_number (0),
+				      intern ("ad-advice-info"),
+				      doc);
+      if (! NILP (innerfunc))
+	doc = call1 (intern ("ad-make-advised-docstring"), innerfunc);
+    }
+
   /* If DOC is 0, it's typically because of a dumped file missing
      from the DOC file (bug in src/Makefile.in).  */

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Richard Stallman]

My doc.c patch worked for me, but I did not try compiling advice.  I
think you are right that the new code should be moved.  I am leaving
now on a trip.  Would you please move it?

Re: 23.0.50;(set-language-environment 'Chinese-GB) error

[Richard Stallman]

I think the remaining problem was because I had not installed the change
in doc.c.  I installed it today.