From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#36237: Support (rx (and (regexp EXPR) (regexp-quote EXPR))) Date: Thu, 20 Jun 2019 12:26:21 +0200 Message-ID: References: <87fto9yawl.fsf@gmail.com> <385FA4F7-7FB5-43A2-B571-CFBA20B24123@acm.org> <87tvcmwe6b.fsf@gmail.com> <87o92tw13b.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262078"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Heerdegen , 36237@debbugs.gnu.org, Stefan Monnier , kevin.legouguec@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 20 12:59:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdumY-00160L-Bk for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jun 2019 12:59:06 +0200 Original-Received: from localhost ([::1]:46108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdumX-0000an-6V for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jun 2019 06:59:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45757) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdufB-0002WR-Db for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 06:51:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hduUo-0003np-QK for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 06:40:48 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hduHV-0008UA-Vh for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 06:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hduHV-0006y2-Ju for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2019 06:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2019 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36237-submit@debbugs.gnu.org id=B36237.156102639826750 (code B ref 36237); Thu, 20 Jun 2019 10:27:01 +0000 Original-Received: (at 36237) by debbugs.gnu.org; 20 Jun 2019 10:26:38 +0000 Original-Received: from localhost ([127.0.0.1]:47907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hduH7-0006xN-Pl for submit@debbugs.gnu.org; Thu, 20 Jun 2019 06:26:38 -0400 Original-Received: from mail1426c50.megamailservers.eu ([91.136.14.26]:34976 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hduH3-0006x6-Fa for 36237@debbugs.gnu.org; Thu, 20 Jun 2019 06:26:35 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1561026386; bh=uVZhj6yncd5qOH1lgDPk+g6oSRu2ziB8XJ2+5lcK3U8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=CKAY2ut1j4b6qTeggDx/rpVk4ajci3HmJjx+4lOZWdtQFReJP435jTT765VBQ7Ip9 mPwC5vpuNQYbMvEm+ANtTZBskPqFgQW1crLnswVBZ/vKk8U/0eaoJO0/swmgCTACW3 Dt8t8sEs3/lg6UOyqIoXQUjqYeoKORyZsjWbnHq0= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x5KAQMYP004969; Thu, 20 Jun 2019 10:26:23 +0000 In-Reply-To: <87o92tw13b.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0206.5D0B5F52.004A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=F7x5iJpN c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=Td0tSAp4GFf4f10Xf_8A:9 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160885 Archived-At: 20 juni 2019 kl. 02.29 skrev Noam Postavsky : >=20 > <0001-Support-rx-and-regexp-EXPR-literal-EXPR-Bug-36237.patch> Things I didn't notice earlier: -;; (rx (and line-start (eval something-else))), statically or -;; (rx-to-string '(and line-start ,something-else)), dynamically. +;; (rx (seq line-start (regexp something-else))) You can actually drop the `seq' form entirely, since it's implicit in = `rx'. It was only needed for `rx-to-string' which is now gone. +`(literal STRING)' + matches STRING literally, where STRING is any lisp + expression that evaluates to a string. It's better to name the metavariable EXPR, STRING-EXPR or LISP-EXPR to = make it clear that it's an arbitrary lisp expression, especially since = STRING is used for a constant string just above. The same goes for `regexp', since it can now be a lisp expression; this = should be mentioned in the describing paragraph, using a similar = phrasing. The `literal' item should probably be moved next to `regexp', = since they are closely related. The paragraph on `eval' uses FORM, which is too generic; presumably it = should become EXPR too (but not STRING-EXPR, since it can be any rx = value).