From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Mon, 18 Dec 2023 19:12:31 -0800 Message-ID: References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <50920549-006c-0153-2471-02e41a3dada7@gutov.dev> <8c7cd429-bdc3-4fac-ad1c-fbad793bf1a0@gmail.com> <231ebcd1-ec30-0432-82e7-d63e11cd65f7@gutov.dev> <765D713E-9923-4F66-9044-9D69C104C9B0@gmail.com> <33fe5d61-5022-67c5-6a65-babde4fb7f91@gutov.dev> <92CACD38-9534-4A07-8DE3-CE8408272FB6@gmail.com> <59CC46F7-867E-4C74-83EC-49B41DF0FAB8@gmail.com> <2C418114-3773-4D62-90CB-E4C7F1B7D467@gmail.com> <029f6911-c4f5-1217-73bf-f57b7f941ae2@gutov.dev> <3beef57a-12c5-0ea0-d6d7-752d0aa4fb8d@gutov.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 66732@debbugs.gnu.org, Stefan Monnier , dominik@honnef.co To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 04:13:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFQXs-00032P-2u for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 04:13:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFQXV-0003Qp-G0; Mon, 18 Dec 2023 22:13:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFQXU-0003Qh-FI for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 22:13:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFQXU-0004TY-7F for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 22:13:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFQXW-0007mm-5B for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 22:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 03:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170295557429896 (code B ref 66732); Tue, 19 Dec 2023 03:13:02 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 19 Dec 2023 03:12:54 +0000 Original-Received: from localhost ([127.0.0.1]:33886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFQXO-0007m7-7z for submit@debbugs.gnu.org; Mon, 18 Dec 2023 22:12:54 -0500 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:59711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFQXL-0007lb-D1 for 66732@debbugs.gnu.org; Mon, 18 Dec 2023 22:12:52 -0500 Original-Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d3d0faf262so8492125ad.3 for <66732@debbugs.gnu.org>; Mon, 18 Dec 2023 19:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702955563; x=1703560363; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bf9fNkS3p04WQEZxdEjr38cT51mpD9iO/unpv3fvuR4=; b=XIeCa0SqpncZ9b0Z2Jli6sZDvA9l5OPSYEhG1zLFwXvLoK5xIeG4GsPEc3Pmw7BpDj ZflIRA9aGUE7cJZYvx9KUh1tTBWwOHtOwRF9yZOhjca/Ku6lpLdJYUHv1TLl5PxC0BaU D5fxqils9Omcp50zwO/rHhYTMeIMU864ZDFjyOGrksVExAuw3iTPdSQBWtr4Im4w6PIY 2dPh4mYTDVrYnHhABHVouUmuGl4AIiAvG0R/dxopQzHtzjBbFOddFvywHl9uyZtQX5Eg lS+znAvzJoalblDdDTwDU5vflAU2xJNRa9uW0InU264HHaM0tWsF8x+6LUVWAzIPEulo V8aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702955563; x=1703560363; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bf9fNkS3p04WQEZxdEjr38cT51mpD9iO/unpv3fvuR4=; b=dz5gVAUVWMNi+MXnBpu/OxKNW9d3VsH+dkObmHPo9v0gB+0scoSh7wOkADhGQBUPkY T3rfWXGw8M6dviz6Phikvi60aOit6T2+V2la/ZiV6yUIQpsicbfiXGwRFoDs5wrjUzfY B+QinBZi5cwrfJDmJIy3U5qcPE6VkMnBS60dxKhvRsj6tZ31TIskfNDkWq4IgjEjBPWH UIw0Sb+WNfDDW5yoG7RwK8k+7BgPHJsNWjDGg1dkfhsOdX9yr3cwNwNxbTFxXV8bqie3 MdvhvefU/eUCDYDm02QeEjOEL4ZD5X77IcjP/gfiWdOKGNe/EwIM/hcCH7Is8XT9VwwU M/hQ== X-Gm-Message-State: AOJu0YwdneuOPhgj1qWB4S3+QwztxKGP2GURbvAOd0UwFGtV/Mp07PZ3 uu52/QVmyyxeNUtmWi9SH+g= X-Google-Smtp-Source: AGHT+IF74Df31cEIjYF2chhVQZIf5KN9vIU+yU4Y5SwhW3w5mqPoySWi0U536ahjz2rZIf4ykOb4cg== X-Received: by 2002:a17:902:654a:b0:1d3:5b35:543a with SMTP id d10-20020a170902654a00b001d35b35543amr9615815pln.109.1702955563094; Mon, 18 Dec 2023 19:12:43 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id jj20-20020a170903049400b001cfbd3f38dcsm3346413plb.225.2023.12.18.19.12.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Dec 2023 19:12:42 -0800 (PST) In-Reply-To: <3beef57a-12c5-0ea0-d6d7-752d0aa4fb8d@gutov.dev> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276495 Archived-At: > On Dec 17, 2023, at 10:32 AM, Dmitry Gutov wrote: >=20 > On 17/12/2023 03:16, Yuan Fu wrote: >> +(defun treesit--pre-syntax-ppss (&rest _) >> + "Force reparse and consequently run all notifiers. >> + >> +Similar to font-lock, we want to update the `syntax' text >> +property before `syntax-ppss' starts working on the text." >> + (treesit--pre-redisplay) >> + nil) >=20 > This callback might be the best place to inform syntax-propertize = about the extended bounds which need to be re-parsed, so I'm not sure = about Stefan's suggestion to return nil here. >=20 > Even calling syntax-ppss-flush-cache wouldn't be a full solution, = because that wouldn't update the value of START in syntax-propertize. Makes sense. Then I think a treeist function that returns the latest = affected regions is in order? Yuan=