BUG: refreshing org buffer discards setting of local file variables

BUG: refreshing org buffer discards setting of local file variables

[Stephan Schmitt]

Hi,

in this little example file:

--8<---------------cut here---------------start------------->8---
# -*- org-tags-column: -40; -*-

#+TAGS: foo(f) bar(b)

* testing indentation of tag	   :foo:
--8<---------------cut here---------------end--------------->8---

the value of org-tags-column is set to -40 after loading as intended.
However, after refreshing the buffer setup with C-c C-c on the #+TAGS
line, the local value of org-tags-column is discarded and reset to the
global setting.

I would expect that local file variables are not touched be the
refreshing of the buffer setup.

Thanks,
	Stephan

GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.18.3), modified by Debian
Org-mode version 6.34trans (release_6.34c.102.ga2d94)

Re: BUG: refreshing org buffer discards setting of local file variables

[Carsten Dominik]

Hi Stefan,

On Mar 1, 2010, at 5:06 PM, Stephan Schmitt wrote:

> Hi,
>
> in this little example file:
>
> --8<---------------cut here---------------start------------->8---
> # -*- org-tags-column: -40; -*-
>
> #+TAGS: foo(f) bar(b)
>
> * testing indentation of tag	   :foo:
> --8<---------------cut here---------------end--------------->8---
>
> the value of org-tags-column is set to -40 after loading as intended.
> However, after refreshing the buffer setup with C-c C-c on the #+TAGS
> line, the local value of org-tags-column is discarded and reset to the
> global setting.
>
> I would expect that local file variables are not touched be the
> refreshing of the buffer setup.


Hmm, you are right, this is strange.  I am calling (org-mode) to  
refresh the setup, but hat does not seem to do the local variables.

Can I ask you to try the following patch, and to run with it for a  
week or two and then report back if that causes any problems at all?

Thanks.

- Carsten

diff --git a/lisp/org.el b/lisp/org.el
index fd906f0..d715c56 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16028,6 +16028,7 @@ This command does many different things,  
depending on co
  Also updates the keyword regular expressions."
    (interactive)
    (org-mode)
+  (hack-local-variables)
    (message "Org-mode restarted"))

  (defun org-kill-note-or-show-branches ()


>
> Thanks,
> 	Stephan
>
> GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.18.3),  
> modified by Debian
> Org-mode version 6.34trans (release_6.34c.102.ga2d94)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

Re: BUG: refreshing org buffer discards setting of local file variables

[Stephan Schmitt]

Sure... applied.  I'll report back soon.

Thx,
	Stephan

Also sprach Carsten Dominik:
> Hi Stefan,
> 
> On Mar 1, 2010, at 5:06 PM, Stephan Schmitt wrote:
> 
>> Hi,
>>
>> in this little example file:
>>
>> --8<---------------cut here---------------start------------->8---
>> # -*- org-tags-column: -40; -*-
>>
>> #+TAGS: foo(f) bar(b)
>>
>> * testing indentation of tag       :foo:
>> --8<---------------cut here---------------end--------------->8---
>>
>> the value of org-tags-column is set to -40 after loading as intended.
>> However, after refreshing the buffer setup with C-c C-c on the #+TAGS
>> line, the local value of org-tags-column is discarded and reset to the
>> global setting.
>>
>> I would expect that local file variables are not touched be the
>> refreshing of the buffer setup.
> 
> 
> Hmm, you are right, this is strange.  I am calling (org-mode) to refresh
> the setup, but hat does not seem to do the local variables.
> 
> Can I ask you to try the following patch, and to run with it for a week
> or two and then report back if that causes any problems at all?
> 
> Thanks.
> 
> - Carsten
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index fd906f0..d715c56 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16028,6 +16028,7 @@ This command does many different things,
> depending on co
>  Also updates the keyword regular expressions."
>    (interactive)
>    (org-mode)
> +  (hack-local-variables)
>    (message "Org-mode restarted"))
> 
>  (defun org-kill-note-or-show-branches ()
> 
> 
>>
>> Thanks,
>>     Stephan
>>
>> GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.18.3), modified
>> by Debian
>> Org-mode version 6.34trans (release_6.34c.102.ga2d94)
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 
> - Carsten
> 
> 
> 

-- 

--------------------------------------------

Stephan Schmitt

Neural Information Processing Group
Fac. IV - Electrical Engineering
        & Computer Science
Berlin University of Technology

Office: +49 30 - 314 24 158
Mobile: +49 179 - 593 84 48
Email:
  echo 'drmabuse at cs x tu-berlin x de' \
  | sed -e 's/ x /\./g' -e 's/ at /@/'

--------------------------------------------