From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Charles Choi Newsgroups: gmane.emacs.devel Subject: Re: Request to distribute Casual packages on NonGNU ELPA Date: Fri, 27 Sep 2024 11:12:01 -0700 Message-ID: References: <8B0830CA-6995-454C-BC5A-E4247E259CE9@gmail.com> <87a5fvsi0x.fsf@posteo.net> <877caxqejq.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20156"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Stefan Monnier , Philip Kaludercic To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 27 20:13:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1suFSr-00055c-CO for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Sep 2024 20:13:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1suFS3-0007bH-7X; Fri, 27 Sep 2024 14:12:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1suFS1-0007b6-NV for emacs-devel@gnu.org; Fri, 27 Sep 2024 14:12:21 -0400 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1suFRz-0007F7-Uk for emacs-devel@gnu.org; Fri, 27 Sep 2024 14:12:21 -0400 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-206bd1c6ccdso23868955ad.3 for ; Fri, 27 Sep 2024 11:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727460734; x=1728065534; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Wf1++ahspS+K8q1/Y++5FaYxs86+yBW3yV+qAoBMDCA=; b=lVjp3TnICxS14GSCSd2YTv2wipDET/9X9ThSNHWe9k60ACG45ZS1gGSIPKgTCU186E oJmNeZ/PgHX/c5TxqmTay5CNPULP8zk+yECT9sng61KNE5IQbMXagXzNIYwfUaneSDUa 8d9XWciRPVDxafN9vxJanIbTFNq/m2iaDGNqlDKWymnFOJEBkHNwNimqHqvOZi8xfUqT DrleMZRmkux2qpIE2yvUVEYV5dlMpu119vpQX9zXT93+bdS5N1fqaTRiYF2eCBcZEqEu 8s+xaG3DRjaBO7CPr1OvPuyhKM0Val+AHcbT858rfU+qyqUK9aLTqpixJ1qVl3DgRvid xxTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727460734; x=1728065534; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wf1++ahspS+K8q1/Y++5FaYxs86+yBW3yV+qAoBMDCA=; b=Jclt3YZ33Y5E+cjs1wxnhPKn71CNXC+4/jK+ZK7ECAkJvaSZubAb241/kidJw3pjYz 3YJJ4a5do1/RsFn4ET8q4RdihXPlkRjW0VFs+eNefExJdIwqKPNgzCzzscsqyjeF4JBv rx41i6NqbCFThtVtrzKm/oEx56f6i4WNHVcOANaUgawhvsCExW6XwW2hYI7ZJp0D9tEd LmT1JWekomriW1Lcq4DD1+BIKRt1CjkAiEjA532VjbKNNbLSVhyHIE2LKTxjegCvgHM9 Udnby2Zg9vFftAWUqhNzVUB3RkLJTAth/iY0j1o0B1Ouh06E3KjELv1rqE6mP8n1liLx NXpA== X-Gm-Message-State: AOJu0YyqSKxCJb356jDnkaP+v7XrdPjBqh5vnRb2PAmJNK51eNR1+q81 2ytsRn9Wgxzt3TP4k7Tv+jyw9qSPgwQG07hAZao6iMl0tCEe2kjWEkooWZjc X-Google-Smtp-Source: AGHT+IEWEU7pnbDH5jDcOHCLq+mO4IId3T3PGKZPwM5LyV9YUHOQeD+wQ6BKUwJc/U782Nfevx8wXA== X-Received: by 2002:a17:90a:bb8c:b0:2d3:c4d1:c95d with SMTP id 98e67ed59e1d1-2e0b8b18798mr4619770a91.21.1727460733523; Fri, 27 Sep 2024 11:12:13 -0700 (PDT) Original-Received: from smtpclient.apple (c-73-170-198-193.hsd1.ca.comcast.net. [73.170.198.193]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e0b6ca4a4esm2452136a91.31.2024.09.27.11.12.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Sep 2024 11:12:13 -0700 (PDT) In-Reply-To: <877caxqejq.fsf@posteo.net> X-Mailer: Apple Mail (2.3776.700.51.11.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=kickingvegas@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324144 Archived-At: Philip - Appreciate the input. My responses to your feedback below: > My first impression that the project seems a tad over-engineered for This was a deliberate decision on my part in undertaking the development = of Casual. As I am new to developing Elisp, I wanted to understand = better what it would be like to build a library of Elisp packages using = contemporary software engineering practices. > but I don't know where you got that information from? (referencing = ADM-3A) > https://www.emacswiki.org/emacs/EightyColumnRule e.g. says this goes > back to punch cards (which is the story I had in my head). My reference to the ADM-3A was written "off the cuff", as that was one = of the first terminals I had worked with. I will amend to reference the = 80 column rule. > Regarding casual-lib.el: Do you actually need Emacs 29? Package lint > seems to be fine with lowering the version to Emacs 25. In specifying requirements, I've taken a more conservative tack of = listing a configuration that I am able to test, in this case, Emacs 29 = running on macOS and Linux. I do not have the time nor resources to = fully test older versions of Emacs and associated packages, much less = test on different platforms. As I am new to Elisp publishing, I was and still am reluctant to trust = lint tools to verify behavior on older versions of Emacs and associated = packages as it would commit me to supporting them. Is lint sufficient = enough for verification of correct behavior on lower versions of Emacs? = What happens when it isn't? > + :group 'casual) ;please add a `defgroup' before = referring to it! You don't need to specify the :group afterwards. Will amend. > +(defun casual-lib-display-line-numbers-mode-p () ;why do you have = this as a predicate? For reasons I do not understand or have clear enough knowledge about, I = could not write an expression to pass to a Transient macro, but instead = has to pass a function symbol to get working code. Hence making a = predicate here. > + (not transient--stack))) ;btw. are you allowed to = use this internal variable? This was guidance provided by Jonas Bernoulli, maintainer of Transient. = https://github.com/magit/transient/discussions/290 > + :key "C-q" ;IIUC this is the binding that = closes your transient buffer? Could this be rebound to the more = conventional "q"? Initially I did. Guidance from Jonas Bernoulli argued that Transient = convention is to use C-q as detailed in = https://magit.vc/manual/transient/FAQ.html#Why-does-q-not-quit-popups-anym= ore_003f-1 > + (casual-lib-customize-casual-lib-hide-navigation)) ;why not just = inline the above definition? Likely over-modularization on my part. Will audit all Casual packages = and if this usage is singular, will inline. > +awk '/Version: / {print $3}' $1 Nice in that I don't have to make a call to grep. Will verify and amend. Thanks for taking the time to review. Regards - Charles =E2=80=94 Charles Y. Choi, Ph.D. kickingvegas@gmail.com