From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61043: 30.0.50; `json-ts-mode': invalid font lock rule Date: Wed, 25 Jan 2023 14:14:11 +0100 Message-ID: References: <87lelrwv7f.fsf@masteringemacs.org> <87cz73vzpi.fsf@masteringemacs.org> <87o7qm95q8.fsf@thornhill.no> <87ilgu3jdb.fsf@masteringemacs.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29326"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61043@debbugs.gnu.org, Dmitry Gutov To: Mickey Petersen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 14:16:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKfdT-0007Vu-0a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 14:16:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKfdE-0004qV-IV; Wed, 25 Jan 2023 08:16:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKfdD-0004ns-5b for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 08:16:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKfdC-0002P6-TN for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 08:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKfdC-0007Ym-BE for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 08:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61043 X-GNU-PR-Package: emacs Original-Received: via spool by 61043-submit@debbugs.gnu.org id=B61043.167465250528966 (code B ref 61043); Wed, 25 Jan 2023 13:16:02 +0000 Original-Received: (at 61043) by debbugs.gnu.org; 25 Jan 2023 13:15:05 +0000 Original-Received: from localhost ([127.0.0.1]:58595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKfcG-0007X7-Tf for submit@debbugs.gnu.org; Wed, 25 Jan 2023 08:15:05 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]:12527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKfcD-0007WL-0M for 61043@debbugs.gnu.org; Wed, 25 Jan 2023 08:15:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674652498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9hSN+GGj2cTIp/UDC7fIqRX8r58VKEfZ7FPECV4IpX8=; b=LOEyQBwlpl20XbMjOT46oYyqdzqqX4QBL43yIUkB1fzQm10eK2o5fjwRbTALUHRHKdkOhe JPT97gBkLOT5P3kbUQuSp4jXzxktUuZ0pFD737u62yk6ohXjUgWOzNfyMbynalmfVPTcc7 LqKAC8G+nyjlQo5CuVaQYrOuiF/UfVA+YIiOCW44BpJz+tXZ1XW2Pzm2/dz3I65gj77raJ 3v9uHoOQkweXd01I6CwP1tw7rcFNx72d0T2HhOU33E3csk2NJhwTrwfNOa02SwvnkMwys0 J6VSE8Bej7+9PogibFtXrR9DTRogMlS3QDV/5P/fKyPfJc0Gw3DB/BmmnQy/Tw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <87ilgu3jdb.fsf@masteringemacs.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254123 Archived-At: On 25 January 2023 13:09:08 CET, Mickey Petersen wrote: > >Theodor Thornhill writes: > >> Mickey Petersen writes: >> >>> Dmitry Gutov writes: >>> >>>> On 24/01/2023 22:09, Mickey Petersen wrote: >>>>> There's a comment font lock rule in `json-ts-mode'=2E However, that = is >>>>> illegal and againt the JSON spec, and indeed the search query fails >>>>> because `comment' is not a valid node type=2E >>>> >>>> When you say it fails, how does that look to you? >>>> >>>> Here's an example of a JSON file (or, more accurately, a JSON-superse= t >>>> file) with comments: >>>> https://raw=2Egithubusercontent=2Ecom/huytd/vscode-espresso-tutti/mas= ter/themes/Espresso%20Tutti-color-theme=2Ejson >>>> >>>> The JSON tree-sitter grammar seems to parse them correctly as comment= s >>>> ("comment" node type), and json-ts-mode highlights them as comments >>>> correctly as a result=2E >>> >>> It may well be my JSON grammar file that is different then=2E Which is >>> perhaps even worse: it is easy to find yourself with one of two >>> versions=2E >> >> >> See [0], it seems comment is supported if I'm not mistaken=2E >> >> Theo >> >> [0]: https://github=2Ecom/tree-sitter/tree-sitter-json/blob/master/gram= mar=2Ejs#L6 > >I understand=2E But nevertheless, I do get an error for that rule as it's= missing (for some inexplicable reason=2E) > >It would be better if the font lock machinery disables/ignores the rule i= f it encounters a validation error=2E That way it'll gracefully degrade=2E > Yeah but this touches a deeper point, imo=2E There's no good way to version this=2E Perhaps when we stop committing tre= esit stuff to emacs-29 we create a list of verified git commit hashes that = are supported by the mode? That way we at least have _some_ info=2E What do you think? Theo