From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75310: Eliminate obsolete alias warning Date: Sat, 4 Jan 2025 11:31:44 -0800 Message-ID: References: <86h66ggl6a.fsf@gnu.org> <02134785-ad5d-8b9a-4b51-64e8d466b038@mavit.org.uk> <86bjwogewx.fsf@gnu.org> <868qrrhq8h.fsf@gnu.org> <77CBB14F-094D-48DA-A7D1-ED9E1F43DAD3@gmail.com> <86a5c7f0dn.fsf@gnu.org> <94CBEFD3-6E58-4056-B73C-B5FC6AB6E1B9@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17584"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75310-done@debbugs.gnu.org, Peter Oliver To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 20:33:32 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU9tr-0004RU-PU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 20:33:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU9tR-0000xT-2S; Sat, 04 Jan 2025 14:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU9tP-0000wo-28 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:33:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU9tO-0006lb-Pb for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=/OSCLqZgLsrJ/34H7EiNJO/WC/JKE2FntO+oYZJRNYw=; b=kLRHrBxDS8zgMTbPKFHcMGYRfNF6TkHS201qct/3Mj1c7+xGZ1DqyV2K/zkPGSkyhZKQFnFD1frrPJdnWpPGs3xt85u52q+/RsjUVV6amr0vpBhwdtBscbmxQEKFjf2b/d5BiTuGOSZ6XHJVu6by/LPmETMsx4JnMf27peJJWYQnu7Ky/L4vriDaUvss887bipL6a3Npb08m/Gmx2G4LlyqfOCyQS2PlkSWLD4ncvy3yYnBziJxET5IvwI/15yYM+w2ajAqOF8yMb6x9Yb1WpOXMWbne2NjsdgOnxC0py+Fsm6qDF6nu26Ha/ZOUHLb/W60age6wCgjxvcLnvEgB9A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU9tO-0000j5-Jg for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:33:02 -0500 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 19:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 75310 X-GNU-PR-Package: emacs Mail-Followup-To: 75310@debbugs.gnu.org, casouri@gmail.com, p.d.oliver@mavit.org.uk Original-Received: via spool by 75310-done@debbugs.gnu.org id=D75310.17360191262694 (code D ref 75310); Sat, 04 Jan 2025 19:33:02 +0000 Original-Received: (at 75310-done) by debbugs.gnu.org; 4 Jan 2025 19:32:06 +0000 Original-Received: from localhost ([127.0.0.1]:57458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU9sT-0000hN-GV for submit@debbugs.gnu.org; Sat, 04 Jan 2025 14:32:05 -0500 Original-Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:49623) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU9sQ-0000ga-OX for 75310-done@debbugs.gnu.org; Sat, 04 Jan 2025 14:32:03 -0500 Original-Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2166f1e589cso226674295ad.3 for <75310-done@debbugs.gnu.org>; Sat, 04 Jan 2025 11:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736019117; x=1736623917; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/OSCLqZgLsrJ/34H7EiNJO/WC/JKE2FntO+oYZJRNYw=; b=AcessIpp9mTzzArnqpdwLdeKcINIDro/On6aGUXZaQApp6kaqFRyXXAWldvn2AEaM4 ENHB2W+fnLGLDc6WYbpBk3G94hlXMDpwunuPKvQtezmp/58M2VgDDcYIIkd6JIqJGX4k B581G38uPTfP30CGWFhwEsi5FriOZ09hx5YQmynXSg27vyNd6x48sIHgQQjmmyrRxhmK 6PDU7EaCRY5lgTTPT8OvlPtAMlPO0+VpKenKt/ziixnu445rsQ48vUsVYL93+8lGXfkK 0mK7wFeFd4ugIZ4h0OapmQc+C8aXKSYLRlmXTq9DcfqZYMHR3r7a/DNcfzwprZ5MngwC p4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736019117; x=1736623917; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OSCLqZgLsrJ/34H7EiNJO/WC/JKE2FntO+oYZJRNYw=; b=EjWhULjm7HT9+4Mi5iM+qGdPtaUZA/ElZRkj943Pz+da8pVD+R8Nt1WFD7H0hf1qH5 5qdQWrsRmgnPUHqMZ133C5YoQcqFw7G3ykl6YXin1iDIRNBQkhOy9F2MxbufkN7YQL3c 83xRAw3o50rxvUcMs27sHXJGOxJyqcNPxRFAmYLk7/0yFuktbuCTTB94NiyMhvfooSx/ QvyMUetvoFfD0jh4CvA0gi8SCfGRhCuZkko1LiV7pcbWj28VgSQQXaslDrfwN/5j4pJQ aLIvBZQCb/Y8aukrTYGqrwIYv6X5lQ/Y5H6h1hOYeDx3w3z0lbI6DYy+JH+NODOgQjeB oUhQ== X-Forwarded-Encrypted: i=1; AJvYcCXkO9dQJGAsbHoNQnsu0g6kDRcG0MTg/yIpWYGbP/bmkYEPPYn96hFbL0xZtviFjFLPu67iE13RrMWM@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywb0ec6VE/6NzpRcndrD0pcwxFwkOQsOib/pkN0Lrjgcm20/dCx SOfsBtTU4q4KHtVuI7vDD9ruq0wgTgN1OpUiV1tRNK10kMb2lgqyqAWnLQ== X-Gm-Gg: ASbGnctEWxOwyVd3ltUXYG6bj6rnfWDK3GFJ0bouVy/ijiYwDcEzwCpUUhhyfMis9xN ihMsEiP1u4zgNlG4n0ruhKNH2ekcIVf+WfCItKDPeHlHHriLHy5nWBQQfXGyw39A1WFhu5H1ZNM VlgUVWxYtUZ+rBkyiUi2m/69iz94H5sSPeShNbaIsU3nTEuKm5WoQiA0Eevtg72R7yCVvlxNyoD Tej0D0ABKlanNrSsXgkZoVfr55HXbvH4L3DCrlkclUNbj2kUwHeH1OraUH1OdecLhgqN4zHqAr4 iIQ7 X-Google-Smtp-Source: AGHT+IGdI4Wx1NukMq9giULr4znzws3c2zjgOTHSHqOSKSnYTzQ5CUIswpWBs+fl2eEZFn7q2W8cGg== X-Received: by 2002:a05:6a21:e96:b0:1e1:ae4a:1d4b with SMTP id adf61e73a8af0-1e5e07eff56mr82837664637.34.1736019116638; Sat, 04 Jan 2025 11:31:56 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:c496:8cdf:4c5d:3617]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad81644csm28291274b3a.33.2025.01.04.11.31.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Jan 2025 11:31:55 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298461 Archived-At: > On Jan 4, 2025, at 11:27=E2=80=AFAM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Jan 4, 2025, at 11:26=E2=80=AFAM, Yuan Fu = wrote: >>=20 >>=20 >>=20 >>> On Jan 4, 2025, at 12:29=E2=80=AFAM, Eli Zaretskii = wrote: >>>=20 >>>> From: Yuan Fu >>>> Date: Fri, 3 Jan 2025 23:33:25 -0800 >>>> Cc: Peter Oliver , >>>> 75310@debbugs.gnu.org >>>>=20 >>>>> On Jan 3, 2025, at 7:27=E2=80=AFAM, Eli Zaretskii = wrote: >>>>>=20 >>>>>> Date: Fri, 3 Jan 2025 14:47:53 +0000 (GMT) >>>>>> From: Peter Oliver >>>>>> cc: 75310@debbugs.gnu.org >>>>>>=20 >>>>>> On Fri, 3 Jan 2025, Eli Zaretskii wrote: >>>>>>=20 >>>>>>> IOW, can you show a minimal recipe for reproducing the problem, >>>>>>> starting from "emacs -Q"? >>>>>>=20 >>>>>> $ src/emacs -Q --batch --eval "(progn (message emacs-version) = (require 'cl) (require 'treesit))" >>>>>> 31.0.50 >>>>>> Package cl is deprecated >>>>>> lisp/treesit.el: Warning: =E2=80=98loop=E2=80=99 is an obsolete = alias (as of 27.1); use =E2=80=98cl-loop=E2=80=99 instead. >>>>>=20 >>>>> Thanks. >>>>>=20 >>>>> Yuan, I think it would be good to rename 'loop' there to some = other >>>>> name, do you agree? >>>>=20 >>>> I would definitely agree. I=E2=80=99ve always used cl-loop (and now = I try to not use it for new code). The only instance of =E2=80=9Cloop=E2=80= =9D I can find in treesit.el is in a named-let in = treesit-transpose-sexps wriiten by Theo, and it=E2=80=99s not the CL = loop but a local function defined by named-let. I wanted to rewrite it = so it doesn=E2=80=99t use named-let because it=E2=80=99s not very = readable, but tbh I haven=E2=80=99t find the time to understand that = function well enough to rewrite it (because it=E2=80=99s not very = readable :-) >>>>=20 >>>> It could be that only I can=E2=80=99t understand it, but code = should be simple enough that even I can understand ;-) >>>=20 >>> Renaming the symbol is easy, and doesn't require you to understand = the >>> code completely. We don't have to use cl-loop. >>=20 >> Ah right, duh :-) Though I renamed the symbol and still gets the = deprecation message. There=E2=80=99s no other =E2=80=9Cloop=E2=80=9D in = treesit.el, only cl-loop. Could you maybe take a look? >=20 > Never mind, the deprecation message is from requiring cl. The obsolete = alias error is fixed by renaming the symbol. >=20 > Yuan Never mind =C3=97 2 :-) Juri just modified treesit-transpose-sexp so it = doesn=E2=80=99t contain =E2=80=9Cloop=E2=80=9D anymore. Yuan=