all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Adam Spiers <orgmode@adamspiers.org>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: BUG: org-open-file fails with multiple %s in mailcap entry
Date: Thu, 3 Jan 2008 13:51:37 +0100	[thread overview]
Message-ID: <FBBA70F7-9412-4D35-9449-43BE9A742364@gmail.com> (raw)
In-Reply-To: <20080103124101.GE18716@atlantic.linksys.moosehall>


On Jan 3, 2008, at 1:41 PM, Adam Spiers wrote:

> On Thu, Jan 03, 2008 at 01:33:16PM +0100, Carsten Dominik wrote:
>> On Dec 22, 2007, at 1:30 PM, Adam Spiers wrote:
>>> The use of format in org-open-file assumes that there will only ever
>>> be a single '%s' in a mailcap entry:
>>>
>>>  (cond
>>>   ((and (stringp cmd) (not (string-match "^\\s-*$" cmd)))
>>>    ;; Remove quotes around the file name - we'll use
>>>   shell-quote-argument.
>>>    (if (string-match "['\"]%s['\"]" cmd)
>>>      (setq cmd (replace-match "%s" t t cmd)))
>>>    (setq cmd (format cmd (shell-quote-argument file)))
>>>
>>> However this is not necessarily the case, e.g. I have
>
> [snipped]
>
>> What are you proposing?
>
> Simply that every occurrence of '%s' be replaced by the file, not just
> the first one.

Done for 5.18, thanks.

- Carsten

      reply	other threads:[~2008-01-03 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22 12:30 BUG: org-open-file fails with multiple %s in mailcap entry Adam Spiers
2008-01-03 12:33 ` Carsten Dominik
2008-01-03 12:41   ` Adam Spiers
2008-01-03 12:51     ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FBBA70F7-9412-4D35-9449-43BE9A742364@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=orgmode@adamspiers.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.