From: Carsten Dominik <carsten.dominik@gmail.com>
To: "Joe Vornehm Jr." <joe.vornehm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix regexps in org-clock.el
Date: Sat, 31 Dec 2011 09:06:34 +0100 [thread overview]
Message-ID: <FB139111-46DA-439C-BE60-4C7A03068874@gmail.com> (raw)
In-Reply-To: <4EFEBAEB.2090808@gmail.com>
Applied, thanks.
But I have removed the regexp-quote again, because org-clock-string
is used in many more regexps, and a more complete patch would be
needed to make this change meaningful.
- Carsten
On 31.12.2011, at 08:34, Joe Vornehm Jr. wrote:
> I have been seeing persistent errors of "Cannot restart clock because task does not contain unfinished clock" when auto-resuming a saved (persistent) clock. I believe I've tracked the error down to an extraneous space in a regexp ("^[ \t]* " when it should be "^[ \t]*").
>
> This patch fixes the issue for me (in `org-clock-in'), and it makes the same change in `org-clock-find-position'. I've tested this briefly and it works for me; nothing about clocking-in behavior seems to break, and persistent clocks work now.
>
> I've also wrapped `regexp-quote' around instances where org-clock-string is used to build a regexp, in case someone puts funny characters in their org-clock-string.
>
> Hopefully, the patch is attached correctly and Thunderbird didn't mangle it.
>
> Cheers!
> Joe V.
>
>
> <0001-Fix-regexps-in-org-clock.el.patch>
next prev parent reply other threads:[~2011-12-31 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-31 7:34 [PATCH] Fix regexps in org-clock.el Joe Vornehm Jr.
2011-12-31 8:06 ` Carsten Dominik [this message]
2011-12-31 23:21 ` Joe Vornehm Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FB139111-46DA-439C-BE60-4C7A03068874@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=joe.vornehm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.