From: Andrii Kolomoiets <andreyk.mad@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: 40200@debbugs.gnu.org, 28872@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#28872: [PATCH] Fix NS frame resizing issues (bug#40200, bug#28872)
Date: Thu, 26 Mar 2020 19:35:20 +0200 [thread overview]
Message-ID: <F9E93A76-AC87-4F82-9446-C4C2DFDDBFF4@gmail.com> (raw)
In-Reply-To: <20200325222841.GA60879@breton.holly.idiocy.org>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On 26 Mar 2020, at 00:28, Alan Third <alan@idiocy.org> wrote:
>
> * src/nsmenu.m (update_frame_tool_bar): Remove reference to
> updateFrameSize.
> * src/nsterm.h: Remove definition of updateFrameSize.
> * src/nsterm.m (ns_set_window_size):
> (ns_set_undecorated):
> ([EmacsView windowDidResize:]):
> ([EmacsView windowDidExitFullScreen]):
> (ns_judge_scroll_bars): Remove references to updateFrameSize.
> ([EmacsView dealloc]): Unset resize notification.
> ([EmacsView updateFrameSize:]): Remove function.
> ([EmacsView viewWillStartLiveResize]):
> ([EmacsView viewDidResize]): New functions.
> ([EmacsView initFrameFromEmacs:]): Set up resize notification.
> ([EmacsView toggleFullScreen:]): Set frame to the size of the
> contentview, not the whole window, and remove reference to
> updateFrameSize.
Thanks, Alan!
I've installed this patch and will watch for any issues.
For now Emacs is crashing on fullscreen frame deletion:
1. emacs -Q
2. C-x 5 2
3. F11
4. C-x 5 0
Backtrace from macos problem reporter is attached.
[-- Attachment #2: emacs-crash-fs-close.txt --]
[-- Type: text/plain, Size: 6332 bytes --]
OS Version: Mac OS X 10.15.3 (19D76)
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGABRT)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000020
Exception Note: EXC_CORPSE_NOTIFY
VM Regions Near 0x20:
-->
__TEXT 000000010254b000-0000000102792000 [ 2332K] r-x/r-x SM=COW /Users/USER/*/Emacs.app/Contents/MacOS/Emacs
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff6d2097fa __pthread_kill + 10
1 libsystem_pthread.dylib 0x00007fff6d2c6bc1 pthread_kill + 432
2 libsystem_c.dylib 0x00007fff6d1203a2 raise + 26
3 org.gnu.Emacs 0x0000000102751769 terminate_due_to_signal + 153 (emacs.c:404)
4 org.gnu.Emacs 0x00000001027520ab emacs_abort + 15
5 org.gnu.Emacs 0x0000000102719e70 ns_term_shutdown + 80 (lisp.h:1586)
6 org.gnu.Emacs 0x00000001026097f4 shut_down_emacs + 340 (emacs.c:2462)
7 org.gnu.Emacs 0x0000000102751736 terminate_due_to_signal + 102 (emacs.c:385)
8 org.gnu.Emacs 0x0000000102629fce handle_fatal_signal + 14
9 org.gnu.Emacs 0x000000010262a051 deliver_thread_signal + 129
10 org.gnu.Emacs 0x0000000102628a09 deliver_fatal_thread_signal + 9
11 org.gnu.Emacs 0x000000010262a108 handle_sigsegv + 168
12 libsystem_platform.dylib 0x00007fff6d2bb42d _sigtramp + 29
13 ??? 000000000000000000 0 + 0
14 com.apple.CoreFoundation 0x00007fff35a1435f __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
15 com.apple.CoreFoundation 0x00007fff35a142f3 ___CFXRegistrationPost1_block_invoke + 63
16 com.apple.CoreFoundation 0x00007fff35a14268 _CFXRegistrationPost1 + 372
17 com.apple.CoreFoundation 0x00007fff35a13ebe ___CFXNotificationPost_block_invoke + 97
18 com.apple.CoreFoundation 0x00007fff359e37e2 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1575
19 com.apple.CoreFoundation 0x00007fff359e2c82 _CFXNotificationPost + 1351
20 com.apple.AppKit 0x00007fff32c23719 -[NSView _postFrameChangeNotification] + 304
21 com.apple.AppKit 0x00007fff32c1c1a9 -[NSView setFrameSize:] + 2917
22 com.apple.AppKit 0x00007fff32c2dca2 -[NSView setFrame:] + 423
23 org.gnu.Emacs 0x000000010272027c -[EmacsView setFrame:] + 60 (nsterm.m:7346)
24 com.apple.AppKit 0x00007fff32c412ee -[NSView resizeWithOldSuperviewSize:] + 1193
25 com.apple.AppKit 0x00007fff32c40a13 -[NSView resizeSubviewsWithOldSize:] + 525
26 com.apple.AppKit 0x00007fff32c1bcf6 -[NSView setFrameSize:] + 1714
27 com.apple.AppKit 0x00007fff32c2dca2 -[NSView setFrame:] + 423
28 com.apple.AppKit 0x00007fff32c3bd38 -[NSThemeFrame setStyleMask:] + 874
29 com.apple.AppKit 0x00007fff32c3b89e __25-[NSWindow setStyleMask:]_block_invoke + 1939
30 com.apple.AppKit 0x00007fff32c3b0b3 NSPerformVisuallyAtomicChange + 132
31 com.apple.AppKit 0x00007fff32c3afbc -[NSWindow setStyleMask:] + 184
32 com.apple.AppKit 0x00007fff3328d23d -[_NSWindowExitFullScreenTransitionController setupWindowForAfterFullScreenExit] + 106
33 com.apple.AppKit 0x00007fff33509740 __46-[_NSExitFullScreenTransitionController start]_block_invoke_3 + 57
34 libdispatch.dylib 0x00007fff6d068583 _dispatch_call_block_and_release + 12
35 libdispatch.dylib 0x00007fff6d06950e _dispatch_client_callout + 8
36 libdispatch.dylib 0x00007fff6d074bc4 _dispatch_main_queue_callback_4CF + 1105
37 com.apple.CoreFoundation 0x00007fff35a5de00 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
38 com.apple.CoreFoundation 0x00007fff35a1db8a __CFRunLoopRun + 2370
39 com.apple.CoreFoundation 0x00007fff35a1cbd3 CFRunLoopRunSpecific + 499
40 com.apple.HIToolbox 0x00007fff3457265d RunCurrentEventLoopInMode + 292
41 com.apple.HIToolbox 0x00007fff345722a9 ReceiveNextEventCommon + 356
42 com.apple.HIToolbox 0x00007fff34572127 _BlockUntilNextEventMatchingListInModeWithFilter + 64
43 com.apple.AppKit 0x00007fff32be2ba4 _DPSNextEvent + 990
44 com.apple.AppKit 0x00007fff32be1380 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352
45 com.apple.AppKit 0x00007fff32bd309e -[NSApplication run] + 658
46 org.gnu.Emacs 0x000000010271a02d -[EmacsApp run] + 333 (nsterm.m:5644)
47 org.gnu.Emacs 0x0000000102726bcc ns_read_socket + 668 (nsterm.m:4598)
48 org.gnu.Emacs 0x0000000102617035 gobble_input + 245 (keyboard.c:6887)
49 org.gnu.Emacs 0x000000010261a01a detect_input_pending + 250 (lisp.h:1272)
50 org.gnu.Emacs 0x00000001026e23ea wait_reading_process_output + 3194 (process.c:5491)
51 org.gnu.Emacs 0x00000001025525e8 sit_for + 312 (dispnew.c:6055)
52 org.gnu.Emacs 0x0000000102611f1a read_char + 5210 (keyboard.c:2738)
53 org.gnu.Emacs 0x000000010260ef2a read_key_sequence + 1722 (keyboard.c:9549)
54 org.gnu.Emacs 0x000000010260d72c command_loop_1 + 1340 (keyboard.c:1350)
55 org.gnu.Emacs 0x00000001026943d7 internal_condition_case + 263 (eval.c:1357)
56 org.gnu.Emacs 0x000000010261d740 command_loop_2 + 48 (lisp.h:1272)
57 org.gnu.Emacs 0x0000000102693beb internal_catch + 267 (eval.c:1118)
58 org.gnu.Emacs 0x0000000102751b35 command_loop.cold.1 + 69
59 org.gnu.Emacs 0x000000010260c7f3 command_loop + 131
60 org.gnu.Emacs 0x000000010260c723 recursive_edit_1 + 115 (keyboard.c:714)
61 org.gnu.Emacs 0x000000010260c97b Frecursive_edit + 347 (keyboard.c:787)
62 org.gnu.Emacs 0x000000010260b561 main + 7425 (emacs.c:2036)
63 libdyld.dylib 0x00007fff6d0c27fd start + 1
next prev parent reply other threads:[~2020-03-26 17:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 18:13 bug#40200: 28.0.50; NS: text drawing glitches in maximized frame with frame-inhibit-implied-resize Andrii Kolomoiets
2020-03-23 19:22 ` Eli Zaretskii
2020-03-23 19:47 ` Andrii Kolomoiets
2020-03-23 23:54 ` Alan Third
2020-03-25 22:28 ` bug#40200: [PATCH] Fix NS frame resizing issues (bug#40200, bug#28872) Alan Third
2020-03-26 17:35 ` Andrii Kolomoiets [this message]
2020-03-26 21:21 ` bug#28872: [PATCH v2] " Alan Third
2020-03-27 9:45 ` Andrii Kolomoiets
2020-03-27 13:22 ` Andrii Kolomoiets
2020-03-28 1:56 ` Alan Third
2020-04-04 14:17 ` bug#40200: [PATCH v3] " Alan Third
2020-04-06 6:57 ` Andrii Kolomoiets
2020-04-06 18:44 ` bug#28872: [PATCH v4] " Alan Third
2020-04-07 8:14 ` bug#40200: " Andrii Kolomoiets
2020-04-16 18:24 ` bug#28872: " Alan Third
2020-04-18 1:52 ` bug#40200: " HaiJun Zhang
2020-04-18 12:07 ` Alan Third
2020-04-18 14:12 ` HaiJun Zhang
2020-04-18 15:26 ` Alan Third
2020-04-19 1:49 ` HaiJun Zhang
2020-05-03 16:26 ` Alan Third
2020-05-03 17:13 ` Filipp Gunbin
2020-05-03 18:41 ` Alan Third
2020-05-03 19:49 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9E93A76-AC87-4F82-9446-C4C2DFDDBFF4@gmail.com \
--to=andreyk.mad@gmail.com \
--cc=28872@debbugs.gnu.org \
--cc=40200@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.