From: "Wedler, Christoph" <christoph.wedler@sap.com>
To: Dmitry Gutov <dgutov@yandex.ru>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: Clarification needed: syntax-propertize vs font-lock-syntax-table
Date: Mon, 23 Nov 2015 17:05:20 +0000 [thread overview]
Message-ID: <F9C2521BBF380A4A97379009991555E699357628@DEWDFEMB17C.global.corp.sap> (raw)
In-Reply-To: <564F68C4.1020207@yandex.ru>
>> And syntax-propertize should be called at more places. Currently, doing
>> it lazily does not really work, as it is not called when needed.
> You'll have to be more specific.
Well, I realized that (with Emacs-24.4) the imenu list in antlr-mode
wasn't correctly before I put (syntax-propertize (point-max)) into
antlr-imenu-create-index-function. I could imagine similar things in
other modes.
I have not seen other issues, but I do use font-lock (which also calls
syntax-propertize), as it is the default. I could imagine that issues
could appear for people who have switched off font-lock. (Needs to be
tested.)
>> That is why js-mode calls (syntax-propertize (point-max)) at the end
>>
> Y Not anymore, it doesn't.
You are right...
>> (and I will do the same in antlr-mode).
> I'd prefer if you didn't.
I probably define a variable for that which will be t for Emacs below
emacs-25.x and nil with the next release.
>> My other question was concerning (nth 9 ppss), i.e. the list of open
>> parentheses is very useful to have (and its also used in syntax.el
>> itself) -> I would like to have this to be official in the lisp
>> docstring as well - in src/syntax.c, we have
> I thought that's exactly what you meant by documenting the 9th element.
> Were there any other options?
The other documentation request was for font-lock syntax-table as being
"syntax-ppss-compatible" (as you put it nicely).
> I'm not the guy who can say if it's okay or not. Probably is. But it
> would be sad if after that we choose a way to adapt syntax-ppss for the
> multiple-modes case, and it will require saving a more complex structure
> in the 9th element.
Agreed. How about a function like
(defun syntax-ppss-open-list-positions (ppss)
"Get all syntactically open list position found in a syntactic scan.
PPSS is a scan state, as returned by `parse-partial-sexp' or `syntax-ppss'.
The start position of the outermost list comes first."
(nth 9 ppss))
This function needs to be changed if the internal structure of (nth 9
ppss) is changed.
>> In the case of antlr-mode (grammar with actions), it could be done as
>> long as it does not break the calulation of the "inner-mode-chunk-end",
>> e.g, with Python actions
>>
>> rule: "KEYWORD" { do_something { } # do it };
>>
>> the action ends with the final "}" (even though a naive Python-like
>> syntax-propertization would think of it as part of a comment)
> Yes, of course we should try to make it break as few things as possible.
> Not sure if I could comment on this in any more detail.
We might need something (an extra syntax flag?) which makes it easy to
"rewind" the ppss such that
(equal (syntax-ppss inner-mode-end-position)
(syntax-ppss inner-mode-start-position))
next prev parent reply other threads:[~2015-11-23 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 18:06 Clarification needed: syntax-propertize vs font-lock-syntax-table Wedler, Christoph
2015-11-18 18:37 ` Dmitry Gutov
2015-11-20 18:24 ` Wedler, Christoph
2015-11-20 18:39 ` Dmitry Gutov
2015-11-23 17:05 ` Wedler, Christoph [this message]
2015-11-23 19:01 ` Dmitry Gutov
2015-11-24 8:58 ` Wedler, Christoph
2015-11-24 11:35 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9C2521BBF380A4A97379009991555E699357628@DEWDFEMB17C.global.corp.sap \
--to=christoph.wedler@sap.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.