From: Adrian Robert <adrian.b.robert@gmail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 3474@emacsbugs.donarmstrong.com
Subject: bug#3474: 23.0.94; Emacs.app crashes during typing (with patch)
Date: Mon, 8 Jun 2009 15:28:11 +0700 [thread overview]
Message-ID: <F9AA25FB-0411-4FAD-B4CE-D2B381B8DCE2@gmail.com> (raw)
In-Reply-To: <87vdn7ogt2.fsf@cyd.mit.edu>
On Jun 8, 2009, at 4:49 AM, Chong Yidong wrote:
> Adrian, could you review this patch?
It looks OK to me, I'm checking it in. Other parts of that function
do similar null checks and don't behave specially if they can't set it.
-Adrian
>
>
> Wolfgang Lux <wolfgang.lux@gmail.com> wrote:
>
>> I've encountered a few crashes in Emacs.app, which happened while
>> typing when Emacs was a bit busy. It turns out that these crashes
>> were due to an omitted null-pointer check at line 4165 of keyboard.c
>> in function kbd_buffer_get_event(). The attached patch fixes this
>> problem along with a second omitted null-pointer check in line 4323
>> of the same function.
>
> --- src/keyboard.c.~1.1005.~ 2009-05-28 17:08:04.000000000 +0200
> +++ src/keyboard.c 2009-06-02 13:39:39.000000000 +0200
> @@ -4162,7 +4162,8 @@
> else
> obj = Fcons (intern ("ns-unput-working-text"), Qnil);
> kbd_fetch_ptr = event + 1;
> - *used_mouse_menu = 1;
> + if (used_mouse_menu)
> + *used_mouse_menu = 1;
> }
> #endif
>
> @@ -4319,7 +4320,8 @@
> #endif
> #ifdef HAVE_NS
> /* certain system events are non-key events */
> - if (event->kind == NS_NONKEY_EVENT)
> + if (used_mouse_menu
> + && event->kind == NS_NONKEY_EVENT)
> *used_mouse_menu = 1;
> #endif
>
next prev parent reply other threads:[~2009-06-08 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 21:49 bug#3474: 23.0.94; Emacs.app crashes during typing (with patch) Chong Yidong
2009-06-08 8:28 ` Adrian Robert [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-05 11:57 Wolfgang Lux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9AA25FB-0411-4FAD-B4CE-D2B381B8DCE2@gmail.com \
--to=adrian.b.robert@gmail.com \
--cc=3474@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.