From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Date: Tue, 11 Sep 2012 07:24:08 -0700 Message-ID: References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1347373538 28068 80.91.229.3 (11 Sep 2012 14:25:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2012 14:25:38 +0000 (UTC) Cc: 12345@debbugs.gnu.org To: "'Bastien'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 11 16:25:40 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TBRPG-0005gV-DY for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 16:25:38 +0200 Original-Received: from localhost ([::1]:57609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRPC-0005u5-Tl for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 10:25:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRP5-0005hJ-Vi for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:25:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBRP0-00035u-3p for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:25:27 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRP0-00035Q-1a for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:25:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TBRPe-0006b9-9n for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737350225287 (code B ref 12345); Tue, 11 Sep 2012 14:26:02 +0000 Original-Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 14:25:02 +0000 Original-Received: from localhost ([127.0.0.1]:54777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBROg-0006Zn-08 for submit@debbugs.gnu.org; Tue, 11 Sep 2012 10:25:02 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:21179) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBROe-0006ZP-2Y for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 10:25:01 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8BEOEIG014800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Sep 2012 14:24:15 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8BEOCrn008493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Sep 2012 14:24:12 GMT Original-Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8BEOCcr006129; Tue, 11 Sep 2012 09:24:12 -0500 Original-Received: from dradamslap1 (/10.159.175.11) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 11 Sep 2012 07:24:11 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87vcfkr884.fsf@altern.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2QIpqPAZxTXg0aRA2iVAOy500stQAA4vrQ X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64110 Archived-At: Hi Bastien, 1. I think any changes in the behavior and bindings should be proposed on emacs-devel. Personally, I don't care much, but I'm pretty sure that at least some people will want to keep the `=' binding because `+' is often on a Shift key. Emacs-devel is also the place to pose your question about zero. 2. Please consider changing the name of the parameter to INCREMENT, so the doc string is more readable: "Adjust the height of the default face by INCREMENT." Say explicitly that INCREMENT defaults to 1. 3. Alternatively, you could say something like this: "Adjust the height of face `default' by N text-scale steps. N is the numeric prefix agument: positive to increase height, negative to decrease. Step size is the value of `text-scale-mode-step'." The rest is OK. 4. Don't be surprised if Stefan doesn't go along with your change to not use the temporary keymap. He just got through _adding_ such code here and there throughout Emacs. (Makes no difference to me - my bug report was about the doc string.) Thx - Drew > > 1. Describe the parameter, INC. > > 2. Describe the use of a prefix argument. > > In general, describe this as a user command, from a user > > point of view, and not just as a function to be called from code. > > See attached patch. > > I enhanced the docstring and rewrote the command so that it does > not use a temporary keymap. When I tried `C-x C-+' I was left with > the `+' and `-' keys not usable anymore. > > The patch also removes the redundant keybinding `C-x C-='. > > And C-x C-0 does not allow adjusting further. My feeling is that > it is not useful. > > I'll apply this patch within a week if nobody is against it.