From: "Drew Adams" <drew.adams@oracle.com>
To: "'Bastien'" <bzg@altern.org>
Cc: 12345@debbugs.gnu.org
Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust'
Date: Tue, 11 Sep 2012 07:24:08 -0700 [thread overview]
Message-ID: <F82080D52CE64E8D885A70A5CCCC2A60@us.oracle.com> (raw)
In-Reply-To: <87vcfkr884.fsf@altern.org>
Hi Bastien,
1. I think any changes in the behavior and bindings should be proposed on
emacs-devel. Personally, I don't care much, but I'm pretty sure that at least
some people will want to keep the `=' binding because `+' is often on a Shift
key. Emacs-devel is also the place to pose your question about zero.
2. Please consider changing the name of the parameter to INCREMENT, so the doc
string is more readable: "Adjust the height of the default face by INCREMENT."
Say explicitly that INCREMENT defaults to 1.
3. Alternatively, you could say something like this:
"Adjust the height of face `default' by N text-scale steps.
N is the numeric prefix agument: positive to increase height, negative
to decrease. Step size is the value of `text-scale-mode-step'."
The rest is OK.
4. Don't be surprised if Stefan doesn't go along with your change to not use the
temporary keymap. He just got through _adding_ such code here and there
throughout Emacs. (Makes no difference to me - my bug report was about the doc
string.)
Thx - Drew
> > 1. Describe the parameter, INC.
> > 2. Describe the use of a prefix argument.
> > In general, describe this as a user command, from a user
> > point of view, and not just as a function to be called from code.
>
> See attached patch.
>
> I enhanced the docstring and rewrote the command so that it does
> not use a temporary keymap. When I tried `C-x C-+' I was left with
> the `+' and `-' keys not usable anymore.
>
> The patch also removes the redundant keybinding `C-x C-='.
>
> And C-x C-0 does not allow adjusting further. My feeling is that
> it is not useful.
>
> I'll apply this patch within a week if nobody is against it.
next prev parent reply other threads:[~2012-09-11 14:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 2:54 bug#12345: 24.2.50; doc string of `text-scale-adjust' Drew Adams
2012-09-11 13:37 ` Bastien
2012-09-11 13:48 ` Stefan Monnier
2012-09-11 14:24 ` Bastien
2012-09-11 14:39 ` Drew Adams
2012-09-11 16:27 ` Bastien
2012-09-11 17:21 ` Stefan Monnier
2012-09-11 17:31 ` Bastien
2012-09-12 13:13 ` Stefan Monnier
2012-09-12 13:52 ` Bastien
2012-09-12 14:16 ` Drew Adams
2012-09-13 3:18 ` Stefan Monnier
2012-09-11 17:36 ` Bastien
2012-10-26 17:12 ` Stefan Monnier
2012-10-27 6:11 ` Bastien
2012-09-11 14:24 ` Drew Adams [this message]
2012-09-11 14:53 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F82080D52CE64E8D885A70A5CCCC2A60@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=12345@debbugs.gnu.org \
--cc=bzg@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.