From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: HAVE_FAST_UNALIGNED_ACCESS Date: Fri, 31 Mar 2023 18:57:41 +0200 Message-ID: References: <87sfdmlgzx.fsf@gmail.com> <94d3de92c50a96d9172f88462bf3bc9c2792600c.camel@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_75796FD4-6C48-4C80-89AF-60D09254587F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3012"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , Eli Zaretskii , emacs-devel , Po Lu To: Vibhav Pant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 31 20:00:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piJ3P-0000cH-LZ for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Mar 2023 20:00:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piJ2v-0007Ev-Js; Fri, 31 Mar 2023 14:00:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piI4R-0005a7-EN for emacs-devel@gnu.org; Fri, 31 Mar 2023 12:57:47 -0400 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piI4P-0002qD-T0; Fri, 31 Mar 2023 12:57:47 -0400 Original-Received: by mail-lj1-x230.google.com with SMTP id z42so23701917ljq.13; Fri, 31 Mar 2023 09:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680281863; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=OX2gid62ydljRz1xl2ZE00NCi46qV0UxNkBMowwZ6jg=; b=cO77tKS1pCVY4T4uLgARywwav//UXbqhSpFpC2dFn7Zpy7Y7QjBIjywR2ZWL1dbTDL 8B4+DnsczMPcD/EU2ULigUunO7Zt7ulVGrlBdkjG6keiIrW2E9M0YNmIJ1V6ZJlpvhbY ewubVNPyHa4of7iEco1pMf8PHuZAotf4h3/7fMY/rSOBEvBHhZwwIlGFRAe+2ylbyoCB duYK9gXcFt1pgZtLYgzqJ5LTuWhZayez7EmjObaonkTb+/d8qTRLyh2Txg4yj91IZ5MR 7zyHdxi3VeEuFPBnw4cEBGJQYPkO4zwi0cDh2ybC8GA6MZFaK+icTI/Zgob+Jp4IJwL3 hE6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680281863; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OX2gid62ydljRz1xl2ZE00NCi46qV0UxNkBMowwZ6jg=; b=edu2WpM71JAyJcx4wtOsnwPFGxF5whobHL6EpW/GkqXHYtPoSLdgaVt5wrU+wgcORC zVMV4IW5OLMSaUUsXUKxKk7YeN0KcCFpb5natygI1dBb+4O9hU86ZfAYD+G0ZNDyikZe rDvnKYaYdBrmu4CJyB92vJBZjdNKAHvXUhIc/o20tFfYC2ca31AESHTahfwCg/66ukQc Qg2LVXFBP/ubdID0gem6ERaiL4RHkqPyn6LzmyVSNPa/Ff5UMr23rSX4jYnJVuvdKZxf rlH+DzUfLe9QrsKlE4YmXacMWLmxOFnHRdCxtqiniYEK+nsNekxqWhsNed+peHHVo5rf EJkg== X-Gm-Message-State: AAQBX9cdKJudaRrNRn5v9+rpvfVBqWCMCrijpX8VKhF5ktuDYlt71Kdp 9HfRksn1saJhQW6n+HNbZQE= X-Google-Smtp-Source: AKy350YiqmCDj/ubOVbjwCLBLc+JOFyQP4MfuP785TFa/Zg2O8mEWhCoB0s/ZJEZjz33F9t3DIcbCQ== X-Received: by 2002:a2e:a418:0:b0:298:9e7b:d07b with SMTP id p24-20020a2ea418000000b002989e7bd07bmr8357670ljn.30.1680281862976; Fri, 31 Mar 2023 09:57:42 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id n7-20020a2e7207000000b002986854f27dsm434938ljc.23.2023.03.31.09.57.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Mar 2023 09:57:42 -0700 (PDT) In-Reply-To: <94d3de92c50a96d9172f88462bf3bc9c2792600c.camel@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.14) Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 31 Mar 2023 14:00:15 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304942 Archived-At: --Apple-Mail=_75796FD4-6C48-4C80-89AF-60D09254587F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 30 mars 2023 kl. 13.38 skrev Vibhav Pant : > I had recently made a few modifications to this on master. There, > Fstring_lessp in uses the macro UNALIGNED_LOAD_SIZE instead, which is > defined to __sanitizer_unaligned_loadXX in lisp.h if: >=20 > * We're building with AddressSaniziter, > * is available, and > * USE_SANITIZER_UNALIGNED_LOAD is defined. Thank you for making this improvement earlier -- I think using memcpy = would subsume __sanitizer_unaligned_loadXX, so I'm going with that in my = patch. Another approach would be to disable this poor man's vectorisation when = the sanitiser is enabled but that shouldn't be necessary. The vectorisation is still only made on specific platforms, of course. Eli, would this patch be acceptable for emacs-29? --Apple-Mail=_75796FD4-6C48-4C80-89AF-60D09254587F Content-Disposition: attachment; filename=string-lessp-uni-multi.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="string-lessp-uni-multi.diff" Content-Transfer-Encoding: 7bit diff --git a/src/fns.c b/src/fns.c index f5f222c39c..292d6fc405 100644 --- a/src/fns.c +++ b/src/fns.c @@ -514,7 +514,23 @@ DEFUN ("string-lessp", Fstring_lessp, Sstring_lessp, 2, 2, 0, else { /* string1 unibyte, string2 multibyte */ - ptrdiff_t i1 = 0, i2 = 0, i2_byte = 0; + + ptrdiff_t nb1 = n; + ptrdiff_t nb2 = SBYTES (string2); + ptrdiff_t nb = min (nb1, nb2); + + /* Skip identical ASCII-only prefixes, a word at a time. */ + typedef size_t word_t; + int ws = sizeof (word_t); + word_t msbits = (word_t)0x8080808080808080; + const word_t *w1 = (const word_t *) SDATA (string1); + const word_t *w2 = (const word_t *) SDATA (string2); + ptrdiff_t b = 0; + while (b < nb - ws + 1 && w1[b / ws] == w2[b / ws] + && !(w1[b / ws] & msbits)) + b += ws; + + ptrdiff_t i1 = b, i2 = b, i2_byte = b; while (i1 < n) { int c1 = SREF (string1, i1++); --Apple-Mail=_75796FD4-6C48-4C80-89AF-60D09254587F--