* bug#1372: posn-at-x-y reports wrong window [not found] <356ECE88-9412-46FD-A227-C52D5C87E212@mac.com> @ 2008-11-19 0:45 ` David Reitter 2008-11-19 15:09 ` martin rudalics 2008-11-20 10:30 ` bug#1372: marked as done (posn-at-x-y reports wrong window) Emacs bug Tracking System 0 siblings, 2 replies; 4+ messages in thread From: David Reitter @ 2008-11-19 0:45 UTC (permalink / raw) To: emacs-pretest-bug; +Cc: Jin Choi [-- Attachment #1: Type: text/plain, Size: 4646 bytes --] I received the bug report below for our visual-line-mode in Aquamacs Emacs, but I managed to reproduce the core issue on Emacs 23 (Nextstep port) as follows: (fringe-mode 0) C-x 3 C-x 2 C-x o C-x o (we're now in the large window on the right, with two small windows in the left half of the frame). Insert enough newlines to be vertically just above the horizontal divider on the left. M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET Insert newline, now we're next to the divider line. M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET --> wrong window (the window in the upper left) is given in the structure. Instead of 0, the x value can be up to 6 ((frame-char-width) reports 7). Begin forwarded message: > From: Jin Choi <jsc@alum.mit.edu> > Date: 18 November 2008 14:35:17 EST > To: aquamacs-bugs@aquamacs.org > Subject: [Aquamacs-bugs] visual-line-mode error with vertically > split windows > > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > THE SETUP: vertically split window with the left half split > horizontally. This is commonly used in, say, ECB, perhaps other modes: > --------- > | 1 | 3 | > | | | > ----| | > | 2 | | > | | | > --------- > > > THE BUG: in the right hand window, attempting to move the cursor (in > column 1) through the row adjacent to the mode line of the upper left > hand window moves the cursor to the upper left window. Also, placing > the cursor in column 0 of that row then typing C-n or C-p gives the > error "Position not in text area of window." > > > > TO REPLICATE: > C-x 3 C-x 2 > > Hit return in the right side window (3) enough to get you past the > divider > on the left. > > Then C-p back past the divider. Cursor jumps to upper left window (1). > > Now click on the row in window 3 adjacent to the divider. Type C-n or > C-p. Gives above error. > > > WORKAROUND: > (global-visual-line-mode 0) > > > > In GNU Emacs 22.3.2 (i386-apple-darwin9.5.0, Carbon Version 1.6.0) > of 2008-09-21 on plume.sr.unh.edu - Aquamacs Distribution 1.5 > Windowing system distributor `Apple Inc.', version 10.5.5 > configured using `configure '--without-x' '--prefix=/usr/local'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: nil > locale-coding-system: iso-8859-1 > default-enable-multibyte-characters: t > > Major mode: Text > > Minor modes in effect: > shell-dirtrack-mode: t > savehist-mode: t > aquamacs-styles-mode: t > smart-frame-positioning-mode: t > global-visual-line-mode: t > visual-line-mode: t > recentf-mode: t > encoded-kbd-mode: t > osx-key-mode: t > show-paren-mode: t > delete-selection-mode: t > pc-selection-mode: t > cua-mode: t > tooltip-mode: t > mouse-wheel-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > unify-8859-on-encoding-mode: t > utf-translate-cjk-mode: t > auto-compression-mode: t > column-number-mode: t > transient-mark-mode: t > > Recent input: > <menu-bar> <help-menu> <bug-diagnosis> <start-vanilla-aquamacs> > <menu-bar> <help-menu> <bug-diagnosis> <send-emacs > -bug-report> > > Recent messages: > on One-Buffer-One-Frame-Mode (Display Buffers in Separate Frames)! > Loading /Users/jsc/Library/Preferences/Aquamacs Emacs/ > customizations.el (source)...done > Loading /Users/jsc/Library/Preferences/Aquamacs Emacs/Preferences.el > (source)...done > One-Buffer-One-Frame-Mode disabled. > For best results, turn off Frame Appearance Styles now. > Loading /Users/jsc/Library/Preferences/Aquamacs Emacs/frame- > positions.el (source)...done > Truncate long lines disabled > Mark set > Aquamacs is based on GNU Emacs 22, a part of the GNU/Linux system. It > is Free Software: you can improve and redistribute it under the GNU > General Public License, version 3 or later. Copyright (C) 2008 Free > Software Foundation, Inc. (C) 2008 D. Reitter. No Warranty. > Loading emacsbug...done > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win > great prizes > Grand prize is a trip for two to an Open Source event anywhere in > the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > __ > https://lists.sourceforge.net/lists/listinfo/aquamacs-bugs [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#1372: posn-at-x-y reports wrong window 2008-11-19 0:45 ` bug#1372: posn-at-x-y reports wrong window David Reitter @ 2008-11-19 15:09 ` martin rudalics 2008-11-19 15:27 ` David Reitter 2008-11-20 10:30 ` bug#1372: marked as done (posn-at-x-y reports wrong window) Emacs bug Tracking System 1 sibling, 1 reply; 4+ messages in thread From: martin rudalics @ 2008-11-19 15:09 UTC (permalink / raw) To: David Reitter, 1372; +Cc: Jin Choi [-- Attachment #1: Type: text/plain, Size: 630 bytes --] > (fringe-mode 0) > C-x 3 C-x 2 C-x o C-x o > (we're now in the large window on the right, with two small windows in > the left half of the frame). > > Insert enough newlines to be vertically just above the horizontal > divider on the left. > > M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET > > Insert newline, now we're next to the divider line. > > M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET > > --> wrong window (the window in the upper left) is given in the structure. > Instead of 0, the x value can be up to 6 ((frame-char-width) reports 7). Can you try the attached patch? martin [-- Attachment #2: 1372.diff --] [-- Type: text/plain, Size: 589 bytes --] *** window.c.~1.634.~ 2008-11-18 18:56:23.703125000 +0100 --- window.c 2008-11-19 16:04:02.078125000 +0100 *************** *** 774,780 **** } else { ! if (eabs (*x - x1) < grabbable_width) { /* Convert X and Y to window relative coordinates. Vertical border is at the right edge of window. */ --- 774,781 ---- } else { ! if ((WINDOW_RIGHTMOST_P (w) || *x < x1) ! && eabs (*x - x1) < grabbable_width) { /* Convert X and Y to window relative coordinates. Vertical border is at the right edge of window. */ ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#1372: posn-at-x-y reports wrong window 2008-11-19 15:09 ` martin rudalics @ 2008-11-19 15:27 ` David Reitter 0 siblings, 0 replies; 4+ messages in thread From: David Reitter @ 2008-11-19 15:27 UTC (permalink / raw) To: martin rudalics; +Cc: Jin Choi, 1372 [-- Attachment #1: Type: text/plain, Size: 1380 bytes --] Thanks, this patch fixes the problem. - David On 19 Nov 2008, at 10:09, martin rudalics wrote: > > (fringe-mode 0) > > C-x 3 C-x 2 C-x o C-x o > > (we're now in the large window on the right, with two small > windows in > > the left half of the frame). > > > > Insert enough newlines to be vertically just above the horizontal > > divider on the left. > > > > M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET > > > > Insert newline, now we're next to the divider line. > > > > M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET > > > > --> wrong window (the window in the upper left) is given in the > structure. > > Instead of 0, the x value can be up to 6 ((frame-char-width) > reports 7). > > Can you try the attached patch? > > martin > *** window.c.~1.634.~ 2008-11-18 18:56:23.703125000 +0100 > --- window.c 2008-11-19 16:04:02.078125000 +0100 > *************** > *** 774,780 **** > } > else > { > ! if (eabs (*x - x1) < grabbable_width) > { > /* Convert X and Y to window relative coordinates. > Vertical border is at the right edge of window. */ > --- 774,781 ---- > } > else > { > ! if ((WINDOW_RIGHTMOST_P (w) || *x < x1) > ! && eabs (*x - x1) < grabbable_width) > { > /* Convert X and Y to window relative coordinates. > Vertical border is at the right edge of window. */ [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#1372: marked as done (posn-at-x-y reports wrong window) 2008-11-19 0:45 ` bug#1372: posn-at-x-y reports wrong window David Reitter 2008-11-19 15:09 ` martin rudalics @ 2008-11-20 10:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 4+ messages in thread From: Emacs bug Tracking System @ 2008-11-20 10:30 UTC (permalink / raw) To: martin rudalics [-- Attachment #1: Type: text/plain, Size: 831 bytes --] Your message dated Thu, 20 Nov 2008 11:21:04 +0100 with message-id <49253A10.10603@gmx.at> and subject line Re: bug#1372: posn-at-x-y reports wrong window has caused the Emacs bug report #1372, regarding posn-at-x-y reports wrong window to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 1372: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1372 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 11154 bytes --] [-- Attachment #2.1.1: Type: text/plain, Size: 4646 bytes --] I received the bug report below for our visual-line-mode in Aquamacs Emacs, but I managed to reproduce the core issue on Emacs 23 (Nextstep port) as follows: (fringe-mode 0) C-x 3 C-x 2 C-x o C-x o (we're now in the large window on the right, with two small windows in the left half of the frame). Insert enough newlines to be vertically just above the horizontal divider on the left. M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET Insert newline, now we're next to the divider line. M-: (posn-at-x-y 0 (cdr (posn-x-y (posn-at-point)))) RET --> wrong window (the window in the upper left) is given in the structure. Instead of 0, the x value can be up to 6 ((frame-char-width) reports 7). Begin forwarded message: > From: Jin Choi <jsc@alum.mit.edu> > Date: 18 November 2008 14:35:17 EST > To: aquamacs-bugs@aquamacs.org > Subject: [Aquamacs-bugs] visual-line-mode error with vertically > split windows > > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > THE SETUP: vertically split window with the left half split > horizontally. This is commonly used in, say, ECB, perhaps other modes: > --------- > | 1 | 3 | > | | | > ----| | > | 2 | | > | | | > --------- > > > THE BUG: in the right hand window, attempting to move the cursor (in > column 1) through the row adjacent to the mode line of the upper left > hand window moves the cursor to the upper left window. Also, placing > the cursor in column 0 of that row then typing C-n or C-p gives the > error "Position not in text area of window." > > > > TO REPLICATE: > C-x 3 C-x 2 > > Hit return in the right side window (3) enough to get you past the > divider > on the left. > > Then C-p back past the divider. Cursor jumps to upper left window (1). > > Now click on the row in window 3 adjacent to the divider. Type C-n or > C-p. Gives above error. > > > WORKAROUND: > (global-visual-line-mode 0) > > > > In GNU Emacs 22.3.2 (i386-apple-darwin9.5.0, Carbon Version 1.6.0) > of 2008-09-21 on plume.sr.unh.edu - Aquamacs Distribution 1.5 > Windowing system distributor `Apple Inc.', version 10.5.5 > configured using `configure '--without-x' '--prefix=/usr/local'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: nil > locale-coding-system: iso-8859-1 > default-enable-multibyte-characters: t > > Major mode: Text > > Minor modes in effect: > shell-dirtrack-mode: t > savehist-mode: t > aquamacs-styles-mode: t > smart-frame-positioning-mode: t > global-visual-line-mode: t > visual-line-mode: t > recentf-mode: t > encoded-kbd-mode: t > osx-key-mode: t > show-paren-mode: t > delete-selection-mode: t > pc-selection-mode: t > cua-mode: t > tooltip-mode: t > mouse-wheel-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > unify-8859-on-encoding-mode: t > utf-translate-cjk-mode: t > auto-compression-mode: t > column-number-mode: t > transient-mark-mode: t > > Recent input: > <menu-bar> <help-menu> <bug-diagnosis> <start-vanilla-aquamacs> > <menu-bar> <help-menu> <bug-diagnosis> <send-emacs > -bug-report> > > Recent messages: > on One-Buffer-One-Frame-Mode (Display Buffers in Separate Frames)! > Loading /Users/jsc/Library/Preferences/Aquamacs Emacs/ > customizations.el (source)...done > Loading /Users/jsc/Library/Preferences/Aquamacs Emacs/Preferences.el > (source)...done > One-Buffer-One-Frame-Mode disabled. > For best results, turn off Frame Appearance Styles now. > Loading /Users/jsc/Library/Preferences/Aquamacs Emacs/frame- > positions.el (source)...done > Truncate long lines disabled > Mark set > Aquamacs is based on GNU Emacs 22, a part of the GNU/Linux system. It > is Free Software: you can improve and redistribute it under the GNU > General Public License, version 3 or later. Copyright (C) 2008 Free > Software Foundation, Inc. (C) 2008 D. Reitter. No Warranty. > Loading emacsbug...done > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win > great prizes > Grand prize is a trip for two to an Open Source event anywhere in > the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > __ > https://lists.sourceforge.net/lists/listinfo/aquamacs-bugs [-- Attachment #2.1.2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 1781 bytes --] From: martin rudalics <rudalics@gmx.at> To: 1372-done@emacsbugs.donarmstrong.com Cc: David Reitter <david.reitter@gmail.com>, Jin Choi <jsc@alum.mit.edu> Subject: Re: bug#1372: posn-at-x-y reports wrong window Date: Thu, 20 Nov 2008 11:21:04 +0100 Message-ID: <49253A10.10603@gmx.at> Fixed as 2008-11-20 Martin Rudalics <rudalics@gmx.at> * window.c (coordinates_in_window): Don't return ON_VERTICAL_BORDER for the rightmost position of a mode/header line when the window is not the rightmost one. (Bug#1372) Thanks for the report, martin ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-20 10:30 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <356ECE88-9412-46FD-A227-C52D5C87E212@mac.com> 2008-11-19 0:45 ` bug#1372: posn-at-x-y reports wrong window David Reitter 2008-11-19 15:09 ` martin rudalics 2008-11-19 15:27 ` David Reitter 2008-11-20 10:30 ` bug#1372: marked as done (posn-at-x-y reports wrong window) Emacs bug Tracking System
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.