From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS Date: Fri, 21 Aug 2020 11:39:30 +0200 Message-ID: References: <83lfidgtc7.fsf@gnu.org> <838sedgq2x.fsf@gnu.org> <02F52D43-7EAB-4E61-A567-E8CCD11D856B@acm.org> <20200817195610.GA70682@breton.holly.idiocy.org> <3F71EF82-A143-4E3A-AEF3-8A236091891D@acm.org> <20200818084306.GA89999@breton.holly.idiocy.org> <243A5DA8-2865-485D-A8A2-1F543B046BAA@acm.org> <20200818172824.GA90575@breton.holly.idiocy.org> <83h7sxcux5.fsf@gnu.org> <5719A3A9-06A2-42AF-A290-726D96B6E6F1@acm.org> <834koxcere.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42904@debbugs.gnu.org, alan@idiocy.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 11:40:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k93Ws-0004jl-9Z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 11:40:10 +0200 Original-Received: from localhost ([::1]:55310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k93Wq-0004w4-NQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 05:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k93Wk-0004vv-Fg for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 05:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k93Wk-0004gN-5W for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 05:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k93Wk-0004O1-1Z for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 09:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42904 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42904-submit@debbugs.gnu.org id=B42904.159800278116829 (code B ref 42904); Fri, 21 Aug 2020 09:40:01 +0000 Original-Received: (at 42904) by debbugs.gnu.org; 21 Aug 2020 09:39:41 +0000 Original-Received: from localhost ([127.0.0.1]:45045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k93WO-0004NN-Vi for submit@debbugs.gnu.org; Fri, 21 Aug 2020 05:39:41 -0400 Original-Received: from mail153c50.megamailservers.eu ([91.136.10.163]:39980 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k93WK-0004NA-Nb for 42904@debbugs.gnu.org; Fri, 21 Aug 2020 05:39:39 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1598002773; bh=gArLgrf9Qs5gMBuXiHdWBGMB9YQ4mr5EVef/EvhppoU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ESuYIzDd0EUEYQUvjHZG4tlAwnIz7wIBR0clErRQNBAGB+f/X3BXaN0Gc66nUNHFL J/9uJn/gFLrcap8jBJ77h53D54ZFTArv7zGDQ6r1e45Dpzx+Kt5Uf4VdtBsdphVDQZ 2R+vwhVurAmlRixWBDrrXt5dvjQI/IaUYdG1vKnw= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 07L9dUXJ011063; Fri, 21 Aug 2020 09:39:32 +0000 In-Reply-To: <834koxcere.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F20.5F3F9655.003B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NoevjPVJ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=n3ZewxPj0Rvn7b0G9hYA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185828 Archived-At: 20 aug. 2020 kl. 21.13 skrev Eli Zaretskii : > I don't think I understand. mode_line_noprop_buf gets the bytes, and > then we call make_string on it, so the result is the same as the one > you'd like to avoid. Or am I missing something? >=20 > By "settling on multibyte representation", do you mean that we should > convert raw bytes to their multibyte form? Or do you mean something > else? No, I think we are talking about the same thing. Basically, it's about = how the bytes end up in mode_line_noprop_buf in the first place, since = currently the information of whether it should be interpreted as unibyte = or multibyte gets lost as soon as data from the strings it is composed = of (like the buffer name for %b, file name for %f etc) is added to it. = Then make_string tries to restore that information by looking at the = bytes, and it is not always accurate. One way of doing this is to always make sure that the input strings = (buffer name, file name, frame-title-format etc) are always in multibyte = form. Another would be to convert to multibyte as those strings are = used, presumably in decode_mode_spec. You know this code a lot better = than I do, but the former may be slightly more workable (and efficient). > Again, what would you like to have instead? Would calling > str_as_multibyte do what you want? No, I don't think so -- once the unibyte/multibyte bit is lost, it can = only be restored imperfectly if all we have is the sequence of bytes. In = mathematical terms, the function that maps an arbitrary string object to = its bytes has no inverse. (Consider the unibyte string "\xc3\xa5" -- = should the bytes {c3, a5} be recreated as that unibyte string, or as the = multibyte string "=C3=A5"?) Again we are talking about trivialities here, but perhaps the same = syndrome will arise in other contexts where it matters more. If we wrote = Emacs from scratch we likely wouldn't have unibyte strings at all: they = are only there for compatibility and various niche uses and performance = hacks. I don't think it's unreasonable to start normalising strings to = multibyte where it matters. Thanks for your patience!