* bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance @ 2009-07-20 20:49 ` Ian Eure 2009-07-21 9:39 ` martin rudalics ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Ian Eure @ 2009-07-20 20:49 UTC (permalink / raw) To: emacs-pretest-bug [-- Attachment #1: Type: text/plain, Size: 488 bytes --] A user came into #emacs today complaining that his paren matching was not working with a large file, and that font-locking broke as a result. I found that this is controlled by blink-matching-paren-distance, which was increased to 25kb around 1997. Attached is a patch which doubles this to 50kb, as this should be fine for modern machines. I think that we should seriously consider setting the default to nil, but this seems like a more conservative approach to the matter. [-- Attachment #2: blink-matching-paren.patch --] [-- Type: application/octet-stream, Size: 651 bytes --] Index: simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.998 diff -u -u -r1.998 simple.el --- simple.el 19 Jul 2009 00:33:11 -0000 1.998 +++ simple.el 20 Jul 2009 20:45:21 -0000 @@ -5254,7 +5254,7 @@ :type 'boolean :group 'paren-blinking) -(defcustom blink-matching-paren-distance (* 25 1024) +(defcustom blink-matching-paren-distance (* 50 1024) "If non-nil, maximum distance to search backwards for matching open-paren. If nil, search stops at the beginning of the accessible portion of the buffer." :type '(choice (const nil) integer) [-- Attachment #3: Type: text/plain, Size: 1 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance 2009-07-20 20:49 ` bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance Ian Eure @ 2009-07-21 9:39 ` martin rudalics 2009-07-21 16:17 ` Ian Eure 2009-07-21 16:22 ` Stefan Monnier 2009-07-22 2:40 ` bug#3889: marked as done (23.1.50; [PATCH] Increase blink-matching-paren-distance) Emacs bug Tracking System 2 siblings, 1 reply; 6+ messages in thread From: martin rudalics @ 2009-07-21 9:39 UTC (permalink / raw) To: Ian Eure, 3889 > A user came into #emacs today complaining that his paren matching was > not working with a large file, and that font-locking broke as a result. > > I found that this is controlled by blink-matching-paren-distance, which > was increased to 25kb around 1997. How can `blink-matching-paren-distance' affect font-locking? If I understand correctly all `blink-matching-open' can do is slow down typing. martin ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance 2009-07-21 9:39 ` martin rudalics @ 2009-07-21 16:17 ` Ian Eure 2009-07-21 17:23 ` martin rudalics 0 siblings, 1 reply; 6+ messages in thread From: Ian Eure @ 2009-07-21 16:17 UTC (permalink / raw) To: martin rudalics; +Cc: 3889 On Jul 21, 2009, at 2:39 AM, martin rudalics wrote: > > A user came into #emacs today complaining that his paren matching > was > > not working with a large file, and that font-locking broke as a > result. > > > > I found that this is controlled by blink-matching-paren-distance, > which > > was increased to 25kb around 1997. > > How can `blink-matching-paren-distance' affect font-locking? If I > understand correctly all `blink-matching-open' can do is slow down > typing. > I don't know, as I couldn't reproduce that aspect of the issue. Perhaps their `show-paren-style' was set to 'expression. The paren matching definitely breaks, though. You get a message saying that you have mismatched parens, and they're highlighted incorrectly. - Ian ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance 2009-07-21 16:17 ` Ian Eure @ 2009-07-21 17:23 ` martin rudalics 0 siblings, 0 replies; 6+ messages in thread From: martin rudalics @ 2009-07-21 17:23 UTC (permalink / raw) To: Ian Eure; +Cc: 3889 > I don't know, as I couldn't reproduce that aspect of the issue. Perhaps > their `show-paren-style' was set to 'expression. Could you try to get back to them? Font-locking should never be affected by this. > The paren matching definitely breaks, though. You get a message saying > that you have mismatched parens, and they're highlighted incorrectly. That's normal. martin ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance 2009-07-20 20:49 ` bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance Ian Eure 2009-07-21 9:39 ` martin rudalics @ 2009-07-21 16:22 ` Stefan Monnier 2009-07-22 2:40 ` bug#3889: marked as done (23.1.50; [PATCH] Increase blink-matching-paren-distance) Emacs bug Tracking System 2 siblings, 0 replies; 6+ messages in thread From: Stefan Monnier @ 2009-07-21 16:22 UTC (permalink / raw) To: Ian Eure; +Cc: emacs-pretest-bug, 3889 > Attached is a patch which doubles this to 50kb, as this should be fine for > modern machines. 100kB should be fine, indeed. > I think that we should seriously consider setting the default to nil, > but this seems like a more conservative approach to the matter. Maybe when you're browsing a 200MB log file, you'll find it painful, so a lower limit would still seem to make sense. 100kB is probably very conservative (even when running on my poor cell-phone, it should be fast enough). Stefan ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#3889: marked as done (23.1.50; [PATCH] Increase blink-matching-paren-distance) 2009-07-20 20:49 ` bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance Ian Eure 2009-07-21 9:39 ` martin rudalics 2009-07-21 16:22 ` Stefan Monnier @ 2009-07-22 2:40 ` Emacs bug Tracking System 2 siblings, 0 replies; 6+ messages in thread From: Emacs bug Tracking System @ 2009-07-22 2:40 UTC (permalink / raw) To: Glenn Morris [-- Attachment #1: Type: text/plain, Size: 912 bytes --] Your message dated Tue, 21 Jul 2009 22:35:50 -0400 with message-id <mf8wihe96h.fsf@fencepost.gnu.org> and subject line Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance has caused the Emacs bug report #3889, regarding 23.1.50; [PATCH] Increase blink-matching-paren-distance to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 3889: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3889 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 4015 bytes --] [-- Attachment #2.1.1: Type: text/plain, Size: 488 bytes --] A user came into #emacs today complaining that his paren matching was not working with a large file, and that font-locking broke as a result. I found that this is controlled by blink-matching-paren-distance, which was increased to 25kb around 1997. Attached is a patch which doubles this to 50kb, as this should be fine for modern machines. I think that we should seriously consider setting the default to nil, but this seems like a more conservative approach to the matter. [-- Attachment #2.1.2: blink-matching-paren.patch --] [-- Type: application/octet-stream, Size: 651 bytes --] Index: simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.998 diff -u -u -r1.998 simple.el --- simple.el 19 Jul 2009 00:33:11 -0000 1.998 +++ simple.el 20 Jul 2009 20:45:21 -0000 @@ -5254,7 +5254,7 @@ :type 'boolean :group 'paren-blinking) -(defcustom blink-matching-paren-distance (* 25 1024) +(defcustom blink-matching-paren-distance (* 50 1024) "If non-nil, maximum distance to search backwards for matching open-paren. If nil, search stops at the beginning of the accessible portion of the buffer." :type '(choice (const nil) integer) [-- Attachment #2.1.3: Type: text/plain, Size: 1 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 1685 bytes --] From: Glenn Morris <rgm@gnu.org> To: 3889-done@emacsbugs.donarmstrong.com Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance Date: Tue, 21 Jul 2009 22:35:50 -0400 Message-ID: <mf8wihe96h.fsf@fencepost.gnu.org> Stefan Monnier wrote: >> Attached is a patch which doubles this to 50kb, as this should be fine for >> modern machines. > > 100kB should be fine, indeed. So increased. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-07-22 2:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <mf8wihe96h.fsf@fencepost.gnu.org> 2009-07-20 20:49 ` bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance Ian Eure 2009-07-21 9:39 ` martin rudalics 2009-07-21 16:17 ` Ian Eure 2009-07-21 17:23 ` martin rudalics 2009-07-21 16:22 ` Stefan Monnier 2009-07-22 2:40 ` bug#3889: marked as done (23.1.50; [PATCH] Increase blink-matching-paren-distance) Emacs bug Tracking System
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.