From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthew Malcomson Newsgroups: gmane.emacs.bugs Subject: bug#62419: 28.2; Elisp let-bound buffer-local variable and kill-local-variable Date: Wed, 29 Mar 2023 11:56:32 +0100 Message-ID: References: <19A857D6-D071-44DE-AF89-539A563FD782@gmail.com> <56FDA944-04A3-4993-93BE-3E3E0F1CD227@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20700"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62419@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 29 12:57:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phTUd-0005C1-Qm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Mar 2023 12:57:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phTUM-0008N5-NN; Wed, 29 Mar 2023 06:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phTUF-0008Mn-DR for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 06:57:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phTUF-0007ay-3n for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 06:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phTUE-0007yi-G8 for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 06:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthew Malcomson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Mar 2023 10:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62419 X-GNU-PR-Package: emacs Original-Received: via spool by 62419-submit@debbugs.gnu.org id=B62419.168008740230635 (code B ref 62419); Wed, 29 Mar 2023 10:57:02 +0000 Original-Received: (at 62419) by debbugs.gnu.org; 29 Mar 2023 10:56:42 +0000 Original-Received: from localhost ([127.0.0.1]:51371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phTTt-0007y3-O8 for submit@debbugs.gnu.org; Wed, 29 Mar 2023 06:56:42 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:40633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phTTr-0007xm-IT for 62419@debbugs.gnu.org; Wed, 29 Mar 2023 06:56:40 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id t4so9961964wra.7 for <62419@debbugs.gnu.org>; Wed, 29 Mar 2023 03:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680087393; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uHzW7SfFikrT6rYSSBKZeoyDTVW+1gtqS1gZPg6wlWs=; b=LmtS7kMW9aNvYSmOb9gwfBeljd151A7klTH+1YuwDtPg9hs6VOLUMhY94AM7TtvE+T uuTkbOMGoVrX/HyEpEwrdLJAW52XTMvP+yGGVper5pWHS3ds23NUeUJDcOrLZlrnO3Zw Ba+6k2owcERpRES8Ry20RwMnQRWRTVNAzF/UVdeAhlpI6aKiiDmlPyIOj23lY8rebMM+ AEJrnqS/ufvDnB7WESZlGq9rvhYmXy8iWscc39+4QI9xvQjL1YCwhPKw6HvVGDbMuAEG RAOCUVGNZpXJITjjNGcd3MEGCAUo9YtKU2dikPWPvSw09cvzVIcykGUHF8bqtVNr1m4w WPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680087393; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uHzW7SfFikrT6rYSSBKZeoyDTVW+1gtqS1gZPg6wlWs=; b=t2I5HzRKspGjKNMmdEn+mB01xrmhMQnIax7hmT+xz89aSkK7Zp34fucuE6K1XI6pzZ SUOYDibZLVnIxg7q48ehn9G9M8RQgS1V9OVaqe8DAKiKsn96f++lIUZJeOpkuVIs+V9U b+w8X23C5y+tRVaPAsAi/YpnLT9/BCKhJylMV36XLVpDsdMuRppfyXBzOlHmFZasLSzT J8FgnReWPpcKrcCAtrwqiPc3kXZ8MK7Rdo8zCyhTLyr/z2u2vSwQP2G93rHaRjIUfTkd PIJm0M/jAoO0Ht0TL555l+s0FLqXBdnjg1vdG8QlL9KkqkRZv2SQvRSM+g/6ofedQkM8 6+UQ== X-Gm-Message-State: AAQBX9f33V7TGaVO17gNwm7vDjvGNe1QZpNUhSc9qQi49YF/clB5D/RL PgoNO1eo/PA4R4d1VkaCgfA= X-Google-Smtp-Source: AKy350aDoFP/EawXKzwg72/YAVIvbgxb5bwFRj49WO+ehQntAtOVohkJDjQ6VafElb2WjPl8qJfyEw== X-Received: by 2002:a5d:4d51:0:b0:2d2:20ed:b572 with SMTP id a17-20020a5d4d51000000b002d220edb572mr14083994wru.69.1680087393526; Wed, 29 Mar 2023 03:56:33 -0700 (PDT) Original-Received: from smtpclient.apple ([2a00:23c6:5484:ac01:18a8:8215:5cbb:57b9]) by smtp.gmail.com with ESMTPSA id t14-20020a05600001ce00b002da76acfee1sm17623024wrx.28.2023.03.29.03.56.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2023 03:56:32 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3693.60.0.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258835 Archived-At: Thanks! Just for the record I=E2=80=99ve been running using essentially this = patch (but with !=3D) since you suggested it and have not had any = problems. FWIW I also think the change to avoid `let` binding `auto-fill-function` = in `normal-mode` is good. Regards, Matthew > On 26 Mar 2023, at 16:30, Stefan Monnier = wrote: >=20 >> I.e. currently the behaviour of `setq` on automatic buffer-local = variables is: >> - Outside `let`, always affect buffer-local (creating if = necessary) >> - In `let` of global binding, affect global binding. >> - In `let` of buffer-local binding, affect buffer-local >> - In `let` of buffer-local binding but where buffer-local value = has >> been killed, affect global value. >>=20 >> I believe that last condition is strange and the behaviour of `setq` = would >> be more understandable without it. >=20 > I think the patch below would fix this corner case. >=20 >=20 > Stefan >=20 >=20 > diff --git a/src/eval.c b/src/eval.c > index ef7ca33f834..82ada40b309 100644 > --- a/src/eval.c > +++ b/src/eval.c > @@ -3364,7 +3364,7 @@ DEFUN ("fetch-bytecode", Ffetch_bytecode, = Sfetch_bytecode, > return object; > } >=20 > -/* Return true if SYMBOL currently has a let-binding > +/* Return true if SYMBOL's default currently has a let-binding > which was made in the buffer that is now current. */ >=20 > bool > @@ -3379,6 +3379,7 @@ let_shadows_buffer_binding_p (struct Lisp_Symbol = *symbol) > struct Lisp_Symbol *let_bound_symbol =3D XSYMBOL (specpdl_symbol = (p)); > eassert (let_bound_symbol->u.s.redirect !=3D SYMBOL_VARALIAS); > if (symbol =3D=3D let_bound_symbol > + && !p->kind =3D=3D SPECPDL_LET_LOCAL /* bug#62419 */ > && EQ (specpdl_where (p), buf)) > return 1; > } >=20