From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Date: Sun, 26 May 2019 19:05:55 +0200 Message-ID: References: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> <752237291204505cd6b3fb98f667c2718fa6361f.camel@acm.org> <7C514C39-A204-44F4-A806-0B7DC3F4E6B4@acm.org> <83sgt67o2x.fsf@gnu.org> <87d0kaag5z.fsf@gmail.com> <83r28q7mxo.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114330"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Noam Postavsky , vibhavp@gmail.com, 35770@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 26 19:07:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hUwcE-000Tbd-Fq for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 May 2019 19:07:22 +0200 Original-Received: from localhost ([127.0.0.1]:57602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUwcD-0002Fx-Ev for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 May 2019 13:07:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUwc0-0002Eu-KU for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 13:07:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUwbz-0008Si-3W for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 13:07:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUwbu-0008R6-IS for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 13:07:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUwbu-0005Eq-9o for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 13:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2019 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35770 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35770-submit@debbugs.gnu.org id=B35770.155889037620064 (code B ref 35770); Sun, 26 May 2019 17:07:02 +0000 Original-Received: (at 35770) by debbugs.gnu.org; 26 May 2019 17:06:16 +0000 Original-Received: from localhost ([127.0.0.1]:51622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUwb9-0005DX-O0 for submit@debbugs.gnu.org; Sun, 26 May 2019 13:06:15 -0400 Original-Received: from mail76c50.megamailservers.eu ([91.136.10.86]:55136 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUwb7-0005DN-4l for 35770@debbugs.gnu.org; Sun, 26 May 2019 13:06:14 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558890371; bh=OccO7AfeNl7GYPuAF4Cl5bYQVK6m4BmUApa+kxGEGUQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=F4Kz2T8vTMovFnKzYSsobqT9Vuq2PHekM2pMmElWslI6vsDORUHesripGZMwf5jeY MhcBr6CbOWLlNALuc1/wP8qTzpfS0soyKhGz6+e4uOv15ck3mWisrXixQol+NsxyOr hmO6vASsatst1nknGQ8JpWTbM8bBhsG8ZW3LHzOE= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4QH5unL020270; Sun, 26 May 2019 17:05:58 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0211.5CEAC77E.0090, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=epTxMLhX c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=iRZporoAAAAA:8 a=J4kTrFzgDyiTWEYpgkUA:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159793 Archived-At: 22 maj 2019 kl. 16.19 skrev Stefan Monnier : >=20 > turning off byte-compile-cond-use-jump-table by default is the safer = way > to do that, I think. Is the consensus then that the patch is fine for master, and that the = switch op generation should be disabled by default in emacs-26? Maybe = with an explanation in the doc string: -(defcustom byte-compile-cond-use-jump-table t - "Compile `cond' clauses to a jump table implementation (using a = hash-table)." +(defcustom byte-compile-cond-use-jump-table nil + "Compile `cond' clauses to a jump table implementation (using a = hash-table). + +In Emacs 26, this feature is disabled by default because of a bug +in the code generation of `cond' forms with duplicated test clauses." :version "26.1" :group 'bytecomp :type 'boolean) If so, I'll push. No NEWS change needed in either branch, right?