From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Noam Postavsky <npostavs@gmail.com>,
vibhavp@gmail.com, 35770@debbugs.gnu.org
Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation
Date: Sun, 26 May 2019 19:05:55 +0200 [thread overview]
Message-ID: <F2FFE272-6B89-4521-989F-FE2A5369A755@acm.org> (raw)
In-Reply-To: <jwvh89mwp1g.fsf-monnier+emacs@gnu.org>
22 maj 2019 kl. 16.19 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>
> turning off byte-compile-cond-use-jump-table by default is the safer way
> to do that, I think.
Is the consensus then that the patch is fine for master, and that the switch op generation should be disabled by default in emacs-26? Maybe with an explanation in the doc string:
-(defcustom byte-compile-cond-use-jump-table t
- "Compile `cond' clauses to a jump table implementation (using a hash-table)."
+(defcustom byte-compile-cond-use-jump-table nil
+ "Compile `cond' clauses to a jump table implementation (using a hash-table).
+
+In Emacs 26, this feature is disabled by default because of a bug
+in the code generation of `cond' forms with duplicated test clauses."
:version "26.1"
:group 'bytecomp
:type 'boolean)
If so, I'll push. No NEWS change needed in either branch, right?
next prev parent reply other threads:[~2019-05-26 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:33 bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Mattias Engdegård
2019-05-17 12:16 ` Stefan Monnier
2019-05-17 14:48 ` Mattias Engdegård
2019-05-22 10:52 ` Mattias Engdegård
2019-05-22 10:58 ` Eli Zaretskii
2019-05-22 11:11 ` Mattias Engdegård
2019-05-22 11:21 ` Noam Postavsky
2019-05-22 11:23 ` Eli Zaretskii
2019-05-22 14:19 ` Stefan Monnier
2019-05-26 17:05 ` Mattias Engdegård [this message]
2019-05-26 18:43 ` Eli Zaretskii
2019-05-26 22:06 ` Stefan Monnier
2019-05-27 11:27 ` Mattias Engdegård
2019-06-01 13:58 ` Noam Postavsky
2019-06-01 15:47 ` Eli Zaretskii
2019-06-01 21:53 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2FFE272-6B89-4521-989F-FE2A5369A755@acm.org \
--to=mattiase@acm.org \
--cc=35770@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.