From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Date: Sun, 14 Apr 2024 16:34:16 -0700 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10284"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70361@debbugs.gnu.org, noah.v.peart@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 15 01:35:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rw9NJ-0002Tc-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Apr 2024 01:35:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rw9N9-0007B4-2k; Sun, 14 Apr 2024 19:34:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rw9N7-0007AZ-AG for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 19:34:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rw9N6-000854-VF for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 19:34:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rw9NI-0006F2-5y for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 19:35:04 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Apr 2024 23:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70361-submit@debbugs.gnu.org id=B70361.171313768923889 (code B ref 70361); Sun, 14 Apr 2024 23:35:03 +0000 Original-Received: (at 70361) by debbugs.gnu.org; 14 Apr 2024 23:34:49 +0000 Original-Received: from localhost ([127.0.0.1]:36383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9N3-0006DC-1C for submit@debbugs.gnu.org; Sun, 14 Apr 2024 19:34:49 -0400 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:51682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9Mz-0006BV-Gk for 70361@debbugs.gnu.org; Sun, 14 Apr 2024 19:34:47 -0400 Original-Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1e0bec01232so20098635ad.3 for <70361@debbugs.gnu.org>; Sun, 14 Apr 2024 16:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713137668; x=1713742468; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=7Eixhic06OzTEe+dz/k0Xmz2+su3x+D8MgxyYCKKVlw=; b=ickW3pll4JgNQsKucYfFshNHp0kdGTCCKoYOweOBfU7R36+Wf3ge0tIQAZ3FGX4xuy Lkdqa9jeH+lMX3Scl8VIIs7X+ploDUbUwiY9VHMch804ds3cL4o9AnontFDwBVpmmeYJ LBaTTFcCjPPgLpaXtpJE1aUjBf1tVXLpC76dFkIInM22VBKGtc3vMoxeAk3nQku2NR8q eOcjSmwS3n5mwcRqVLxi8SJkS8vqRl9DZqwz4JlftvdNP0P/OOtojIUFe79L69x9wF8S qJxyI9V7Pj0rKchVyZacpOKLu7R62KR1M3mr+P7YteV2zdPw2mzz/eRR84uvA4Ev28Z5 rd8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713137668; x=1713742468; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Eixhic06OzTEe+dz/k0Xmz2+su3x+D8MgxyYCKKVlw=; b=ckgTdzvH/rl3xm9fp+76mSeYIhd2ypHYUiHc1gftN2l9Z7fJkAOLIkKcq9c4KLbUSq SmYzQjzK7guFh+kvxqwCgrCW5sRcMKNPFczQfNf1uLSSBlLPxRCY9g9k0QuIVntVafmn bQc6L+zUb9Wp0qLIIJdH7fdkcbu222EzGJxHHmFIobKE8QqkgzOSgi6b3d6xfNj+39i/ iJaoersplZ3STobd484X+R+ZJ+XFXuovjCSA+NZZS7AlExytFAL+Bkxchaebzz8HL0f1 t5j16SrYXiI1PpJ1Wx1UgpM6MsPcTy7htoYPKyhpxBcfe7/DrPbtbkfZc4hxoNvHxWEW pHCg== X-Forwarded-Encrypted: i=1; AJvYcCXkMnNGgKT3oIXRwXJrvqMyo6lKEMqVTwk6+49gwyXXyOUsNocRFua/JgNALvwXDKTS9mhfoHQsHCnrWA811kwcB6fRKX4= X-Gm-Message-State: AOJu0YwuQ1YdVfKGbPhJIQM+VVrj5nmMyrB+uSFIRqdJbm+IzdlSgflw +Lh2AoP31h13aoLfgdyv1e9E5qSZGqG0RhcnXJl9K6pSdylD3UQ/ X-Google-Smtp-Source: AGHT+IGZQr0M3Wf+5pciuouZQ5KIXJqztAmaBBt/jB8e0TGN2+3wx3FpEiLW8OPL53CK/xes60xg3w== X-Received: by 2002:a17:902:c40a:b0:1e4:8c64:33c6 with SMTP id k10-20020a170902c40a00b001e48c6433c6mr9127649plk.59.1713137668198; Sun, 14 Apr 2024 16:34:28 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:641:300:4910:ddd5:ebc3:f048:bab8]) by smtp.gmail.com with ESMTPSA id kw14-20020a170902f90e00b001e249903b0fsm6617067plb.256.2024.04.14.16.34.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2024 16:34:27 -0700 (PDT) X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283327 Archived-At: Eli Zaretskii writes: >> From: Noah Peart >> Date: Sat, 13 Apr 2024 00:32:59 -0700 >> Cc: 70361@debbugs.gnu.org >>=20 >> On a somewhat related note, I was wondering why the treesit modes in = emacs >> define their `treesit-font-lock-feature-list`s in the mode = definitions. >>=20 >> Wouldn't it be more user-friendly to `defvar` the feature list? > > AFAIR, we do that in the mode's settings because the translation of > general categories into mode-specific settings is not easy, and > because we want users to control that via the fontification level, not > below that. > > What problems do you see with the current approach that would require > more fine-grained user control? And why do you think a defvar is the > proper way of providing such control? Replying to Noah, I don=E2=80=99t think there=E2=80=99s anything wrong = for a major mode to define a xxx-mode-feature-list and assign it to treesit-font-lock-feature-list when setting up the major mode. We just don=E2=80=99t want a central tree-sitter-font-lock-feature-list that = controls the feature list of every major mode in a single place. But again, even if a xxx-mode defines xxx-mode-feature-list, it would be a bit of a hassle to take out or remove a single feature from the list, since it=E2=80=99s a list of list. (You can just setq the whole list, = but then you need to keep it in sync with upstream.) It=E2=80=99s probably easier = to call treesit-font-lock-recompute-features in the major mode hook anyway. Yuan