all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 70576@debbugs.gnu.org
Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints"
Date: Sun, 28 Apr 2024 08:45:19 -0400	[thread overview]
Message-ID: <F002D0AE-8594-429F-8313-EF867AD6DB5C@gmail.com> (raw)
In-Reply-To: <86cyqaezhc.fsf@mail.linkov.net>

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]



> On Apr 28, 2024, at 2:58 AM, Juri Linkov <juri@linkov.net> wrote
>> Of course a new wrapper macro could also be developed to ease this.
>> Do you anticipate any specific issues?
> 
> Here is what I recommend to do to simplify the definition of hints for users.
> 
> Like there can be a list of enter and exit commands in 'defvar-keymap':
> 
>  :repeat ‘(:enter (commands ...) :exit (commands ...))’
> 
> the same list could be used for hints:
> 
>  :repeat ‘(:enter (commands ...) :exit (commands ...) :hints ((command . hint) ...))’
> 
> This should be easier to document and to understand by users than
> a special syntax of cons for binding and the requirement to add :name.

Though it will require repetition and thus be subject to changed-here-but-not-there errors, this does look good and nicely groups the information under :repeat.  So this should work for all commands in the keymap:

> (defvar-keymap expreg-repeat-map
>    :doc "Repeat map for `expreg' actions."
>    :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract")))
>    "\\" 'expreg-expand
>    "|"  'expreg-contract)


If a hint is missing for a command, it should just have its key mentioned.  It looks like your idea would require changes to defvar-keymap.  Do you want to propose a patch?  We'd need some way to pass the hints in; perhaps the macro could set a property on the command symbol as you initially proposed.

[-- Attachment #2: Type: text/html, Size: 8923 bytes --]

  reply	other threads:[~2024-04-28 12:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 22:31 bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" JD Smith
2024-04-26  6:06 ` Juri Linkov
2024-04-26 14:37   ` JD Smith
2024-04-28  6:58     ` Juri Linkov
2024-04-28 12:45       ` JD Smith [this message]
2024-04-28 16:38         ` Juri Linkov
2024-05-02  6:48           ` Juri Linkov
2024-05-02  7:16             ` Eli Zaretskii
2024-05-02 11:47               ` JD Smith
2024-05-02 16:16               ` Juri Linkov
2024-05-02 18:14                 ` Eli Zaretskii
2024-05-03  6:23                   ` Juri Linkov
2024-05-03  7:15                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F002D0AE-8594-429F-8313-EF867AD6DB5C@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=70576@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.