From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: propose adding Icicles to Emacs Date: Sat, 16 Jun 2007 13:53:18 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1182027339 29568 80.91.229.12 (16 Jun 2007 20:55:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2007 20:55:39 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 22:55:36 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HzfJ2-0008Ju-7h for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2007 22:55:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HzfJ1-0002Hl-Ph for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2007 16:55:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HzfIy-0002Fn-Dz for emacs-devel@gnu.org; Sat, 16 Jun 2007 16:55:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HzfIx-0002En-IL for emacs-devel@gnu.org; Sat, 16 Jun 2007 16:55:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HzfIx-0002Ee-EX for emacs-devel@gnu.org; Sat, 16 Jun 2007 16:55:31 -0400 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HzfIw-0001Zb-33; Sat, 16 Jun 2007 16:55:30 -0400 Original-Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l5GKtQZH009315; Sat, 16 Jun 2007 15:55:26 -0500 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l5GKpNMU031647; Sat, 16 Jun 2007 14:55:25 -0600 Original-Received: from dhcp-amer-csvpn-gw1-141-144-64-42.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 2934590511182027212; Sat, 16 Jun 2007 13:53:32 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-reply-to: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73117 Archived-At: > 1. As I mentioned, my `read-face-name' just shows face names in > *Completions* using their own faces. IMO, that should also be > done in Emacs, but it is 100% independent of the rest of Icicles. > > This could be a good idea. Can it be done by replacing the standard > `read-face-name' with yours? Yes. It is not dependent on the rest of Icicles in any way. > Would someone please look at installing this? > > 2. Same thing for `face-valid-attribute-values': It shows > color names using the colors they name. Good to add to Emacs, > and independent of the rest of Icicles. > > Likewise. Yes, likewise. > 4. My `completion-setup-function' and `display-completion-list' > - see what I wrote before (about fitting the *Completions* > window to the buffer etc.). This would mean modifying the > definitions of `completion-setup-function' and > `display-completion-list' in ways that I think would be good > anyway. For instance, my `display-completion-list' does not > remove text properties from candidates, and it adjusts the > number of displayed columns and their widths. > I personally would prefer to see `display-completion-list' be a Lisp > function, but I will survive without that. My enhancements to it are > independent of the rest of Icicles, but they do matter to the Icicles > experience ;-). > > I am not sure what that previous text that refers to, >>From my mail in this thread from Mon 6/11/2007 11:34 AM (your time might vary): | As another example, `completion-setup-function' is modified so that it does | not print the help lines at the top of *Completions*. That printing is done | instead in [my version of] `display-completion-list', so that the | *Completions* window can be fit to the buffer. Icicles formats the | *Completions* display "intelligently", determining a useful number of | columns and height, and it fits the window to the formatted buffer. | (This formatting, e.g. column and default window width, is under the | control of user options.) That is an enhancement that we might want to | consider for vanilla Emacs. My version of `display-completion-list' is a Lisp transcription of the C function in Emacs, to which I then added the enhancement just described. These comments in the source code (icicles-fn.el) describe all of the Icicles enhancements to `display-completion-list': 1. Does not remove text properties from candidates when it displays them in *Completions*. [I think I persuaded you already to do this in Emacs. It may already be in Emacs 22.] 2. Adjusts number of columns and their widths to window size. 3. The optional second arg is ignored. In the vanilla Emacs version, this is a string representing a common prefix, and faces `completions-first-difference' and `completions-common-part' are used on candidates. #3 is necessary for Icicles because Emacs hard-codes application of these faces. Icicles doesn't need this and it gets in the way. Icicles highlights the common parts in a better way for Icicles (and in a way that is under the control of the user). FWIW, I personally prefer that `display-completion-list' be in Lisp, precisely because it is easier for users to tweak (as I did). *Completions* display is, IMO, the kind of thing that third-party libraries might want to or even need to customize. I don't see the point of having such code in C. Having to transcribe the C code to Lisp, in order to then customize it, is a chore that shouldn't be necessary. I avoided it for a long time, until I got to the point where I wanted to do #2, for which there was no other solution.