From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: [Bug] "You can't edit this part of the Custom buffer" Date: Thu, 27 Jul 2006 15:35:40 -0700 Message-ID: References: <87vepiy9gp.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1154039852 31047 80.91.229.2 (27 Jul 2006 22:37:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 27 Jul 2006 22:37:32 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 28 00:37:31 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G6ETd-0008Mw-Vy for ged-emacs-devel@m.gmane.org; Fri, 28 Jul 2006 00:37:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G6ETd-0005gD-Dr for ged-emacs-devel@m.gmane.org; Thu, 27 Jul 2006 18:37:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G6ETU-0005fy-1l for emacs-devel@gnu.org; Thu, 27 Jul 2006 18:37:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G6ETQ-0005fm-IM for emacs-devel@gnu.org; Thu, 27 Jul 2006 18:36:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G6ETQ-0005fj-EN for emacs-devel@gnu.org; Thu, 27 Jul 2006 18:36:56 -0400 Original-Received: from [141.146.126.228] (helo=agminet01.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1G6EVH-0000IC-Ci for emacs-devel@gnu.org; Thu, 27 Jul 2006 18:38:51 -0400 Original-Received: from rcsmt251.oracle.com (rcsmt251.oracle.com [148.87.90.196]) by agminet01.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k6REKEds017204 for ; Thu, 27 Jul 2006 17:36:54 -0500 Original-Received: from dradams-lap.us.oracle.com by rcsmt250.oracle.com with ESMTP id 1664341371154039746; Thu, 27 Jul 2006 16:35:46 -0600 Original-To: X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) Importance: Normal In-Reply-To: <87vepiy9gp.fsf@stupidchicken.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1807 X-Whitelist: TRUE X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:57700 Archived-At: > Uh, are you sure this is the right thing to do? IIUC, RMS just = added > custom-no-edit, and bound it, to raise an error when you try to = edit > a non-editable part of the buffer. > > Simply removing the binding seems pointless. Perhaps the fix to = the > new problem should be to better determine which are the = non-editable > parts of the buffer, and make sure the error is only raised there? =20 That was an incorrect fix. `widget-keymap' defines "\C-m" to 'widget-field-activate, which is supposed to find the widget under point and activate it. It is incorrect to bind "\C-m" to `custom-no-edit' in `custom-mode', which inherits from `widget-keymap'. =20 Why was this change made in the first place? It seems pointless---Custom buffers are read-only, so self-insertion commands do nothing anyway; we don't have to bind them to a 'custom-no-edit' command that does nothing but raise an error. =20 I'm not responsible for the fix, but I reported the bug that was fixed: = See the thread "Customize buffer modification: indicator, feedback, = undo" in emacs-pretest, of June 10-11, 2006. =20