all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* facemenu-set-face doc string
@ 2007-03-20 21:29 Drew Adams
  2007-03-20 21:57 ` Drew Adams
  0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2007-03-20 21:29 UTC (permalink / raw)
  To: Emacs-Devel

The current explanation is not very clear, IMO (just what are "the faces to
use"? apply a face to faces?).

I propose a minor change: use active voice and refer to
`facemenu-add-new-face' and `facemenu-add-face', whose doc strings are
clear.

OLD:

 Apply FACE to the region or next character typed.

 If the region is active (normally true except in Transient
 Mark mode) and nonempty, and there is no prefix argument,
 this command applies FACE to the region.  Otherwise, it applies FACE
 to the faces to use for the next character
 inserted.  (Moving point or switching buffers before typing
 a character to insert cancels the specification.)

 If FACE is `default', to \"apply\" it means clearing
 the list of faces to be used.  For any other value of FACE,
 to \"apply\" it means putting FACE at the front of the list
 of faces to be used, and removing any faces further
 along in the list that would be completely overridden by
 preceding faces (including FACE).

 This command can also add FACE to the menu of faces,
 if `facemenu-listed-faces' says to do that.

PROPOSED:

 Apply FACE to the region or the next character typed.
 If there is no prefix argument and the region is active and nonempty,
 then apply FACE to the region.  Otherwise, apply FACE to the next
 character inserted.

 Call `facemenu-add-new-face', then `facemenu-add-face'.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: facemenu-set-face doc string
  2007-03-20 21:29 facemenu-set-face doc string Drew Adams
@ 2007-03-20 21:57 ` Drew Adams
  0 siblings, 0 replies; 2+ messages in thread
From: Drew Adams @ 2007-03-20 21:57 UTC (permalink / raw)
  To: Emacs-Devel

Sorry, I forgot this important piece of info from the current doc string. It
is needed, or users won't understand why nothing happens when the region is
empty or inactive and they pick a face that is excluded by
`facemenu-listed-faces':

  Add FACE to the menu of faces, if allowed by `facemenu-listed-faces'.

> The current explanation is not very clear, IMO (just what are
> "the faces to
> use"? apply a face to faces?).
>
> I propose a minor change: use active voice and refer to
> `facemenu-add-new-face' and `facemenu-add-face', whose doc strings are
> clear.
>
> OLD:
>
>  Apply FACE to the region or next character typed.
>
>  If the region is active (normally true except in Transient
>  Mark mode) and nonempty, and there is no prefix argument,
>  this command applies FACE to the region.  Otherwise, it applies FACE
>  to the faces to use for the next character
>  inserted.  (Moving point or switching buffers before typing
>  a character to insert cancels the specification.)
>
>  If FACE is `default', to \"apply\" it means clearing
>  the list of faces to be used.  For any other value of FACE,
>  to \"apply\" it means putting FACE at the front of the list
>  of faces to be used, and removing any faces further
>  along in the list that would be completely overridden by
>  preceding faces (including FACE).
>
>  This command can also add FACE to the menu of faces,
>  if `facemenu-listed-faces' says to do that.
>
> PROPOSED:
>
>  Apply FACE to the region or the next character typed.
>  If there is no prefix argument and the region is active and nonempty,
>  then apply FACE to the region.  Otherwise, apply FACE to the next
>  character inserted.
>
>  Call `facemenu-add-new-face', then `facemenu-add-face'.
>
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-20 21:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-20 21:29 facemenu-set-face doc string Drew Adams
2007-03-20 21:57 ` Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.