From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: pp-eval-expression broken Date: Fri, 5 Jan 2007 09:52:58 -0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1168019631 23899 80.91.229.12 (5 Jan 2007 17:53:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 5 Jan 2007 17:53:51 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 05 18:53:49 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H2tGF-0003IS-3H for ged-emacs-devel@m.gmane.org; Fri, 05 Jan 2007 18:53:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H2tGE-0005U7-Hb for ged-emacs-devel@m.gmane.org; Fri, 05 Jan 2007 12:53:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H2tFv-0005Tq-JR for emacs-devel@gnu.org; Fri, 05 Jan 2007 12:53:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H2tFu-0005TI-3L for emacs-devel@gnu.org; Fri, 05 Jan 2007 12:53:27 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H2tFt-0005TB-Uq for emacs-devel@gnu.org; Fri, 05 Jan 2007 12:53:25 -0500 Original-Received: from [141.146.126.228] (helo=agminet01.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1H2tFt-0008Ow-8L for emacs-devel@gnu.org; Fri, 05 Jan 2007 12:53:25 -0500 Original-Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l05HrCfn015120 for ; Fri, 5 Jan 2007 11:53:13 -0600 Original-Received: from rcsmt250.oracle.com (rcsmt250.oracle.com [148.87.90.195]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l05Hf1Gj027540 for ; Fri, 5 Jan 2007 10:53:11 -0700 Original-Received: from dhcp-amer-rmdc-csvpn-gw4-141-144-101-117.vpn.oracle.com by rcsmt250.oracle.com with ESMTP id 2340768111168019581; Fri, 05 Jan 2007 10:53:01 -0700 Original-To: "Emacs-Devel" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3028 X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64828 Archived-At: I said: > `pp-eval-expression' was apparently changed to no longer evaluate its > argument. It evaluates only when called interactively. This breaks all > Lisp calls to `pp-eval-expression' (except those with > `call-interactively). > > This seems to have been changed by RMS on 2006-10-18: > > "(pp-eval-expression): Use `X' to read value. > Non-interactive arg is the value, not the expression." > > PLEASE reverse this change. Why was it made? Perhaps I shouldn't have been so strong about the request, and no doubt there is a good reason for this change. But I'd still like to know what the reason is. It seems odd to me that the command would treat its arg differently, evaling it if interactive and not evaling it otherwise. The function is named -eval-, but it doesn't always eval. And, as I said, this will break any existing Lisp calls to the function. Those have been fixed in vanilla Emacs (22), but outside libraries will need to adjust, especially if they try to work with multiple Emacs versions.