small rcirc suggestion

small rcirc suggestion

[Nic James Ferrier]

I know we're heading for release and this is not intended to disrupt
that in anyway... but I can't see where else to send this suggestion.

I find that I visit the same irc servers all the time and I'd like
history to reflect that:


diff -u /home/nferrier/rcirc.el\~ /home/nferrier/rcirc.el
--- /home/nferrier/rcirc.el~	2006-11-15 00:05:27.000000000 +0000
+++ /home/nferrier/rcirc.el	2006-11-15 10:37:02.000000000 +0000
@@ -319,19 +319,13 @@
 (defconst rcirc-id-string (concat "rcirc on GNU Emacs " emacs-version))
 \f
 (defvar rcirc-startup-channels nil)
-
-(defun rcirc-available-servers-to-alist ()
-  
-  )
 ;;;###autoload
 (defun rcirc (arg)
   "Connect to IRC.
 If ARG is non-nil, prompt for a server to connect to."
   (interactive "P")
   (if arg
-      (let* ((server (completing-read "IRC Server: "
-                                      (rcirc-defined-servers-to-alist)
-                                      rcirc-default-server))
+      (let* ((server (read-string "IRC Server: " rcirc-default-server))
 	     (port (read-string "IRC Port: " (number-to-string rcirc-default-port)))
 	     (nick (read-string "IRC Nick: " rcirc-default-nick))
 	     (channels (split-string



What would be really nice if history were persisted over emacs
invocations. Could one make history variables customizations and auto
save them?

-- 
Nic Ferrier
http://www.tapsellferrier.co.uk   for all your tapsell ferrier needs

Re: small rcirc suggestion

[Aidan Kehoe]

 Ar an cúigiú lá déag de mí na Samhain, scríobh Nic James Ferrier: 

 > [...] What would be really nice if history were persisted over emacs
 > invocations. Could one make history variables customizations and auto
 > save them?

See Hrvoje Nikšić’ http://www.emacswiki.org/cgi-bin/wiki/savehist-20+.el .

-- 
Santa Maradona, priez pour moi!

Re: small rcirc suggestion

[Reiner Steib]

On Wed, Nov 15 2006, Aidan Kehoe wrote:

>  Ar an cúigiú lá déag de mí na Samhain, scríobh Nic James Ferrier: 
>
>  > [...] What would be really nice if history were persisted over emacs
>  > invocations. Could one make history variables customizations and auto
>  > save them?
>
> See Hrvoje Nikšić’ http://www.emacswiki.org/cgi-bin/wiki/savehist-20+.el .

`savehist.el' is already included in Emacs 22.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

RE: small rcirc suggestion

[Drew Adams]

> > See Hrvoje Nikšić’ 
> http://www.emacswiki.org/cgi-bin/wiki/savehist-20+.el .
> 
> `savehist.el' is already included in Emacs 22.

FWIW - The version on Emacs Wiki was modified trivially so that it also works with older versions of Emacs - if you don't use an older Emacs version, then you don't need this version of savehist.el. This is mentioned in the Commentary of the file.

Re: small rcirc suggestion

[Stuart D. Herring]

> What would be really nice if history were persisted over emacs
> invocations. Could one make history variables customizations and auto
> save them?

See also desktop.el.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: small rcirc suggestion

[Nic James Ferrier]

Whoops!

I sent a patch to my own patch and it was very wrong.

Here's another patch - done right this time:

--- src/emacs-snapshot-20061111/lisp/net/rcirc.el	2006-09-12 23:05:57.000000000 +0100
+++ rcirc.el	2006-11-15 12:59:10.000000000 +0000
@@ -319,13 +319,15 @@
 (defconst rcirc-id-string (concat "rcirc on GNU Emacs " emacs-version))
 \f
 (defvar rcirc-startup-channels nil)
+
+(defvar rcirc-server-history nil)
 ;;;###autoload
 (defun rcirc (arg)
   "Connect to IRC.
 If ARG is non-nil, prompt for a server to connect to."
   (interactive "P")
   (if arg
-      (let* ((server (read-string "IRC Server: " rcirc-default-server))
+      (let* ((server (read-string "IRC Server: " rcirc-default-server 'rcirc-server-history rcirc-default-server))
 	     (port (read-string "IRC Port: " (number-to-string rcirc-default-port)))
 	     (nick (read-string "IRC Nick: " rcirc-default-nick))
 	     (channels (split-string


Sorry for any confusion and thanks to rms for reading my original
patch closely.

-- 
Nic Ferrier
http://www.tapsellferrier.co.uk   for all your tapsell ferrier needs