From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: bytecomp.el: issue warning when `mapcar' is called for effect Date: Tue, 19 Jun 2007 09:59:51 -0700 Message-ID: References: <86myyvdh8w.fsf@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1182272466 31513 80.91.229.12 (19 Jun 2007 17:01:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Jun 2007 17:01:06 +0000 (UTC) To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 19 19:01:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I0h4g-0008FH-IR for ged-emacs-devel@m.gmane.org; Tue, 19 Jun 2007 19:01:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I0h4f-0005hN-Qt for ged-emacs-devel@m.gmane.org; Tue, 19 Jun 2007 13:01:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I0h4c-0005fI-9w for emacs-devel@gnu.org; Tue, 19 Jun 2007 13:00:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I0h4b-0005dZ-CA for emacs-devel@gnu.org; Tue, 19 Jun 2007 13:00:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I0h4b-0005d0-74 for emacs-devel@gnu.org; Tue, 19 Jun 2007 13:00:57 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I0h4a-0007hz-J8 for emacs-devel@gnu.org; Tue, 19 Jun 2007 13:00:56 -0400 Original-Received: from rgmgw2.us.oracle.com (rgmgw2.us.oracle.com [138.1.186.111]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l5JH0rFs009909 for ; Tue, 19 Jun 2007 11:00:54 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by rgmgw2.us.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l5JEScNn029941 for ; Tue, 19 Jun 2007 11:00:53 -0600 Original-Received: from dhcp-amer-whq-csvpn-gw3-141-144-80-227.vpn.oracle.com by acsmt351.oracle.com with ESMTP id 2968925421182272395; Tue, 19 Jun 2007 09:59:55 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <86myyvdh8w.fsf@gmx.at> X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 Importance: Normal X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73321 Archived-At: > This makes the byte-compiler mention `mapc' and `dolist' where one of > them is preferable over `mapcar'. > > + "`mapcar' called for effect; use `mapc' or `dolist' instead")) How about "consider using" instead of "use"? This is, after all, a warning, not an error. Some libraries aim for use with multiple Emacs versions, and some Emacs versions don't have `mapc' or `dolist' (and a library might not have required `cl' at compile time). When users see such warnings, they can freak out, submit bug reports to the library maintainers, etc. If the message length is a problem, drop "instead" - "`mapcar' called for effect; consider using `mapc' or `dolist'" is not much longer than "`mapcar' called for effect; use `mapc' or `dolist' instead"